Paths

Table of Contentst

Differential D14681

[blob-client] Add assign_multiple_holders_with_retries
ClosedPublic
Actions

Authored by bartek on May 12 2025, 8:51 AM.

Details

Reviewers

kamil

Commits

rCOMMf8cf0691b6ee: [blob-client] Add assign_multiple_holders_with_retries

Summary

Blob's AssignMultipleHolders can partially succeed, and for each assigned holder it returns a success boolean.
We can retry with backoff for such partial failures. Added a helper function which handles this for us.

Depends on D14680

Test Plan

tested in later diffs

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 12 2025, 8:51 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 12 2025, 8:51 AM

bartek added a child revision: D14682: [backup] Refactor HTTP handler utility functions.May 12 2025, 8:54 AM

Harbormaster completed remote builds in B34143: Diff 48030.May 12 2025, 9:12 AM

bartek published this revision for review.May 12 2025, 9:51 AM

bartek added inline comments.

shared/comm-lib/src/blob/client.rs
324–325 ↗	(On Diff #48030)	I realized we can directly move the value instead of mutably zeroing source Vec

kamil accepted this revision.May 14 2025, 10:45 AM

This revision is now accepted and ready to land.May 14 2025, 10:45 AM

Apply fix

Harbormaster completed remote builds in B34175: Diff 48084.May 15 2025, 12:42 PM

Closed by commit rCOMMf8cf0691b6ee: [blob-client] Add assign_multiple_holders_with_retries. · Explain WhyMay 16 2025, 1:35 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMf8cf0691b6ee: [blob-client] Add assign_multiple_holders_with_retries.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

error.rs

1 line

shared/

comm-lib/

src/

blob/

client.rs

48 lines

types.rs

12 lines

Diff 48104

View Options

services/backup/src/error.rs

View Options

shared/comm-lib/src/blob/client.rs

View Options

shared/comm-lib/src/blob/types.rs

[blob-client] Add assign_multiple_holders_with_retriesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48104

services/backup/src/error.rs

shared/comm-lib/src/blob/client.rs

shared/comm-lib/src/blob/types.rs

[blob-client] Add assign_multiple_holders_with_retries
ClosedPublic
Actions

Revision Contents
Changeset List