Paths

Table of Contentst

Differential D14674

[backup] Return backup size and timestamp in LatestBackupInfo
ClosedPublic
Actions

Authored by bartek on May 9 2025, 9:52 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMMeb8b73616e6d: [backup] Return backup size and timestamp in LatestBackupInfo

Summary

Address ENG-9995 and ENG-9996.
Updated LatestBackupInfo endpoint to calculate and return backup size and creation timestamp.

For now, this is the "ask every time" approach from ENG-9995 / ENG-10727. Caching will be added in subsequent diffs.

Depends on D14649, D14673

Test Plan

tested on staging, native compiles

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 9 2025, 9:52 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 9 2025, 9:52 AM

bartek added a child revision: D14675: [native] Pass backup size, timestamp and version info to JS.May 9 2025, 9:53 AM

Harbormaster completed remote builds in B34129: Diff 48002.May 9 2025, 10:12 AM

bartek edited the summary of this revision. (Show Details)May 9 2025, 3:43 PM

bartek published this revision for review.May 9 2025, 3:47 PM

bartek added inline comments.

native/native_rust_library/src/backup.rs
383–395 ↗	(On Diff #48002)	I don't know why it was earlier destructured just to be composed again
shared/comm-lib/src/backup/mod.rs
17–18 ↗	(On Diff #48002)	I decided to pass it as ISO string because it's easily convertible to JS Date by using `new Date(backupInfo.creationTimestamp)`

bartek added a child revision: D14676: [blob-client] Add method to assign multiple holders.May 13 2025, 3:05 PM

kamil accepted this revision.May 14 2025, 10:26 AM

kamil added inline comments.

native/native_rust_library/src/backup.rs
383–395 ↗	(On Diff #48002)	I don't know either, strange
shared/comm-lib/src/backup/mod.rs
17–19 ↗	(On Diff #48002)	Just adding this won't break the existing client: Client older than backup -> serde ignores additional fields client newer than backup -> will be handled in D14674

This revision is now accepted and ready to land.May 14 2025, 10:26 AM

bartek mentioned this in D14675: [native] Pass backup size, timestamp and version info to JS.May 15 2025, 12:34 PM

bartek removed a child revision: D14675: [native] Pass backup size, timestamp and version info to JS.

Closed by commit rCOMMeb8b73616e6d: [backup] Return backup size and timestamp in LatestBackupInfo. · Explain WhyMay 16 2025, 1:35 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMeb8b73616e6d: [backup] Return backup size and timestamp in LatestBackupInfo.

bartek mentioned this in rCOMM8b776350234b: [native] Pass backup size, timestamp and version info to JS.May 26 2025, 11:59 AM

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

17 lines

services/

backup/

src/

database/

29 lines

http/

handlers/

55 lines

shared/

comm-lib/

src/

backup/

3 lines

Diff 48101

native/native_rust_library/src/backup.rs

Loading...

services/backup/src/database/mod.rs

Loading...

services/backup/src/http/handlers/backup.rs

Loading...

shared/comm-lib/src/backup/mod.rs

Loading...