Paths

Table of Contentst

Differential D14673

[backup] Refactor DDB log fetch functions
ClosedPublic
Actions

Authored by bartek on May 9 2025, 9:50 AM.

Details

Reviewers

kamil

Commits

rCOMMde3e8ea25e2a: [backup] Refactor DDB log fetch functions

Summary

Some minor refactors to DDB fetching functions, useful for later diffs

Test Plan

cargo build

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 9 2025, 9:50 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 9 2025, 9:50 AM

bartek added a child revision: D14674: [backup] Return backup size and timestamp in LatestBackupInfo.May 9 2025, 9:52 AM

Harbormaster completed remote builds in B34128: Diff 48001.May 9 2025, 10:10 AM

Rebase

Harbormaster completed remote builds in B34132: Diff 48005.May 9 2025, 11:12 AM

bartek published this revision for review.May 9 2025, 11:30 AM

bartek added inline comments.

services/backup/src/database/mod.rs
315–324 ↗	(On Diff #48005)	I'm wondering if this is more readable to others as well. Previously, the `fetch_log_items` was called twice here

bartek added a child revision: D14684: [backup] Create function to copy logs between backups.May 12 2025, 10:16 AM

kamil accepted this revision.May 14 2025, 10:09 AM

kamil added inline comments.

services/backup/src/database/mod.rs
315–324 ↗	(On Diff #48005)	should be fine

This revision is now accepted and ready to land.May 14 2025, 10:09 AM

Closed by commit rCOMMde3e8ea25e2a: [backup] Refactor DDB log fetch functions. · Explain WhyMay 16 2025, 1:35 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMde3e8ea25e2a: [backup] Refactor DDB log fetch functions.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

database/

mod.rs

77 lines

Diff 48100

View Options

services/backup/src/database/mod.rs

[backup] Refactor DDB log fetch functionsClosedPublicActions