Page MenuHomePhabricator
Differential D13644

[comm-lib] Add remove_multiple_holders to Blob client
ClosedPublic
Actions

Authored by bartek on Oct 9 2024, 1:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 9:58 PM
Unknown Object (File)
Thu, Nov 14, 3:59 PM
Unknown Object (File)
Thu, Nov 14, 12:58 PM
Unknown Object (File)
Thu, Nov 14, 12:53 PM
Unknown Object (File)
Sat, Nov 9, 3:56 AM
Unknown Object (File)
Sat, Nov 9, 2:23 AM
Unknown Object (File)
Fri, Nov 8, 10:12 AM
Unknown Object (File)
Fri, Nov 8, 9:21 AM
View All 47 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
will
Commits
rCOMMe31290555a24: [comm-lib] Add remove_multiple_holders to Blob client
Summary

We're missing functions for batch holders endpoints in BlobServiceClient.
Started with the one that's needed for server-side holder cleanup

Depends on D13617

Test Plan
  1. Started Blob service. Created a few holders.
  2. Created a dummy test that calls this function.
  3. Ran cargo test and verified that these holders were now removed from DDB

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Oct 9 2024, 1:15 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 9 2024, 1:15 AM
bartek added a child revision: D13645: [comm-lib][blob-client] Extract error handling logic.Oct 9 2024, 1:17 AM
bartek mentioned this in D13648: [comm-lib][blob-client] Add support for removing holders by tags.Oct 9 2024, 1:26 AM
Harbormaster completed remote builds in B32124: Diff 44994.Oct 9 2024, 1:33 AM
bartek published this revision for review.Oct 9 2024, 1:55 AM
kamil accepted this revision.Oct 10 2024, 2:02 AM
kamil added inline comments.
shared/comm-lib/src/blob/client.rs
263 ↗(On Diff #44994)

given the name for single edpoint, shouldn't this be revoke_multiple_holders?

This revision is now accepted and ready to land.Oct 10 2024, 2:02 AM
Closed by commit rCOMMe31290555a24: [comm-lib] Add remove_multiple_holders to Blob client (authored by bartek). · Explain WhyOct 14 2024, 7:20 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMe31290555a24: [comm-lib] Add remove_multiple_holders to Blob client.
bartek mentioned this in rCOMMb5d7583ea75d: [comm-lib][blob-client] Add support for removing holders by tags.
ashoat added inline comments.Oct 14 2024, 12:09 PM
shared/comm-lib/src/blob/client.rs
263 ↗(On Diff #44994)

It seems like this feedback wasn't addressed

Revision Contents
Changeset List

PathSize
shared/
comm-lib/
src/
blob/
58 lines
4 lines

Diff 45159

View Options

shared/comm-lib/src/blob/client.rs

Loading...
View Options

shared/comm-lib/src/blob/types.rs

Loading...