Page MenuHomePhabricator
Differential D13646

[comm-lib][blob] Add tags support to remove holders request payload
ClosedPublic
Actions

Authored by bartek on Oct 9 2024, 1:20 AM.
Tags
None
Referenced Files
F5109343: D13646.diff
Tue, Apr 1, 6:18 PM
Unknown Object (File)
Sat, Mar 29, 9:46 PM
Unknown Object (File)
Tue, Mar 18, 6:43 AM
Unknown Object (File)
Tue, Mar 18, 6:15 AM
Unknown Object (File)
Mon, Mar 17, 8:43 AM
Unknown Object (File)
Sat, Mar 15, 3:18 AM
Unknown Object (File)
Fri, Mar 14, 4:12 AM
Unknown Object (File)
Tue, Mar 11, 7:18 AM
View All 83 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
will
Commits
rCOMM6c8640428254: [comm-lib][blob] Add tags support to remove holders request payload
Summary

Expanded RemoveHoldersRequest to support either current payload format, or the new one that
removes holders that matches given tags. The new format is not supported yet, so added HTTP 501 Unimplemented response server side.

Depends on D13645

Test Plan

Unit tests for serialize/deserialize to make sure that existing request format is untouched.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
blob/
src/
http/
handlers/
9 lines
shared/
comm-lib/
src/
blob/
2 lines
90 lines

Diff 45161

View Options

services/blob/src/http/handlers/holders.rs

  • This file was added.
// @flow
import type {
StackNavigationEventMap,
StackNavigationState,
StackOptions,
} from '@react-navigation/core';
import * as React from 'react';
import { Text } from 'react-native';
import { type QRAuthNavigationProp } from './qr-auth-navigator.react.js';
import RegistrationButtonContainer from '../../account/registration/registration-button-container.react.js';
import RegistrationContainer from '../../account/registration/registration-container.react.js';
import RegistrationContentContainer from '../../account/registration/registration-content-container.react.js';
import PrimaryButton from '../../components/primary-button.react.js';
import type { RootNavigationProp } from '../../navigation/root-navigator.react.js';
import {
type NavigationRoute,
type ScreenParamList,
} from '../../navigation/route-names.js';
import { useStyles } from '../../themes/colors.js';
type Props = {
+navigation: QRAuthNavigationProp<'QRAuthNotPrimaryDevice'>,
+route: NavigationRoute<'QRAuthNotPrimaryDevice'>,
};
function QRAuthNotPrimaryDevice(prop: Props): React.Node {
const { navigation } = prop;
const styles = useStyles(unboundStyles);
const onPressGoBack = React.useCallback(() => {
navigation
.getParent<
ScreenParamList,
'LinkedDevicesBottomSheet',
StackNavigationState,
StackOptions,
StackNavigationEventMap,
RootNavigationProp<'LinkedDevicesBottomSheet'>,
>()
?.goBack();
}, [navigation]);
return (
<RegistrationContainer>
<RegistrationContentContainer>
<Text style={styles.header}>Device not primary</Text>
<Text style={styles.body}>
This mobile device is not your primary device, and cannot be used to
authorize new devices. Please try your other mobile device(s).
</Text>
</RegistrationContentContainer>
<RegistrationButtonContainer>
<PrimaryButton
onPress={onPressGoBack}
label="Go back"
variant="enabled"
/>
</RegistrationButtonContainer>
</RegistrationContainer>
);
}
const unboundStyles = {
header: {
fontSize: 24,
color: 'panelForegroundLabel',
paddingBottom: 16,
},
body: {
fontFamily: 'Arial',
fontSize: 15,
lineHeight: 20,
color: 'panelForegroundSecondaryLabel',
paddingBottom: 16,
},
};
export default QRAuthNotPrimaryDevice;
View Options

shared/comm-lib/src/blob/client.rs

  • This file was added.
// @flow
import type {
StackNavigationEventMap,
StackNavigationState,
StackOptions,
} from '@react-navigation/core';
import * as React from 'react';
import { Text } from 'react-native';
import { type QRAuthNavigationProp } from './qr-auth-navigator.react.js';
import RegistrationButtonContainer from '../../account/registration/registration-button-container.react.js';
import RegistrationContainer from '../../account/registration/registration-container.react.js';
import RegistrationContentContainer from '../../account/registration/registration-content-container.react.js';
import PrimaryButton from '../../components/primary-button.react.js';
import type { RootNavigationProp } from '../../navigation/root-navigator.react.js';
import {
type NavigationRoute,
type ScreenParamList,
} from '../../navigation/route-names.js';
import { useStyles } from '../../themes/colors.js';
type Props = {
+navigation: QRAuthNavigationProp<'QRAuthNotPrimaryDevice'>,
+route: NavigationRoute<'QRAuthNotPrimaryDevice'>,
};
function QRAuthNotPrimaryDevice(prop: Props): React.Node {
const { navigation } = prop;
const styles = useStyles(unboundStyles);
const onPressGoBack = React.useCallback(() => {
navigation
.getParent<
ScreenParamList,
'LinkedDevicesBottomSheet',
StackNavigationState,
StackOptions,
StackNavigationEventMap,
RootNavigationProp<'LinkedDevicesBottomSheet'>,
>()
?.goBack();
}, [navigation]);
return (
<RegistrationContainer>
<RegistrationContentContainer>
<Text style={styles.header}>Device not primary</Text>
<Text style={styles.body}>
This mobile device is not your primary device, and cannot be used to
authorize new devices. Please try your other mobile device(s).
</Text>
</RegistrationContentContainer>
<RegistrationButtonContainer>
<PrimaryButton
onPress={onPressGoBack}
label="Go back"
variant="enabled"
/>
</RegistrationButtonContainer>
</RegistrationContainer>
);
}
const unboundStyles = {
header: {
fontSize: 24,
color: 'panelForegroundLabel',
paddingBottom: 16,
},
body: {
fontFamily: 'Arial',
fontSize: 15,
lineHeight: 20,
color: 'panelForegroundSecondaryLabel',
paddingBottom: 16,
},
};
export default QRAuthNotPrimaryDevice;
View Options

shared/comm-lib/src/blob/types.rs

  • This file was added.
// @flow
import type {
StackNavigationEventMap,
StackNavigationState,
StackOptions,
} from '@react-navigation/core';
import * as React from 'react';
import { Text } from 'react-native';
import { type QRAuthNavigationProp } from './qr-auth-navigator.react.js';
import RegistrationButtonContainer from '../../account/registration/registration-button-container.react.js';
import RegistrationContainer from '../../account/registration/registration-container.react.js';
import RegistrationContentContainer from '../../account/registration/registration-content-container.react.js';
import PrimaryButton from '../../components/primary-button.react.js';
import type { RootNavigationProp } from '../../navigation/root-navigator.react.js';
import {
type NavigationRoute,
type ScreenParamList,
} from '../../navigation/route-names.js';
import { useStyles } from '../../themes/colors.js';
type Props = {
+navigation: QRAuthNavigationProp<'QRAuthNotPrimaryDevice'>,
+route: NavigationRoute<'QRAuthNotPrimaryDevice'>,
};
function QRAuthNotPrimaryDevice(prop: Props): React.Node {
const { navigation } = prop;
const styles = useStyles(unboundStyles);
const onPressGoBack = React.useCallback(() => {
navigation
.getParent<
ScreenParamList,
'LinkedDevicesBottomSheet',
StackNavigationState,
StackOptions,
StackNavigationEventMap,
RootNavigationProp<'LinkedDevicesBottomSheet'>,
>()
?.goBack();
}, [navigation]);
return (
<RegistrationContainer>
<RegistrationContentContainer>
<Text style={styles.header}>Device not primary</Text>
<Text style={styles.body}>
This mobile device is not your primary device, and cannot be used to
authorize new devices. Please try your other mobile device(s).
</Text>
</RegistrationContentContainer>
<RegistrationButtonContainer>
<PrimaryButton
onPress={onPressGoBack}
label="Go back"
variant="enabled"
/>
</RegistrationButtonContainer>
</RegistrationContainer>
);
}
const unboundStyles = {
header: {
fontSize: 24,
color: 'panelForegroundLabel',
paddingBottom: 16,
},
body: {
fontFamily: 'Arial',
fontSize: 15,
lineHeight: 20,
color: 'panelForegroundSecondaryLabel',
paddingBottom: 16,
},
};
export default QRAuthNotPrimaryDevice;