Differential D13586

[Tunnelbroker] retry FCM notif after receiving `401 Unauthorized`
ClosedPublic
Actions

Authored by kamil on Oct 3 2024, 3:20 AM.

Details

Reviewers

bartek

Commits

rCOMMacfc1987fde6: [Tunnelbroker] retry FCM notif after receiving `401 Unauthorized`

Summary

ENG-9442.

Test Plan

Android notifs works.
Simulate 401 and see if token was regenerated.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Oct 3 2024, 3:20 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 3 2024, 3:20 AM

kamil published this revision for review.Oct 3 2024, 3:26 AM

Harbormaster completed remote builds in B32036: Diff 44860.Oct 3 2024, 3:37 AM

kamil edited the summary of this revision. (Show Details)Oct 3 2024, 3:39 AM

Don't we need any delay before retrying?

Edit: After a deeper look, we don't, ignore my comment

This revision is now accepted and ready to land.Oct 3 2024, 9:31 AM

Closed by commit rCOMMacfc1987fde6: [Tunnelbroker] retry FCM notif after receiving `401 Unauthorized` (authored by kamil). · Explain WhyOct 7 2024, 2:57 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMacfc1987fde6: [Tunnelbroker] retry FCM notif after receiving `401 Unauthorized`.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

notifs/

fcm/

mod.rs

87 lines

token.rs

7 lines

Diff 44920

View Options

services/tunnelbroker/src/notifs/fcm/mod.rs