Page MenuHomePhabricator
Differential D13706

[web] Add ellipsis on longer thread names
ClosedPublic
Actions

Authored by angelika on Oct 14 2024, 8:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 17, 9:37 AM
Unknown Object (File)
Sat, Nov 16, 10:47 AM
Unknown Object (File)
Sat, Nov 16, 10:47 AM
Unknown Object (File)
Sat, Nov 16, 10:47 AM
Unknown Object (File)
Sat, Nov 16, 10:47 AM
Unknown Object (File)
Mon, Nov 4, 8:38 PM
Unknown Object (File)
Sun, Nov 3, 10:05 PM
Unknown Object (File)
Fri, Nov 1, 2:32 PM
View All 41 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
kamil
Commits
rCOMM77480058d76e: [web] Add ellipsis on longer thread names
Summary

This diff adds ellipsis to longer thread names

Before:

Screenshot 2024-10-15 at 13.21.08.png (766×2 px, 180 KB)

After:

Screenshot 2024-10-15 at 13.22.51.png (642×2 px, 131 KB)

Test Plan
  1. Create a community with a longer name
  2. Verify that the ellipsis is added when thread name doesn't fit in browser window

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

angelika created this revision.Oct 14 2024, 8:19 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 14 2024, 8:19 AM
Harbormaster completed remote builds in B32233: Diff 45171.Oct 14 2024, 8:47 AM
angelika requested review of this revision.Oct 14 2024, 8:47 AM
angelika added reviewers: inka, kamil.Oct 15 2024, 4:23 AM
angelika edited the summary of this revision. (Show Details)
kamil accepted this revision.Oct 15 2024, 11:38 PM

nit: worth adding a link to the Linear issue in diff summary, this always gives a reviewer a bit more context

This revision is now accepted and ready to land.Oct 15 2024, 11:38 PM
Closed by commit rCOMM77480058d76e: [web] Add ellipsis on longer thread names (authored by angelika). · Explain WhyOct 16 2024, 4:50 AM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM77480058d76e: [web] Add ellipsis on longer thread names.

Revision Contents
Changeset List

PathSize
web/
navigation-panels/
2 lines

Diff 45217

View Options

web/navigation-panels/chat-thread-ancestors.css

Loading...