Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Today

kamil added a comment to D7186: [web-db] start persisting SQLite content.

Adding debounce to persisting,
I set up the database for drafts and persist was not called on each character changed but was debounced as expected.

Fri, Mar 31, 2:38 AM
kamil updated the diff for D7186: [web-db] start persisting SQLite content.

add debounce

Fri, Mar 31, 2:36 AM
kamil closed D7248: [web-db] clean-up processing app requests on worker.
Fri, Mar 31, 2:15 AM
kamil committed rCOMM98aa16acc807: [web-db] clean-up processing app requests on worker (authored by kamil).
[web-db] clean-up processing app requests on worker
Fri, Mar 31, 2:15 AM
kamil closed D7185: [web-db] process redux-persist operations in SQLite.
Fri, Mar 31, 2:15 AM
kamil committed rCOMM6e9e7b457bb6: [web-db] process redux-persist operations in SQLite (authored by kamil).
[web-db] process redux-persist operations in SQLite
Fri, Mar 31, 2:15 AM

Yesterday

kamil requested changes to D7257: [native] Add `avatar` column to clientDB `threads` table.

Requesting changes to push it back to you, but if I am missing something re-request review and I will unblock this as soon as possible.

Thu, Mar 30, 11:38 PM
kamil added inline comments to D7186: [web-db] start persisting SQLite content.
Thu, Mar 30, 6:21 AM
kamil published D7248: [web-db] clean-up processing app requests on worker for review.
Thu, Mar 30, 6:18 AM
kamil added inline comments to D7185: [web-db] process redux-persist operations in SQLite.
Thu, Mar 30, 2:26 AM
kamil updated the diff for D7185: [web-db] process redux-persist operations in SQLite.

separate code for two diffs

Thu, Mar 30, 2:21 AM
kamil closed D7183: [web-db] add table and operations for redux-persist engine.
Thu, Mar 30, 1:24 AM
kamil closed D7184: [web-db] add unit tests for redux-persist engine operations.
Thu, Mar 30, 1:24 AM
kamil closed D7182: [web-db] implement setting/getting `currentUserID` on worker.
Thu, Mar 30, 1:24 AM
kamil committed rCOMM603ceea40cb4: [web-db] add table and operations for redux-persist engine (authored by kamil).
[web-db] add table and operations for redux-persist engine
Thu, Mar 30, 1:24 AM
kamil committed rCOMMeca70ade03b9: [web-db] add unit tests for redux-persist engine operations (authored by kamil).
[web-db] add unit tests for redux-persist engine operations
Thu, Mar 30, 1:24 AM
kamil closed D7181: [web-db] add unit tests for metadata operations.
Thu, Mar 30, 1:24 AM
kamil committed rCOMMc37fdc73806b: [web-db] implement setting/getting `currentUserID` on worker (authored by kamil).
[web-db] implement setting/getting `currentUserID` on worker
Thu, Mar 30, 1:24 AM
kamil closed D7180: [web-db] add metadata table operations.
Thu, Mar 30, 1:24 AM
kamil committed rCOMM1120f89ed7bb: [web-db] add unit tests for metadata operations (authored by kamil).
[web-db] add unit tests for metadata operations
Thu, Mar 30, 1:24 AM
kamil committed rCOMM005ff6a137c5: [web-db] add metadata table operations (authored by kamil).
[web-db] add metadata table operations
Thu, Mar 30, 1:24 AM
kamil closed D7154: [web-db] get client database store from SQLite.
Thu, Mar 30, 1:24 AM
kamil committed rCOMMf643d8fcd460: [web-db] get client database store from SQLite (authored by kamil).
[web-db] get client database store from SQLite
Thu, Mar 30, 1:24 AM
kamil closed D7153: [web-db] process Draft Store Operations on worker.
Thu, Mar 30, 1:24 AM
kamil committed rCOMMefff9422557b: [web-db] process Draft Store Operations on worker (authored by kamil).
[web-db] process Draft Store Operations on worker
Thu, Mar 30, 1:24 AM
kamil closed D7124: [web-db] add unit tests for draft store queries.
Thu, Mar 30, 1:24 AM
kamil closed D7123: [web-db] implement function get all drafts from SQLite.
Thu, Mar 30, 1:24 AM
kamil committed rCOMMceff50b57731: [web-db] add unit tests for draft store queries (authored by kamil).
[web-db] add unit tests for draft store queries
Thu, Mar 30, 1:24 AM
kamil closed D7122: [web-db] implement Draft Store Operations.
Thu, Mar 30, 1:24 AM
kamil committed rCOMM85b420a7217c: [web-db] implement function get all drafts from SQLite (authored by kamil).
[web-db] implement function get all drafts from SQLite
Thu, Mar 30, 1:24 AM
kamil committed rCOMM640ebb7a374d: [web-db] implement Draft Store Operations (authored by kamil).
[web-db] implement Draft Store Operations
Thu, Mar 30, 1:24 AM
kamil closed D7121: [web-db] create drafts table in SQLite database.
Thu, Mar 30, 1:24 AM
kamil committed rCOMM5dea58c20130: [web-db] create drafts table in SQLite database (authored by kamil).
[web-db] create drafts table in SQLite database
Thu, Mar 30, 1:24 AM
kamil added inline comments to D7180: [web-db] add metadata table operations.
Thu, Mar 30, 1:19 AM
kamil updated the diff for D7183: [web-db] add table and operations for redux-persist engine.

fix query format

Thu, Mar 30, 1:01 AM
kamil updated the diff for D7180: [web-db] add metadata table operations.

fix type and query format

Thu, Mar 30, 12:58 AM
kamil updated the diff for D7124: [web-db] add unit tests for draft store queries.

fix query formatting

Thu, Mar 30, 12:20 AM
kamil updated the diff for D7123: [web-db] implement function get all drafts from SQLite.

address nit

Thu, Mar 30, 12:17 AM

Tue, Mar 28

kamil accepted D7202: [native] Add pinned_count column to SQLite threads table.

Looks good!!

Tue, Mar 28, 8:58 AM
kamil requested changes to D7202: [native] Add pinned_count column to SQLite threads table.

In the test plan for the Confirm migration for new clients already with the column works

I'm not entirely sure if we really even need to consider a case where a new client will already have the column besides me in development work, so I can also just remove that check entirely and just add the column. I ran into this inconsistency while working off of my modified schema and running a migration on top of that

Tue, Mar 28, 3:15 AM

Mon, Mar 27

kamil requested changes to D7202: [native] Add pinned_count column to SQLite threads table.

When you're modifying SQLite database on native you should do two things:

  1. Update create_schema - this code is running on a fresh install/logout user (you did it properly)
  2. Add new migration which will update this table when existing users will update the app to a newer version. We were adding NOT EXISTS everywhere because of multiple crashes at that time, but I think it should work without this constraint (a lot of refactors were done to avoid problems). If you really want to make this code resistant you can use PRAGMA table_info() to check if the column exists and then execute ALTER TABLE.
Mon, Mar 27, 12:59 PM
kamil published D7191: [web-db] implement clearing sensitive data for review.
Mon, Mar 27, 8:48 AM
kamil published D7190: [web-db] implement custom `redux-persist` storage for review.
Mon, Mar 27, 8:30 AM
kamil published D7189: [web-db] add database module provider for review.
Mon, Mar 27, 8:30 AM
kamil published D7188: [web-db] support SQLite for staff and non-mobile browsers for review.
Mon, Mar 27, 8:15 AM
kamil published D7186: [web-db] start persisting SQLite content for review.
Mon, Mar 27, 5:10 AM
kamil published D7185: [web-db] process redux-persist operations in SQLite for review.
Mon, Mar 27, 5:06 AM
kamil published D7184: [web-db] add unit tests for redux-persist engine operations for review.
Mon, Mar 27, 5:05 AM
kamil published D7183: [web-db] add table and operations for redux-persist engine for review.
Mon, Mar 27, 5:05 AM
kamil published D7182: [web-db] implement setting/getting `currentUserID` on worker for review.
Mon, Mar 27, 5:03 AM
kamil published D7181: [web-db] add unit tests for metadata operations for review.
Mon, Mar 27, 5:03 AM
kamil published D7180: [web-db] add metadata table operations for review.
Mon, Mar 27, 5:02 AM

Sat, Mar 25

kamil closed D7119: [web-db] add unit tests to function for parsing SQLite query.
Sat, Mar 25, 5:52 AM
kamil committed rCOMM1abf9fd998af: [web-db] add unit tests to function for parsing SQLite query (authored by kamil).
[web-db] add unit tests to function for parsing SQLite query
Sat, Mar 25, 5:52 AM
kamil closed D7118: [web-db] add function for parsing SQLite query.
Sat, Mar 25, 5:52 AM
kamil committed rCOMMbd523b2a5403: [web-db] add function for parsing SQLite query (authored by kamil).
[web-db] add function for parsing SQLite query
Sat, Mar 25, 5:52 AM
kamil added inline comments to D7123: [web-db] implement function get all drafts from SQLite.
Sat, Mar 25, 5:46 AM
kamil updated the diff for D7119: [web-db] add unit tests to function for parsing SQLite query.

rebase

Sat, Mar 25, 5:35 AM
kamil updated the diff for D7118: [web-db] add function for parsing SQLite query.

address review

Sat, Mar 25, 5:33 AM
kamil closed D7104: [web-db] add unit tests for worker crypto utils.
Sat, Mar 25, 5:01 AM
kamil committed rCOMM83b3550cd01b: [web-db] add unit tests for worker crypto utils (authored by kamil).
[web-db] add unit tests for worker crypto utils
Sat, Mar 25, 5:01 AM
kamil closed D6996: [web-db] generate `CryptoKey` and persist.
Sat, Mar 25, 5:01 AM
kamil committed rCOMMc6ea9a5a2f99: [web-db] generate `CryptoKey` and persist (authored by kamil).
[web-db] generate `CryptoKey` and persist
Sat, Mar 25, 5:01 AM
kamil closed D6995: [web-db] implement crypto functions.
Sat, Mar 25, 5:01 AM
kamil committed rCOMM7096eb583d29: [web-db] implement crypto functions (authored by kamil).
[web-db] implement crypto functions
Sat, Mar 25, 5:01 AM
kamil added a comment to D7104: [web-db] add unit tests for worker crypto utils.

FYI By mistake, two diffs had different order in the stack than in my branch on git - that's why I needed to fix parent/child revisions because arcanist didn't allow me to arc diff but this has no influence on the code itself

Sat, Mar 25, 4:51 AM
kamil updated the diff for D7104: [web-db] add unit tests for worker crypto utils.

rebase before landing

Sat, Mar 25, 4:44 AM
kamil updated the diff for D6996: [web-db] generate `CryptoKey` and persist.

rebase before landing

Sat, Mar 25, 4:41 AM
kamil updated the diff for D6995: [web-db] implement crypto functions.

rebase before landing

Sat, Mar 25, 4:10 AM
kamil closed D7102: [web-db] implement function to get database version.
Sat, Mar 25, 4:02 AM
kamil closed D7103: [web-db] add unit tests for `sql.js`.
Sat, Mar 25, 4:02 AM
kamil committed rCOMM9943cf1dd98c: [web-db] implement function to get database version (authored by kamil).
[web-db] implement function to get database version
Sat, Mar 25, 4:02 AM
kamil committed rCOMMb191d4bc8962: [web-db] add unit tests for `sql.js` (authored by kamil).
[web-db] add unit tests for `sql.js`
Sat, Mar 25, 4:02 AM
kamil closed D7101: [web-db] add `sql.js` types.
Sat, Mar 25, 4:02 AM
kamil committed rCOMM3f1a02bb68b0: [web-db] add `sql.js` types (authored by kamil).
[web-db] add `sql.js` types
Sat, Mar 25, 4:02 AM
kamil updated the diff for D7103: [web-db] add unit tests for `sql.js`.

rebase before landing

Sat, Mar 25, 3:37 AM
kamil updated the diff for D7102: [web-db] implement function to get database version.

rebase before landing

Sat, Mar 25, 3:36 AM
kamil updated the diff for D7101: [web-db] add `sql.js` types.

reabse before landing

Sat, Mar 25, 3:34 AM

Fri, Mar 24

kamil added inline comments to D7101: [web-db] add `sql.js` types.
Fri, Mar 24, 8:03 AM
kamil updated the diff for D7101: [web-db] add `sql.js` types.

address review

Fri, Mar 24, 8:02 AM

Thu, Mar 23

kamil published D7154: [web-db] get client database store from SQLite for review.
Thu, Mar 23, 6:28 AM
kamil published D7153: [web-db] process Draft Store Operations on worker for review.
Thu, Mar 23, 6:23 AM
kamil published D7124: [web-db] add unit tests for draft store queries for review.
Thu, Mar 23, 6:19 AM
kamil published D7123: [web-db] implement function get all drafts from SQLite for review.
Thu, Mar 23, 6:14 AM
kamil added inline comments to D7122: [web-db] implement Draft Store Operations.
Thu, Mar 23, 6:00 AM
kamil updated the diff for D7122: [web-db] implement Draft Store Operations.

add import, improve query format

Thu, Mar 23, 6:00 AM
kamil requested review of D7121: [web-db] create drafts table in SQLite database.
Thu, Mar 23, 5:24 AM
kamil added a comment to D7118: [web-db] add function for parsing SQLite query.
In D7118#212107, @ashoat wrote:

We should not be polluting the global namespace in D7101. You should not be able to use QueryExecResult without importing it unless it's in the Flow lib.

Thu, Mar 23, 5:18 AM
kamil updated the diff for D7118: [web-db] add function for parsing SQLite query.

add import

Thu, Mar 23, 5:16 AM
kamil updated the diff for D7102: [web-db] implement function to get database version.

rebase

Thu, Mar 23, 5:11 AM
kamil added inline comments to D7101: [web-db] add `sql.js` types.
Thu, Mar 23, 5:10 AM
kamil updated the diff for D7101: [web-db] add `sql.js` types.

address code review

Thu, Mar 23, 5:04 AM

Wed, Mar 22

kamil published D7122: [web-db] implement Draft Store Operations for review.
Wed, Mar 22, 5:34 AM
kamil published D7121: [web-db] create drafts table in SQLite database for review.
Wed, Mar 22, 5:34 AM
kamil added inline comments to D7118: [web-db] add function for parsing SQLite query.
Wed, Mar 22, 5:32 AM
kamil updated the diff for D7118: [web-db] add function for parsing SQLite query.

update type

Wed, Mar 22, 5:30 AM
kamil updated the diff for D7118: [web-db] add function for parsing SQLite query.

update type

Wed, Mar 22, 5:28 AM

Tue, Mar 21

kamil added inline comments to D7104: [web-db] add unit tests for worker crypto utils.
Tue, Mar 21, 9:51 AM
kamil updated the diff for D7103: [web-db] add unit tests for `sql.js`.

fix typo

Tue, Mar 21, 4:18 AM
kamil updated the diff for D7102: [web-db] implement function to get database version.

rename function to be more detailed

Tue, Mar 21, 4:16 AM
Next