Page MenuHomePhabricator
Feed Advanced Search

Fri, May 24

kamil closed D12131: [lib] creating `olm` session with device.
Fri, May 24, 8:39 AM
kamil committed rCOMM72f120f04045: [lib] creating `olm` session with device (authored by kamil).
[lib] creating `olm` session with device
Fri, May 24, 8:39 AM
kamil closed D12130: [web][native] persist Outbound P2P messages when processing store ops.
Fri, May 24, 8:39 AM
kamil committed rCOMM5f77f1fdae37: [web][native] persist Outbound P2P messages when processing store ops (authored by kamil).
[web][native] persist Outbound P2P messages when processing store ops
Fri, May 24, 8:39 AM
kamil closed D12129: [web][native] implement encrypting and persisting OutboundP2PMessage's content in the same SQLite transaction as persisting `olm` session.
Fri, May 24, 8:39 AM
kamil committed rCOMMcf875d56dede: [web][native] implement encrypting and persisting OutboundP2PMessage's content… (authored by kamil).
[web][native] implement encrypting and persisting OutboundP2PMessage's content…
Fri, May 24, 8:39 AM
kamil added a comment to D12204: [lib] update types to allow missing OTK when creating session.

Note to myself to update the code after D12131 is landed

Fri, May 24, 8:28 AM
kamil updated the diff for D12131: [lib] creating `olm` session with device.

rebase before landing

Fri, May 24, 8:17 AM
kamil closed D12111: [lib] implement removing OutboundP2P messages after confirmation.
Fri, May 24, 3:16 AM
kamil committed rCOMM26a5957ea5d1: [lib] implement removing OutboundP2P messages after confirmation (authored by kamil).
[lib] implement removing OutboundP2P messages after confirmation
Fri, May 24, 3:15 AM
kamil added inline comments to D12111: [lib] implement removing OutboundP2P messages after confirmation.
Fri, May 24, 2:50 AM
kamil updated the diff for D12111: [lib] implement removing OutboundP2P messages after confirmation.

address review

Fri, May 24, 2:46 AM

Thu, May 23

kamil closed D12080: [lib] implement Outbound P2P Messages API in `SQLiteAPI`.
Thu, May 23, 9:02 AM
kamil closed D12079: [native] implement Outbound P2P Messages API in JSI.
Thu, May 23, 9:02 AM
kamil closed D12078: [web] implement Outbound P2P Messages API on worker.
Thu, May 23, 9:02 AM
kamil committed rCOMM499548ee7875: [native] implement Outbound P2P Messages API in JSI (authored by kamil).
[native] implement Outbound P2P Messages API in JSI
Thu, May 23, 9:02 AM
kamil committed rCOMM5ef4977af924: [lib] implement Outbound P2P Messages API in `SQLiteAPI` (authored by kamil).
[lib] implement Outbound P2P Messages API in `SQLiteAPI`
Thu, May 23, 9:02 AM
kamil closed D12074: [SQLite] remove Outbound P2P messages based on `messageID` and `deviceID`.
Thu, May 23, 9:02 AM
kamil committed rCOMM824fab482d4b: [web] implement Outbound P2P Messages API on worker (authored by kamil).
[web] implement Outbound P2P Messages API on worker
Thu, May 23, 9:02 AM
kamil closed D12075: [SQLite] remove `deviceID` param when getting all Outbound P2P messages.
Thu, May 23, 9:02 AM
kamil closed D12071: [SQLite] add query to mark outbound P2P message as sent.
Thu, May 23, 9:02 AM
kamil committed rCOMMdcb171a7b9fa: [SQLite] remove Outbound P2P messages based on `messageID` and `deviceID` (authored by kamil).
[SQLite] remove Outbound P2P messages based on `messageID` and `deviceID`
Thu, May 23, 9:02 AM
kamil committed rCOMM20a9300d4d38: [SQLite] remove `deviceID` param when getting all Outbound P2P messages (authored by kamil).
[SQLite] remove `deviceID` param when getting all Outbound P2P messages
Thu, May 23, 9:02 AM
kamil committed rCOMMd3a7f01bc912: [SQLite] add query to mark outbound P2P message as sent (authored by kamil).
[SQLite] add query to mark outbound P2P message as sent
Thu, May 23, 9:02 AM
kamil closed D12070: [SQLite] add query to set ciphertext for outbound P2P message.
Thu, May 23, 9:02 AM
kamil closed D12069: [SQLite] add table with inbound P2P messages to backup blocklist.
Thu, May 23, 9:02 AM
kamil committed rCOMMf1eee6f0b7f7: [SQLite] add query to set ciphertext for outbound P2P message (authored by kamil).
[SQLite] add query to set ciphertext for outbound P2P message
Thu, May 23, 9:02 AM
kamil committed rCOMM490040c14024: [SQLite] add table with inbound P2P messages to backup blocklist (authored by kamil).
[SQLite] add table with inbound P2P messages to backup blocklist
Thu, May 23, 9:02 AM
kamil closed D12068: [SQLite] recreate table for Outbound P2P messages.
Thu, May 23, 9:02 AM
kamil committed rCOMM70d516d8aa73: [SQLite] recreate table for Outbound P2P messages (authored by kamil).
[SQLite] recreate table for Outbound P2P messages
Thu, May 23, 9:02 AM
kamil updated the diff for D12075: [SQLite] remove `deviceID` param when getting all Outbound P2P messages.

rebase

Thu, May 23, 8:38 AM
kamil updated the diff for D12074: [SQLite] remove Outbound P2P messages based on `messageID` and `deviceID`.

address review

Thu, May 23, 8:26 AM
kamil updated the diff for D12071: [SQLite] add query to mark outbound P2P message as sent.

address review

Thu, May 23, 8:21 AM
kamil updated the diff for D12070: [SQLite] add query to set ciphertext for outbound P2P message.

address review

Thu, May 23, 8:18 AM
kamil updated the diff for D12068: [SQLite] recreate table for Outbound P2P messages.
  • rebase
  • remove debug
  • keep line 80 chars
Thu, May 23, 8:11 AM
kamil closed D12077: [lib] add `deviceID` prop to Tunnelbroker's `MessageProcessed`.
Thu, May 23, 7:53 AM
kamil committed rCOMMc5c181b5b06f: [lib] add `deviceID` prop to Tunnelbroker's `MessageProcessed` (authored by kamil).
[lib] add `deviceID` prop to Tunnelbroker's `MessageProcessed`
Thu, May 23, 7:53 AM
kamil closed D12076: [lib] add sending Tunnelbroker message with already defined `messageID`.
Thu, May 23, 7:53 AM
kamil committed rCOMM1ee2cddd84c4: [lib] add sending Tunnelbroker message with already defined `messageID` (authored by kamil).
[lib] add sending Tunnelbroker message with already defined `messageID`
Thu, May 23, 7:53 AM
kamil added inline comments to D12077: [lib] add `deviceID` prop to Tunnelbroker's `MessageProcessed`.
Thu, May 23, 7:46 AM
kamil updated the diff for D12077: [lib] add `deviceID` prop to Tunnelbroker's `MessageProcessed`.

address review

Thu, May 23, 7:33 AM
kamil added inline comments to D12076: [lib] add sending Tunnelbroker message with already defined `messageID`.
Thu, May 23, 7:28 AM
kamil updated the diff for D12076: [lib] add sending Tunnelbroker message with already defined `messageID`.

address review

Thu, May 23, 7:28 AM
kamil added inline comments to D12092: [commtest] Add test for initial device list.
Thu, May 23, 6:37 AM
kamil accepted D12092: [commtest] Add test for initial device list.
Thu, May 23, 6:36 AM
kamil accepted D12091: [identity] Save initial device list to DDB.
Thu, May 23, 6:32 AM
kamil published D12204: [lib] update types to allow missing OTK when creating session for review.
Thu, May 23, 5:50 AM
kamil published D12203: [web] update `olm` API to allow creating session without OTKs for review.
Thu, May 23, 5:50 AM
kamil published D12202: [native] update `olm` API to allow creating session without OTKs for review.
Thu, May 23, 5:49 AM
kamil published D12201: [keyserver] add tests to creating `olm` session without OTKs for review.
Thu, May 23, 5:49 AM
kamil published D12200: [olm] bump `@commapp/olm` version for review.
Thu, May 23, 5:49 AM
kamil accepted D12119: [protos] Add RPC for secondary device logout.
Thu, May 23, 2:41 AM
kamil accepted D12122: [lib][native][web] Add LogOutSecondaryDevice RPC to identity client.
Thu, May 23, 2:40 AM
kamil accepted D12121: [native] Expose LogOutSecondaryDevice RPC via JSI.
Thu, May 23, 2:39 AM
kamil accepted D12120: [identity] Implement RPC to log out secondary device.
Thu, May 23, 2:35 AM
kamil accepted D12168: Delete unused cargo.lock files.
Thu, May 23, 2:27 AM

Tue, May 21

kamil published D12131: [lib] creating `olm` session with device for review.
Tue, May 21, 1:28 AM
kamil published D12130: [web][native] persist Outbound P2P messages when processing store ops for review.
Tue, May 21, 1:25 AM
kamil published D12129: [web][native] implement encrypting and persisting OutboundP2PMessage's content in the same SQLite transaction as persisting `olm` session for review.
Tue, May 21, 1:22 AM

Mon, May 20

kamil published D12111: [lib] implement removing OutboundP2P messages after confirmation for review.
Mon, May 20, 5:16 AM
kamil added a comment to D12050: [lib] Create a compaction after schema-changing migration.

This code (createAsyncMigrate) will be executed on app start (no matter if logged in/out). How about creating compaction after e.g. primary restore?

Mon, May 20, 3:14 AM
kamil added inline comments to D12050: [lib] Create a compaction after schema-changing migration.
Mon, May 20, 3:02 AM
kamil accepted D12013: [native] Verify if the backup version is correct.
Mon, May 20, 2:23 AM
kamil accepted D12036: Enable backup restoration for SIWE users via testing buttons.
Mon, May 20, 2:01 AM
kamil accepted D12032: Extract shared logci for SIWE panel state handling.
Mon, May 20, 1:54 AM
kamil accepted D12103: [terraform] Deploy Tunnelbroker 0.8 to staging.

Thanks for that!

Mon, May 20, 1:15 AM

Fri, May 17

kamil added a comment to D12060: [keyserver/lib/web] include communityStore in the initialReduxState.

One question:
If I remember correctly CommunityStore was introduced directly for SQLite which means web clients should have it - so there is no need to fetch and return it again as this is a duplication of data client should have.
If communityStore changed in keyserver DB we should have some mechanism (updates/state sync/handler which fetches it) to get the newest data.

Fri, May 17, 4:01 AM
kamil accepted D12089: [identity] Add function to verify initial device list.

What do you think about making errors more detailed?

Fri, May 17, 3:48 AM
kamil added inline comments to D12069: [SQLite] add table with inbound P2P messages to backup blocklist.
Fri, May 17, 3:37 AM
kamil updated the summary of D12069: [SQLite] add table with inbound P2P messages to backup blocklist.
Fri, May 17, 3:36 AM
kamil added inline comments to D12077: [lib] add `deviceID` prop to Tunnelbroker's `MessageProcessed`.
Fri, May 17, 3:33 AM
kamil published D12080: [lib] implement Outbound P2P Messages API in `SQLiteAPI` for review.
Fri, May 17, 3:27 AM
kamil published D12079: [native] implement Outbound P2P Messages API in JSI for review.
Fri, May 17, 3:26 AM
kamil published D12078: [web] implement Outbound P2P Messages API on worker for review.
Fri, May 17, 3:25 AM
kamil published D12075: [SQLite] remove `deviceID` param when getting all Outbound P2P messages for review.
Fri, May 17, 3:23 AM
kamil published D12074: [SQLite] remove Outbound P2P messages based on `messageID` and `deviceID` for review.
Fri, May 17, 3:23 AM
kamil published D12071: [SQLite] add query to mark outbound P2P message as sent for review.
Fri, May 17, 3:22 AM
kamil published D12070: [SQLite] add query to set ciphertext for outbound P2P message for review.
Fri, May 17, 3:21 AM

Thu, May 16

kamil closed D12047: [lib] rename `MessageToDevice` from SQLite to `OutboundP2PMessage`.
Thu, May 16, 10:23 AM
kamil closed D12046: [lib] rename `ReceivedMessageToDevice` to `InboundP2PMessage`.
Thu, May 16, 10:22 AM
kamil committed rCOMMfd41bc15f934: [lib] rename `MessageToDevice` from SQLite to `OutboundP2PMessage` (authored by kamil).
[lib] rename `MessageToDevice` from SQLite to `OutboundP2PMessage`
Thu, May 16, 10:22 AM
kamil committed rCOMMba5f1b8f468d: [lib] rename `ReceivedMessageToDevice` to `InboundP2PMessage` (authored by kamil).
[lib] rename `ReceivedMessageToDevice` to `InboundP2PMessage`
Thu, May 16, 10:22 AM
kamil closed D12045: [lib] rename `ClientMessageToDevice` in `tunnelbroker-context.js` to `TunnelbrokerClientMessageToDevice`.
Thu, May 16, 10:22 AM
kamil committed rCOMM6de8fd7938d1: [lib] rename `ClientMessageToDevice` in `tunnelbroker-context.js` to… (authored by kamil).
[lib] rename `ClientMessageToDevice` in `tunnelbroker-context.js` to…
Thu, May 16, 10:22 AM
kamil closed D12044: [web] improve handling of non-existing olm sessions.
Thu, May 16, 10:22 AM
kamil committed rCOMM029f7ae731a2: [web] improve handling of non-existing olm sessions (authored by kamil).
[web] improve handling of non-existing olm sessions
Thu, May 16, 10:22 AM
kamil accepted D11937: [lib] Update DB version while running a migration.
Thu, May 16, 10:08 AM
kamil updated the diff for D12047: [lib] rename `MessageToDevice` from SQLite to `OutboundP2PMessage`.

add missing rename

Thu, May 16, 10:01 AM
kamil published D12077: [lib] add `deviceID` prop to Tunnelbroker's `MessageProcessed` for review.
Thu, May 16, 9:39 AM
kamil published D12076: [lib] add sending Tunnelbroker message with already defined `messageID` for review.
Thu, May 16, 9:39 AM
kamil published D12069: [SQLite] add table with inbound P2P messages to backup blocklist for review.
Thu, May 16, 5:14 AM
kamil published D12068: [SQLite] recreate table for Outbound P2P messages for review.
Thu, May 16, 5:03 AM
kamil added inline comments to D12047: [lib] rename `MessageToDevice` from SQLite to `OutboundP2PMessage`.
Thu, May 16, 5:03 AM
kamil accepted D12067: [native] Create initial device list during registration.
Thu, May 16, 1:58 AM
kamil accepted D12066: [native] Pass initialDeviceList param through JSI.
Thu, May 16, 1:52 AM
kamil published D12047: [lib] rename `MessageToDevice` from SQLite to `OutboundP2PMessage` for review.
Thu, May 16, 1:34 AM
kamil published D12046: [lib] rename `ReceivedMessageToDevice` to `InboundP2PMessage` for review.
Thu, May 16, 1:34 AM
kamil published D12045: [lib] rename `ClientMessageToDevice` in `tunnelbroker-context.js` to `TunnelbrokerClientMessageToDevice` for review.
Thu, May 16, 1:34 AM
kamil published D12044: [web] improve handling of non-existing olm sessions for review.
Thu, May 16, 1:34 AM

Tue, May 14

kamil resigned from D12000: [native/web] make `findUserIdentities` RPC available to native and web.

Looks good but I wasn't reviewing previous diffs in the stack so letting @bartek do the final approval on whether type definitions and API usage are correct

Tue, May 14, 11:53 PM