Page MenuHomePhabricator
Differential D14055

[web][native] add white frame around QR code
ClosedPublic
Actions

Authored by kamil on Nov 27 2024, 3:32 AM.
Tags
None
Referenced Files
F3668327: D14055.id46162.diff
Sun, Jan 5, 11:31 PM
F3668326: D14055.id46161.diff
Sun, Jan 5, 11:31 PM
F3668325: D14055.id46096.diff
Sun, Jan 5, 11:31 PM
F3668307: D14055.diff
Sun, Jan 5, 11:30 PM
Unknown Object (File)
Fri, Jan 3, 7:51 AM
Unknown Object (File)
Thu, Dec 26, 3:37 AM
Unknown Object (File)
Mon, Dec 23, 8:52 AM
Unknown Object (File)
Sat, Dec 21, 1:59 AM
View All 44 Files
Subscribers
ashoat

Details

Reviewers
angelika
tomek
Commits
rCOMM2e4448a22332: [web][native] add white frame around QR code
Summary

ENG-9875.

Native
before:

IMG_4667.PNG (1×828 px, 81 KB)

after:
IMG_4669.PNG (1×828 px, 83 KB)

Web
before:

Screenshot 2024-11-27 at 12.07.01.png (1×1 px, 135 KB)

after:
Screenshot 2024-11-27 at 12.06.51.png (1×1 px, 131 KB)

Test Plan

On Android physical device:

  1. Scanning QR code when using Add from Linked devices works
  2. Scanning QR code using an app camera (deep linking) works

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Nov 27 2024, 3:32 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptNov 27 2024, 3:32 AM
kamil edited the summary of this revision. (Show Details)Nov 27 2024, 3:34 AM
kamil edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B32881: Diff 46096.Nov 27 2024, 3:49 AM
kamil published this revision for review.Nov 27 2024, 3:52 AM
tomek accepted this revision.Nov 27 2024, 7:28 AM
tomek added inline comments.
web/account/qr-code-login.css
52 ↗(On Diff #46096)

We should avoid using the colors directly and instead use something from our color theme. A comment from web/theme.css explains the reasoning.

This revision is now accepted and ready to land.Nov 27 2024, 7:28 AM
kamil updated this revision to Diff 46161.Dec 2 2024, 6:00 AM

address review

Harbormaster completed remote builds in B32904: Diff 46161.Dec 2 2024, 6:18 AM
Closed by commit rCOMM2e4448a22332: [web][native] add white frame around QR code (authored by kamil). · Explain WhyDec 2 2024, 6:27 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM2e4448a22332: [web][native] add white frame around QR code.

Revision Contents
Changeset List

PathSize
native/
qr-code/
8 lines
web/
account/
8 lines
4 lines

Diff 46162

View Options

native/qr-code/qr-code-screen.react.js

Loading...
View Options

web/account/qr-code-login.css

Loading...
View Options

web/account/qr-code-login.react.js

Loading...