Paths

Table of Contentst

[lib] Extract hook to send logout message to primary device
ClosedPublic
Actions

Authored by bartek on Nov 25 2024, 11:42 AM.

Details

Reviewers

kamil
varun

Commits

rCOMM4e352b153d3c: [lib] Extract hook to send logout message to primary device

Summary

Part of ENG-9710.
We want to send this message not only on secondary device logout, but also on legacy logout when use_new_flow is received

Depends on D14032

Test Plan

Performed secondary device logout. Confirmed that primary device received the message.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Nov 25 2024, 11:42 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 25 2024, 11:42 AM

bartek added a child revision: D14034: [lib] Handle use_new_flow for Identity V1 logout.Nov 25 2024, 11:47 AM

Harbormaster completed remote builds in B32807: Diff 45994.Nov 25 2024, 12:14 PM

bartek published this revision for review.Nov 25 2024, 12:26 PM

kamil accepted this revision.Nov 26 2024, 9:39 AM

This revision is now accepted and ready to land.Nov 26 2024, 9:39 AM

kamil added inline comments.Nov 26 2024, 9:49 AM

lib/actions/user-actions.js
361 ↗	(On Diff #45994)	I think we use this convention in the codebase

ashoat added inline comments.Nov 26 2024, 1:00 PM

lib/actions/user-actions.js
361 ↗	(On Diff #45994)	I think this is okay because "logout" is a noun. On the other hand, if we were using the verb form, it would be two words: "log out"

Closed by commit rCOMM4e352b153d3c: [lib] Extract hook to send logout message to primary device. · Explain WhyNov 29 2024, 1:03 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM4e352b153d3c: [lib] Extract hook to send logout message to primary device.

Revision Contents
Changeset List

Path

Size

lib/

actions/

user-actions.js

40 lines

tunnelbroker/

peer-to-peer-context.js

2 lines

Diff 46151

View Options

lib/actions/user-actions.js