Page MenuHomePhabricator
Differential D14033

[lib] Extract hook to send logout message to primary device
ClosedPublic
Actions

Authored by bartek on Mon, Nov 25, 3:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 30, 12:46 AM
Unknown Object (File)
Fri, Nov 29, 11:44 AM
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
Commits
rCOMM4e352b153d3c: [lib] Extract hook to send logout message to primary device
Summary

Part of ENG-9710.
We want to send this message not only on secondary device logout, but also on legacy logout when use_new_flow is received

Depends on D14032

Test Plan

Performed secondary device logout. Confirmed that primary device received the message.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Mon, Nov 25, 3:42 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Nov 25, 3:42 AM
bartek added a child revision: D14034: [lib] Handle use_new_flow for Identity V1 logout.Mon, Nov 25, 3:47 AM
Harbormaster completed remote builds in B32807: Diff 45994.Mon, Nov 25, 4:14 AM
bartek published this revision for review.Mon, Nov 25, 4:26 AM
kamil accepted this revision.Tue, Nov 26, 1:39 AM
This revision is now accepted and ready to land.Tue, Nov 26, 1:39 AM
kamil added inline comments.Tue, Nov 26, 1:49 AM
lib/actions/user-actions.js
361 ↗(On Diff #45994)

I think we use this convention in the codebase

ashoat added inline comments.Tue, Nov 26, 5:00 AM
lib/actions/user-actions.js
361 ↗(On Diff #45994)

I think this is okay because "logout" is a noun. On the other hand, if we were using the verb form, it would be two words: "log out"

Closed by commit rCOMM4e352b153d3c: [lib] Extract hook to send logout message to primary device (authored by bartek). · Explain WhyFri, Nov 29, 5:03 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM4e352b153d3c: [lib] Extract hook to send logout message to primary device.

Revision Contents
Changeset List

PathSize
lib/
actions/
40 lines
tunnelbroker/
2 lines

Diff 46151

View Options

lib/actions/user-actions.js

Loading...
View Options

lib/tunnelbroker/peer-to-peer-context.js

Loading...