[native] Show version unsupported when opened QR screen
ClosedPublic
Actions

Authored by bartek on Nov 25 2024, 3:54 AM.

Details

Reviewers

kamil
angelika

Commits

rCOMMce616cfd2327: [native] Show version unsupported when opened QR screen

Summary

The QR screen is now for dev-only, but it's theoretically possible to access it via deep link.

For now, the clients aren't able to do it because there are no such QR codes to scan, but in the future after device list launch, they might try doing it on old client versions.
We should display the unsupported version message.

Depends on D14036

Test Plan

Changed isDev condition and opened the QR scanner screen. I was logged out and a message was displayed.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Nov 25 2024, 3:54 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 25 2024, 3:55 AM

Harbormaster completed remote builds in B32811: Diff 45998.Nov 25 2024, 4:48 AM

bartek published this revision for review.Nov 25 2024, 5:09 AM

ashoat added inline comments.Nov 25 2024, 7:11 AM

native/profile/secondary-device-qr-code-scanner.react.js
102 ↗	(On Diff #45998)	Instead of having `isDev` checks littered across the codebase, we should create a single constant that controls whether secondary device auth is enabled. (I think @tomek may have already done this?) The point of having a single "gate" variable is to make sure we don't forget about one of these locations when we're launching the feature.