Page MenuHomePhabricator
Differential D14037

[native] Show version unsupported when opened QR screen
Needs ReviewPublic
Actions

Authored by bartek on Mon, Nov 25, 3:54 AM.

Details

Reviewers
kamil
angelika
Summary

The QR screen is now for dev-only, but it's theoretically possible to access it via deep link.

For now, the clients aren't able to do it because there are no such QR codes to scan, but in the future after device list launch, they might try doing it on old client versions.
We should display the unsupported version message.

Depends on D14036

Test Plan

Changed isDev condition and opened the QR scanner screen. I was logged out and a message was displayed.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Mon, Nov 25, 3:54 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Nov 25, 3:55 AM
Harbormaster completed remote builds in B32811: Diff 45998.Mon, Nov 25, 4:48 AM
bartek published this revision for review.Mon, Nov 25, 5:09 AM
ashoat added inline comments.Mon, Nov 25, 7:11 AM
native/profile/secondary-device-qr-code-scanner.react.js
102

Instead of having isDev checks littered across the codebase, we should create a single constant that controls whether secondary device auth is enabled. (I think @tomek may have already done this?)

The point of having a single "gate" variable is to make sure we don't forget about one of these locations when we're launching the feature.

tomek added inline comments.Mon, Nov 25, 7:23 AM
native/profile/secondary-device-qr-code-scanner.react.js
102

I've just landed a diff where the flag usingRestoreFlow is introduced

Revision Contents
Changeset List

PathSize
native/
profile/
10 lines

Diff 45998

View Options

native/profile/secondary-device-qr-code-scanner.react.js

Loading...