Page MenuHomePhabricator
Differential D14035

[native] Extract showing version unsupported alert to separate hook
ClosedPublic
Actions

Authored by bartek on Nov 25 2024, 3:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 3:37 AM
Unknown Object (File)
Thu, Mar 27, 2:41 PM
Unknown Object (File)
Thu, Mar 27, 12:35 PM
Unknown Object (File)
Thu, Mar 27, 9:11 AM
Unknown Object (File)
Wed, Mar 26, 1:10 PM
Unknown Object (File)
Wed, Mar 26, 12:50 AM
Unknown Object (File)
Thu, Mar 6, 4:33 AM
Unknown Object (File)
Feb 22 2025, 9:00 PM
View All 50 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
Commits
rCOMMf848902ef915: [native] Extract showing version unsupported alert to separate hook
Summary

This alert is going to be also shown when use_new_flow is returned. Made logout-upon-confirm configurable

Depends on D14034

Test Plan

Mocked versionSupported() always return false. The modal was displayed and I was logged out afterwards.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
components/
30 lines
utils/
36 lines

Diff 46153

View Options

native/components/version-supported.react.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import type { SetState } from 'lib/types/hook-types.js'; import type { SetState } from 'lib/types/hook-types.js';
import type { MinimallyEncodedThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import type { LegacyThreadInfo } from 'lib/types/thread-types.js';
import type { NativeChatMessageItem } from './message-data.react.js'; import type { NativeChatMessageItem } from './message-data.react.js';
import type { ChatMessageItemWithHeight } from '../types/chat-types.js'; import type { ChatMessageItemWithHeight } from '../types/chat-types.js';
export type MessagesMeasurer = ( export type MessagesMeasurer = (
?$ReadOnlyArray<NativeChatMessageItem>, ?$ReadOnlyArray<NativeChatMessageItem>,
?LegacyThreadInfo | ?MinimallyEncodedThreadInfo, ?ThreadInfo,
($ReadOnlyArray<ChatMessageItemWithHeight>) => mixed, ($ReadOnlyArray<ChatMessageItemWithHeight>) => mixed,
) => void; ) => void;
export type RegisteredMeasurer = { export type RegisteredMeasurer = {
+measure: MessagesMeasurer, +measure: MessagesMeasurer,
+unregister: () => void, +unregister: () => void,
}; };
Show All 31 Lines
View Options

native/utils/hooks.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import type { SetState } from 'lib/types/hook-types.js'; import type { SetState } from 'lib/types/hook-types.js';
import type { MinimallyEncodedThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import type { LegacyThreadInfo } from 'lib/types/thread-types.js';
import type { NativeChatMessageItem } from './message-data.react.js'; import type { NativeChatMessageItem } from './message-data.react.js';
import type { ChatMessageItemWithHeight } from '../types/chat-types.js'; import type { ChatMessageItemWithHeight } from '../types/chat-types.js';
export type MessagesMeasurer = ( export type MessagesMeasurer = (
?$ReadOnlyArray<NativeChatMessageItem>, ?$ReadOnlyArray<NativeChatMessageItem>,
?LegacyThreadInfo | ?MinimallyEncodedThreadInfo, ?ThreadInfo,
($ReadOnlyArray<ChatMessageItemWithHeight>) => mixed, ($ReadOnlyArray<ChatMessageItemWithHeight>) => mixed,
) => void; ) => void;
export type RegisteredMeasurer = { export type RegisteredMeasurer = {
+measure: MessagesMeasurer, +measure: MessagesMeasurer,
+unregister: () => void, +unregister: () => void,
}; };
Show All 31 Lines