[native] Extract showing version unsupported alert to separate hook
ClosedPublic
Actions

Authored by bartek on Nov 25 2024, 3:49 AM.

Details

Reviewers

kamil
varun

Commits

rCOMMf848902ef915: [native] Extract showing version unsupported alert to separate hook

Summary

This alert is going to be also shown when use_new_flow is returned. Made logout-upon-confirm configurable

Depends on D14034

Test Plan

Mocked versionSupported() always return false. The modal was displayed and I was logged out afterwards.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Nov 25 2024, 3:49 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 25 2024, 3:49 AM

bartek added a child revision: D14036: [native][web] Show version unsupported modal when received use_new_flow on logout.Nov 25 2024, 3:52 AM

Harbormaster completed remote builds in B32809: Diff 45996.Nov 25 2024, 4:33 AM

bartek published this revision for review.Nov 25 2024, 5:09 AM

kamil accepted this revision.Tue, Nov 26, 1:55 AM

This revision is now accepted and ready to land.Tue, Nov 26, 1:55 AM

Closed by commit rCOMMf848902ef915: [native] Extract showing version unsupported alert to separate hook (authored by bartek). · Explain WhyFri, Nov 29, 5:03 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMf848902ef915: [native] Extract showing version unsupported alert to separate hook.

Revision Contents
Changeset List

Path

Size

native/

components/

version-supported.react.js

30 lines

utils/

hooks.js

36 lines

Diff 46153

View Options

native/components/version-supported.react.js