Page MenuHomePhabricator

[lib] Handle use_new_flow for Identity V1 logout
ClosedPublic

Authored by bartek on Nov 25 2024, 3:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 4:45 AM
Unknown Object (File)
Mon, Dec 23, 2:37 AM
Unknown Object (File)
Fri, Dec 20, 9:35 PM
Unknown Object (File)
Mon, Dec 16, 11:10 AM
Unknown Object (File)
Mon, Dec 16, 1:17 AM
Unknown Object (File)
Mon, Dec 16, 1:17 AM
Unknown Object (File)
Mon, Dec 16, 1:17 AM
Unknown Object (File)
Mon, Dec 16, 1:17 AM
Subscribers

Details

Summary

Address ENG-9710.

When received such Identity response, we should:

  • Send logout message to primary device
  • Display version unsupported modal (done in later diffs)

Depends on D14033

Test Plan

Two devices: active primary and secondary

  • In secondary device code: Commented the actual logout call and mocked the use_new_flow response.
  • Logged out.
  • Observed that primary device receiving the message and updating the device list

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Nov 25 2024, 4:27 AM
kamil added inline comments.
lib/actions/user-actions.js
204 ↗(On Diff #45995)
210 ↗(On Diff #45995)

I would at least log the error for debugging purposes

This revision is now accepted and ready to land.Nov 26 2024, 1:51 AM

Add debug log to print error