Page MenuHomePhabricator
Differential D14034

[lib] Handle use_new_flow for Identity V1 logout
ClosedPublic
Actions

Authored by bartek on Mon, Nov 25, 3:47 AM.
Tags
None
Referenced Files
F3521774: D14034.id46127.diff
Mon, Dec 23, 4:45 AM
F3521204: D14034.diff
Mon, Dec 23, 2:37 AM
Unknown Object (File)
Fri, Dec 20, 9:35 PM
Unknown Object (File)
Mon, Dec 16, 11:10 AM
Unknown Object (File)
Mon, Dec 16, 1:17 AM
Unknown Object (File)
Mon, Dec 16, 1:17 AM
Unknown Object (File)
Mon, Dec 16, 1:17 AM
Unknown Object (File)
Mon, Dec 16, 1:17 AM
View All 30 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
Commits
rCOMMdda09d0009bd: [lib] Handle use_new_flow for Identity V1 logout
Summary

Address ENG-9710.

When received such Identity response, we should:

  • Send logout message to primary device
  • Display version unsupported modal (done in later diffs)

Depends on D14033

Test Plan

Two devices: active primary and secondary

  • In secondary device code: Commented the actual logout call and mocked the use_new_flow response.
  • Logged out.
  • Observed that primary device receiving the message and updating the device list

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Mon, Nov 25, 3:47 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Nov 25, 3:47 AM
bartek added a child revision: D14035: [native] Extract showing version unsupported alert to separate hook.Mon, Nov 25, 3:49 AM
Harbormaster completed remote builds in B32808: Diff 45995.Mon, Nov 25, 4:23 AM
bartek published this revision for review.Mon, Nov 25, 4:27 AM
kamil accepted this revision.Tue, Nov 26, 1:51 AM
kamil added inline comments.
lib/actions/user-actions.js
204 ↗(On Diff #45995)
210 ↗(On Diff #45995)

I would at least log the error for debugging purposes

This revision is now accepted and ready to land.Tue, Nov 26, 1:51 AM
bartek updated this revision to Diff 46127.Fri, Nov 29, 3:02 AM

Add debug log to print error

Harbormaster completed remote builds in B32896: Diff 46127.Fri, Nov 29, 3:20 AM
Closed by commit rCOMMdda09d0009bd: [lib] Handle use_new_flow for Identity V1 logout (authored by bartek). · Explain WhyFri, Nov 29, 5:03 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMdda09d0009bd: [lib] Handle use_new_flow for Identity V1 logout.

Revision Contents
Changeset List

PathSize
lib/
actions/
33 lines

Diff 46127

View Options

lib/actions/user-actions.js

Loading...