[identity] Update V1 logout to handle new flow users
ClosedPublic
Actions

Authored by bartek on Dec 3 2024, 3:47 AM.

Details

Reviewers

kamil
varun

Commits

rCOMM312165799170: [identity] Update V1 logout to handle new flow users

Summary

Addresss ENG-9696.

We want V1 logout to still work for new flows, but with two things:

Don't update device list server side
Inform the client that it should use new flows (it already handles the use_new_flow response)

Depends on D14075

Test Plan

Register a user
V1 logout - OK
Log in again and sign the device list (e.g. perform QR login)
V1 logout again - The use_new_flow is returned and a message is displayed on client

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Dec 3 2024, 3:47 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 3 2024, 3:47 AM

Harbormaster completed remote builds in B32914: Diff 46175.Dec 3 2024, 4:36 AM

bartek published this revision for review.Dec 3 2024, 9:53 AM

kamil accepted this revision.Dec 4 2024, 4:49 AM

This revision is now accepted and ready to land.Dec 4 2024, 4:49 AM

bartek added a child revision: D14087: [identity] Reset device list and services data during password reset.Dec 6 2024, 3:50 AM

Rebase

Harbormaster completed remote builds in B32949: Diff 46235.Dec 6 2024, 4:38 AM

Closed by commit rCOMM312165799170: [identity] Update V1 logout to handle new flow users (authored by bartek). · Explain WhyDec 6 2024, 4:46 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM312165799170: [identity] Update V1 logout to handle new flow users.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

grpc_services/

authenticated.rs

23 lines

Diff 46242

View Options

services/identity/src/grpc_services/authenticated.rs

[identity] Update V1 logout to handle new flow usersClosedPublicActions