[identity] Add function to check user login flow
ClosedPublic
Actions

Authored by bartek on Dec 3 2024, 3:41 AM.

Details

Reviewers

kamil
varun

Commits

rCOMM8944ea4f6bfa: [identity] Add function to check user login flow

Summary

Address ENG-9691.

Depends on D14072

Test Plan

Called the function manually for users with signed and unsigned device lists. Also tested in child diffs.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Dec 3 2024, 3:41 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 3 2024, 3:41 AM

bartek added a child revision: D14074: [identity] Return use_new_flow in V1 login RPCs.Dec 3 2024, 3:43 AM

bartek published this revision for review.Dec 3 2024, 3:58 AM

bartek added inline comments.

services/identity/src/database/device_list.rs
1980–1981 ↗	(On Diff #46172)	Missed the fixup commit

Harbormaster completed remote builds in B32911: Diff 46172.Dec 3 2024, 4:07 AM

kamil accepted this revision.Dec 4 2024, 1:32 AM

kamil added inline comments.

services/identity/src/database/device_list.rs
1964 ↗	(On Diff #46172)	nit: IMO better

This revision is now accepted and ready to land.Dec 4 2024, 1:32 AM

Add missing changes, apply suggestion

Harbormaster completed remote builds in B32946: Diff 46232.Dec 6 2024, 4:17 AM

Closed by commit rCOMM8944ea4f6bfa: [identity] Add function to check user login flow (authored by bartek). · Explain WhyDec 6 2024, 4:46 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM8944ea4f6bfa: [identity] Add function to check user login flow.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database/

device_list.rs

64 lines

Diff 46239

View Options

services/identity/src/database/device_list.rs

[identity] Add function to check user login flowClosedPublicActions