[identity] Add function to check if user has backup
ClosedPublic
Actions

Authored by bartek on Dec 3 2024, 3:38 AM.

Details

Reviewers

kamil
varun

Commits

rCOMM88f7830fc53e: [identity] Add function to check if user has backup

Summary

Address ENG-9692.
We call the backup info endpoint to see if user has backup

Generally I think this is not perfect and we could create a dedicated backup service endpoint for this which would query directly by user_id and be callable only by other services

Test Plan

Tested in the next diff

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Dec 3 2024, 3:38 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 3 2024, 3:38 AM

bartek added a child revision: D14073: [identity] Add function to check user login flow.Dec 3 2024, 3:41 AM

bartek published this revision for review.Dec 3 2024, 3:55 AM

Harbormaster completed remote builds in B32910: Diff 46171.Dec 3 2024, 3:59 AM

kamil accepted this revision.Dec 4 2024, 1:28 AM

kamil added inline comments.

services/identity/src/comm_service/backup.rs
64–67 ↗	(On Diff #46171)	Not sure if this is accurate, there are more cases when Backup can return `BAD_REQUEST` - but probably doesn't matter

This revision is now accepted and ready to land.Dec 4 2024, 1:28 AM

Generally I think this is not perfect and we could create a dedicated backup service endpoint for this which would query directly by user_id and be callable only by other services

Created ENG-9983

services/identity/src/comm_service/backup.rs
64–67 ↗	(On Diff #46171)	Doesn't matter. Looking at that endpoint code, in 99% of the cases `MissingItem` will be the cause, but it should never happen anyway because Identity gives correct names. Also, this problem disappears when ENG-9983 is implemented