Page MenuHomePhabricator
Differential D14072

[identity] Add function to check if user has backup
AcceptedPublic
Actions

Authored by bartek on Tue, Dec 3, 3:38 AM.

Details

Reviewers
kamil
varun
Summary

Address ENG-9692.
We call the backup info endpoint to see if user has backup

Generally I think this is not perfect and we could create a dedicated backup service endpoint for this which would query directly by user_id and be callable only by other services

Test Plan

Tested in the next diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Tue, Dec 3, 3:38 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Dec 3, 3:38 AM
bartek added a child revision: D14073: [identity] Add function to check user login flow.Tue, Dec 3, 3:41 AM
bartek published this revision for review.Tue, Dec 3, 3:55 AM
Harbormaster completed remote builds in B32910: Diff 46171.Tue, Dec 3, 3:59 AM
kamil accepted this revision.Wed, Dec 4, 1:28 AM
kamil added inline comments.
services/identity/src/comm_service/backup.rs
64–67

Not sure if this is accurate, there are more cases when Backup can return BAD_REQUEST - but probably doesn't matter

This revision is now accepted and ready to land.Wed, Dec 4, 1:28 AM

Revision Contents
Changeset List

PathSize
services/
identity/
src/
comm_service/
38 lines

Diff 46171

View Options

services/identity/src/comm_service/backup.rs

Loading...