Page MenuHomePhabricator
Differential D14075

[identity] Return use_v1_flow in new-flow-only RPCs
ClosedPublic
Actions

Authored by bartek on Dec 3 2024, 3:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 23, 2:53 PM
Unknown Object (File)
Thu, Mar 13, 4:24 PM
Unknown Object (File)
Thu, Mar 13, 4:24 PM
Unknown Object (File)
Thu, Mar 13, 4:24 PM
Unknown Object (File)
Thu, Mar 13, 4:24 PM
Unknown Object (File)
Thu, Mar 13, 4:24 PM
Unknown Object (File)
Sat, Mar 1, 8:58 AM
Unknown Object (File)
Feb 3 2025, 9:54 AM
View All 55 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
Commits
rCOMMd91394b8f101: [identity] Return use_v1_flow in new-flow-only RPCs
Summary

Address ENG-9695

Depends on D14074

Test Plan

Registered a user (without backup), then tried to call e.g. primary device logout RPC. The use_v1_flow was returned in response.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
identity/
src/
22 lines
1 line
grpc_services/
22 lines

Diff 46241

View Options

services/identity/src/client_service.rs

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { PersistState } from 'redux-persist/es/types.js'; import type { PersistState } from 'redux-persist/es/types.js';
import { import {
logOutActionTypes, logOutActionTypes,
deleteKeyserverAccountActionTypes, deleteKeyserverAccountActionTypes,
deleteAccountActionTypes,
} from 'lib/actions/user-actions.js'; } from 'lib/actions/user-actions.js';
import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { import {
type ThreadStoreOperation, type ThreadStoreOperation,
threadStoreOpsHandlers, threadStoreOpsHandlers,
} from 'lib/ops/thread-store-ops.js'; } from 'lib/ops/thread-store-ops.js';
import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js'; import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js';
import baseReducer from 'lib/reducers/master-reducer.js'; import baseReducer from 'lib/reducers/master-reducer.js';
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Lines (action.type === logOutActionTypes.success &&
ashoatKeyserverID, ashoatKeyserverID,
)) || )) ||
(action.type === deleteKeyserverAccountActionTypes.success && (action.type === deleteKeyserverAccountActionTypes.success &&
invalidSessionDowngrade( invalidSessionDowngrade(
oldState, oldState,
action.payload.currentUserInfo, action.payload.currentUserInfo,
action.payload.preRequestUserState, action.payload.preRequestUserState,
ashoatKeyserverID, ashoatKeyserverID,
)) ||
(action.type === deleteAccountActionTypes.success &&
invalidSessionDowngrade(
state,
action.payload.currentUserInfo,
action.payload.preRequestUserState,
ashoatKeyserverID,
)) ))
) { ) {
return { return {
...oldState, ...oldState,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action), loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
}; };
} }
▲ Show 20 Lines • Show All 146 Lines • Show Last 20 Lines
View Options

services/identity/src/constants.rs

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { PersistState } from 'redux-persist/es/types.js'; import type { PersistState } from 'redux-persist/es/types.js';
import { import {
logOutActionTypes, logOutActionTypes,
deleteKeyserverAccountActionTypes, deleteKeyserverAccountActionTypes,
deleteAccountActionTypes,
} from 'lib/actions/user-actions.js'; } from 'lib/actions/user-actions.js';
import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { import {
type ThreadStoreOperation, type ThreadStoreOperation,
threadStoreOpsHandlers, threadStoreOpsHandlers,
} from 'lib/ops/thread-store-ops.js'; } from 'lib/ops/thread-store-ops.js';
import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js'; import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js';
import baseReducer from 'lib/reducers/master-reducer.js'; import baseReducer from 'lib/reducers/master-reducer.js';
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Lines (action.type === logOutActionTypes.success &&
ashoatKeyserverID, ashoatKeyserverID,
)) || )) ||
(action.type === deleteKeyserverAccountActionTypes.success && (action.type === deleteKeyserverAccountActionTypes.success &&
invalidSessionDowngrade( invalidSessionDowngrade(
oldState, oldState,
action.payload.currentUserInfo, action.payload.currentUserInfo,
action.payload.preRequestUserState, action.payload.preRequestUserState,
ashoatKeyserverID, ashoatKeyserverID,
)) ||
(action.type === deleteAccountActionTypes.success &&
invalidSessionDowngrade(
state,
action.payload.currentUserInfo,
action.payload.preRequestUserState,
ashoatKeyserverID,
)) ))
) { ) {
return { return {
...oldState, ...oldState,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action), loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
}; };
} }
▲ Show 20 Lines • Show All 146 Lines • Show Last 20 Lines
View Options

services/identity/src/grpc_services/authenticated.rs

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { PersistState } from 'redux-persist/es/types.js'; import type { PersistState } from 'redux-persist/es/types.js';
import { import {
logOutActionTypes, logOutActionTypes,
deleteKeyserverAccountActionTypes, deleteKeyserverAccountActionTypes,
deleteAccountActionTypes,
} from 'lib/actions/user-actions.js'; } from 'lib/actions/user-actions.js';
import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from 'lib/keyserver-conn/keyserver-conn-types.js';
import { import {
type ThreadStoreOperation, type ThreadStoreOperation,
threadStoreOpsHandlers, threadStoreOpsHandlers,
} from 'lib/ops/thread-store-ops.js'; } from 'lib/ops/thread-store-ops.js';
import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js'; import { reduceLoadingStatuses } from 'lib/reducers/loading-reducer.js';
import baseReducer from 'lib/reducers/master-reducer.js'; import baseReducer from 'lib/reducers/master-reducer.js';
▲ Show 20 Lines • Show All 194 Lines • ▼ Show 20 Lines (action.type === logOutActionTypes.success &&
ashoatKeyserverID, ashoatKeyserverID,
)) || )) ||
(action.type === deleteKeyserverAccountActionTypes.success && (action.type === deleteKeyserverAccountActionTypes.success &&
invalidSessionDowngrade( invalidSessionDowngrade(
oldState, oldState,
action.payload.currentUserInfo, action.payload.currentUserInfo,
action.payload.preRequestUserState, action.payload.preRequestUserState,
ashoatKeyserverID, ashoatKeyserverID,
)) ||
(action.type === deleteAccountActionTypes.success &&
invalidSessionDowngrade(
state,
action.payload.currentUserInfo,
action.payload.preRequestUserState,
ashoatKeyserverID,
)) ))
) { ) {
return { return {
...oldState, ...oldState,
loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action), loadingStatuses: reduceLoadingStatuses(state.loadingStatuses, action),
}; };
} }
▲ Show 20 Lines • Show All 146 Lines • Show Last 20 Lines