Page MenuHomePhabricator
Differential D14075

[identity] Return use_v1_flow in new-flow-only RPCs
ClosedPublic
Actions

Authored by bartek on Dec 3 2024, 3:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 12, 7:54 PM
Unknown Object (File)
Sun, Mar 23, 2:53 PM
Unknown Object (File)
Mar 13 2025, 4:24 PM
Unknown Object (File)
Mar 13 2025, 4:24 PM
Unknown Object (File)
Mar 13 2025, 4:24 PM
Unknown Object (File)
Mar 13 2025, 4:24 PM
Unknown Object (File)
Mar 13 2025, 4:24 PM
Unknown Object (File)
Mar 1 2025, 8:58 AM
View All 56 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
Commits
rCOMMd91394b8f101: [identity] Return use_v1_flow in new-flow-only RPCs
Summary

Address ENG-9695

Depends on D14074

Test Plan

Registered a user (without backup), then tried to call e.g. primary device logout RPC. The use_v1_flow was returned in response.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
identity/
src/
22 lines
1 line
grpc_services/
22 lines

Diff 46241

View Options

services/identity/src/client_service.rs

Show All 38 Lines tracing::error!(
errorType = error_types::HTTP_LOG, errorType = error_types::HTTP_LOG,
"Backup service failed to delete user data: {} - {}", "Backup service failed to delete user data: {} - {}",
response_status, response_status,
response_body, response_body,
) )
} }
Ok(()) Ok(())
} }
pub async fn user_has_backup(
user_identifier: &str,
) -> Result<bool, crate::error::Error> {
let path = format!("/backups/latest/{user_identifier}/backup_info");
let url = CONFIG
.backup_service_url
.join(&path)
.expect("failed to construct backup service URL");
let client = reqwest::Client::builder().build()?;
let response = client.get(url).send().await?;
use http::StatusCode;
match response.status() {
StatusCode::OK => Ok(true), // Backup service returned backup info
StatusCode::NOT_FOUND => Ok(false), // Backup service returned BackupError::NoBackup
StatusCode::BAD_REQUEST => {
// Identity has no user with given UserIdentifier
Err(crate::error::Error::MissingItem)
}
response_status => {
let response_body = response
.text()
.await
.unwrap_or("[failed to get response text]".to_string());
tracing::error!(
errorType = error_types::HTTP_LOG,
"Backup service failed to get latest backup info: {} - {}",
response_status,
response_body,
);
Err(
tonic::Status::aborted(tonic_status_messages::UNEXPECTED_ERROR).into(),
)
}
}
}
View Options

services/identity/src/constants.rs

Show All 38 Lines tracing::error!(
errorType = error_types::HTTP_LOG, errorType = error_types::HTTP_LOG,
"Backup service failed to delete user data: {} - {}", "Backup service failed to delete user data: {} - {}",
response_status, response_status,
response_body, response_body,
) )
} }
Ok(()) Ok(())
} }
pub async fn user_has_backup(
user_identifier: &str,
) -> Result<bool, crate::error::Error> {
let path = format!("/backups/latest/{user_identifier}/backup_info");
let url = CONFIG
.backup_service_url
.join(&path)
.expect("failed to construct backup service URL");
let client = reqwest::Client::builder().build()?;
let response = client.get(url).send().await?;
use http::StatusCode;
match response.status() {
StatusCode::OK => Ok(true), // Backup service returned backup info
StatusCode::NOT_FOUND => Ok(false), // Backup service returned BackupError::NoBackup
StatusCode::BAD_REQUEST => {
// Identity has no user with given UserIdentifier
Err(crate::error::Error::MissingItem)
}
response_status => {
let response_body = response
.text()
.await
.unwrap_or("[failed to get response text]".to_string());
tracing::error!(
errorType = error_types::HTTP_LOG,
"Backup service failed to get latest backup info: {} - {}",
response_status,
response_body,
);
Err(
tonic::Status::aborted(tonic_status_messages::UNEXPECTED_ERROR).into(),
)
}
}
}
View Options

services/identity/src/grpc_services/authenticated.rs

Show All 38 Lines tracing::error!(
errorType = error_types::HTTP_LOG, errorType = error_types::HTTP_LOG,
"Backup service failed to delete user data: {} - {}", "Backup service failed to delete user data: {} - {}",
response_status, response_status,
response_body, response_body,
) )
} }
Ok(()) Ok(())
} }
pub async fn user_has_backup(
user_identifier: &str,
) -> Result<bool, crate::error::Error> {
let path = format!("/backups/latest/{user_identifier}/backup_info");
let url = CONFIG
.backup_service_url
.join(&path)
.expect("failed to construct backup service URL");
let client = reqwest::Client::builder().build()?;
let response = client.get(url).send().await?;
use http::StatusCode;
match response.status() {
StatusCode::OK => Ok(true), // Backup service returned backup info
StatusCode::NOT_FOUND => Ok(false), // Backup service returned BackupError::NoBackup
StatusCode::BAD_REQUEST => {
// Identity has no user with given UserIdentifier
Err(crate::error::Error::MissingItem)
}
response_status => {
let response_body = response
.text()
.await
.unwrap_or("[failed to get response text]".to_string());
tracing::error!(
errorType = error_types::HTTP_LOG,
"Backup service failed to get latest backup info: {} - {}",
response_status,
response_body,
);
Err(
tonic::Status::aborted(tonic_status_messages::UNEXPECTED_ERROR).into(),
)
}
}
}