Page MenuHomePhabricator
Differential D14073

[identity] Add function to check user login flow
ClosedPublic
Actions

Authored by bartek on Dec 3 2024, 3:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 31, 5:21 AM
Unknown Object (File)
Fri, Mar 14, 6:07 AM
Unknown Object (File)
Fri, Mar 14, 4:44 AM
Unknown Object (File)
Fri, Mar 14, 3:55 AM
Unknown Object (File)
Thu, Mar 13, 4:24 PM
Unknown Object (File)
Thu, Mar 13, 4:24 PM
Unknown Object (File)
Thu, Mar 13, 4:24 PM
Unknown Object (File)
Thu, Mar 13, 4:24 PM
View All 50 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
Commits
rCOMM8944ea4f6bfa: [identity] Add function to check user login flow
Summary

Address ENG-9691.

Depends on D14072

Test Plan

Called the function manually for users with signed and unsigned device lists. Also tested in child diffs.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Dec 3 2024, 3:41 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 3 2024, 3:41 AM
bartek added a child revision: D14074: [identity] Return use_new_flow in V1 login RPCs.Dec 3 2024, 3:43 AM
bartek published this revision for review.Dec 3 2024, 3:58 AM
bartek added inline comments.
services/identity/src/database/device_list.rs
1980–1981

Missed the fixup commit

Harbormaster completed remote builds in B32911: Diff 46172.Dec 3 2024, 4:07 AM
kamil accepted this revision.Dec 4 2024, 1:32 AM
kamil added inline comments.
services/identity/src/database/device_list.rs
1964

nit: IMO better

This revision is now accepted and ready to land.Dec 4 2024, 1:32 AM
bartek updated this revision to Diff 46232.Dec 6 2024, 3:59 AM

Add missing changes, apply suggestion

Harbormaster completed remote builds in B32946: Diff 46232.Dec 6 2024, 4:17 AM
Closed by commit rCOMM8944ea4f6bfa: [identity] Add function to check user login flow (authored by bartek). · Explain WhyDec 6 2024, 4:46 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM8944ea4f6bfa: [identity] Add function to check user login flow.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
database/
55 lines

Diff 46172

View Options

services/identity/src/database/device_list.rs

// @flow // @flow
import _memoize from 'lodash/memoize.js'; import _memoize from 'lodash/memoize.js';
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import { import {
getAvatarForUser, getAvatarForUser,
getRandomDefaultEmojiAvatar, getRandomDefaultEmojiAvatar,
} from '../shared/avatar-utils.js'; } from '../shared/avatar-utils.js';
import { getSingleOtherUser } from '../shared/thread-utils.js'; import { getSingleOtherUser } from '../shared/thread-utils.js';
import type { ClientEmojiAvatar } from '../types/avatar-types'; import type { ClientEmojiAvatar } from '../types/avatar-types';
import type { import type {
MinimallyEncodedRelativeMemberInfo, RelativeMemberInfo,
RawThreadInfo, RawThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { userRelationshipStatus } from '../types/relationship-types.js'; import { userRelationshipStatus } from '../types/relationship-types.js';
import { threadTypes } from '../types/thread-types-enum.js'; import { threadTypes } from '../types/thread-types-enum.js';
import type { import type {
LegacyRawThreadInfo, LegacyRawThreadInfo,
RawThreadInfos, RawThreadInfos,
▲ Show 20 Lines • Show All 81 Lines • ▼ Show 20 Lines if (isViewer) {
relativeMemberInfos.unshift(relativeMemberInfo); relativeMemberInfos.unshift(relativeMemberInfo);
} else { } else {
relativeMemberInfos.push(relativeMemberInfo); relativeMemberInfos.push(relativeMemberInfo);
} }
} }
return relativeMemberInfos; return relativeMemberInfos;
} }
const emptyArray: $ReadOnlyArray<MinimallyEncodedRelativeMemberInfo> = []; const emptyArray: $ReadOnlyArray<RelativeMemberInfo> = [];
// Includes current user at the start // Includes current user at the start
const baseRelativeMemberInfoSelectorForMembersOfThread: ( const baseRelativeMemberInfoSelectorForMembersOfThread: (
threadID: ?string, threadID: ?string,
) => ( ) => (state: BaseAppState<>) => $ReadOnlyArray<RelativeMemberInfo> = (
state: BaseAppState<>,
) => $ReadOnlyArray<MinimallyEncodedRelativeMemberInfo> = (
threadID: ?string, threadID: ?string,
) => { ) => {
if (!threadID) { if (!threadID) {
return () => emptyArray; return () => emptyArray;
} }
return createSelector( return createSelector(
(state: BaseAppState<>) => state.threadStore.threadInfos[threadID], (state: BaseAppState<>) => state.threadStore.threadInfos[threadID],
(state: BaseAppState<>) => (state: BaseAppState<>) =>
state.currentUserInfo && state.currentUserInfo.id, state.currentUserInfo && state.currentUserInfo.id,
(state: BaseAppState<>) => state.userStore.userInfos, (state: BaseAppState<>) => state.userStore.userInfos,
getRelativeMemberInfos, getRelativeMemberInfos,
); );
}; };
const relativeMemberInfoSelectorForMembersOfThread: ( const relativeMemberInfoSelectorForMembersOfThread: (
threadID: ?string, threadID: ?string,
) => ( ) => (state: BaseAppState<>) => $ReadOnlyArray<RelativeMemberInfo> = _memoize(
state: BaseAppState<>,
) => $ReadOnlyArray<MinimallyEncodedRelativeMemberInfo> = _memoize(
baseRelativeMemberInfoSelectorForMembersOfThread, baseRelativeMemberInfoSelectorForMembersOfThread,
); );
const userInfoSelectorForPotentialMembers: (state: BaseAppState<>) => { const userInfoSelectorForPotentialMembers: (state: BaseAppState<>) => {
[id: string]: AccountUserInfo, [id: string]: AccountUserInfo,
} = createSelector( } = createSelector(
(state: BaseAppState<>) => state.userStore.userInfos, (state: BaseAppState<>) => state.userStore.userInfos,
(state: BaseAppState<>) => state.currentUserInfo && state.currentUserInfo.id, (state: BaseAppState<>) => state.currentUserInfo && state.currentUserInfo.id,
▲ Show 20 Lines • Show All 78 Lines • Show Last 20 Lines