Page MenuHomePhabricator
Differential D13573

[lib] remove checking for message IDs collision
ClosedPublic
Actions

Authored by kamil on Oct 2 2024, 6:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 12:13 PM
Unknown Object (File)
Thu, Nov 7, 8:24 AM
Unknown Object (File)
Thu, Nov 7, 6:53 AM
Unknown Object (File)
Thu, Nov 7, 6:43 AM
Unknown Object (File)
Thu, Nov 7, 4:54 AM
Unknown Object (File)
Sun, Nov 3, 9:08 AM
Unknown Object (File)
Sat, Nov 2, 6:32 PM
Unknown Object (File)
Sat, Nov 2, 6:32 PM
View All 41 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMfb674c2f263b: [lib] remove checking for message IDs collision
Summary

Short term fix to: ENG-9464.

There is a comment in ENG-9468 to came up with correct solution.

Test Plan

On the master:

  1. Open physical device
  2. In DM thread send a test message
  3. Notif delivered
  4. Message not visible in UI
  5. Seeing log: Discarded a send_text_message operation because message with the same ID 27caa155-d435-4ef8-9d8e-5b0862861e02 already exists in the store
  6. Kill/restart the app - message is visible regardless of network/TB connection.

Apply this diff:

  1. Open physical device
  2. In DM thread send a test message
  3. Notif delivered
  4. Message immediately visible in UI
  5. Not seeing any log about the discarded operation.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Oct 2 2024, 6:25 AM
kamil held this revision as a draft.
kamil published this revision for review.Oct 2 2024, 6:27 AM
kamil edited the test plan for this revision. (Show Details)
ashoat accepted this revision.Oct 2 2024, 6:32 AM
This revision is now accepted and ready to land.Oct 2 2024, 6:32 AM
Harbormaster completed remote builds in B32015: Diff 44824.Oct 2 2024, 6:43 AM
Closed by commit rCOMMfb674c2f263b: [lib] remove checking for message IDs collision (authored by kamil). · Explain WhyOct 2 2024, 6:52 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMfb674c2f263b: [lib] remove checking for message IDs collision.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
36 lines
39 lines
35 lines
14 lines

Diff 44825

View Options

lib/shared/dm-ops/change-thread-settings-spec.js

Loading...
View Options

lib/shared/dm-ops/create-sidebar-spec.js

Loading...
View Options

lib/shared/dm-ops/dm-op-utils.js

Loading...
View Options

lib/shared/dm-ops/process-dm-ops.js

Loading...