Page MenuHomePhabricator

[lib] remove checking for message IDs collision
ClosedPublic

Authored by kamil on Wed, Oct 2, 6:25 AM.
Tags
None
Referenced Files
F2866567: D13573.id44825.diff
Wed, Oct 2, 11:35 AM
F2866566: D13573.id44824.diff
Wed, Oct 2, 11:35 AM
F2866530: D13573.id.diff
Wed, Oct 2, 11:35 AM
F2866523: D13573.diff
Wed, Oct 2, 11:33 AM
Subscribers
None

Details

Summary

Short term fix to: ENG-9464.

There is a comment in ENG-9468 to came up with correct solution.

Test Plan

On the master:

  1. Open physical device
  2. In DM thread send a test message
  3. Notif delivered
  4. Message not visible in UI
  5. Seeing log: Discarded a send_text_message operation because message with the same ID 27caa155-d435-4ef8-9d8e-5b0862861e02 already exists in the store
  6. Kill/restart the app - message is visible regardless of network/TB connection.

Apply this diff:

  1. Open physical device
  2. In DM thread send a test message
  3. Notif delivered
  4. Message immediately visible in UI
  5. Not seeing any log about the discarded operation.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Wed, Oct 2, 6:27 AM
kamil edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Wed, Oct 2, 6:32 AM