HomePhabricator
Diffusion Comm fb674c2f263b

[lib] remove checking for message IDs collision

Description

[lib] remove checking for message IDs collision

Summary:
Short term fix to: ENG-9464.

There is a comment in ENG-9468 to came up with correct solution.

Test Plan:
On the master:

  1. Open physical device
  2. In DM thread send a test message
  3. Notif delivered
  4. Message not visible in UI
  5. Seeing log: Discarded a send_text_message operation because message with the same ID 27caa155-d435-4ef8-9d8e-5b0862861e02 already exists in the store
  6. Kill/restart the app - message is visible regardless of network/TB connection.

Apply this diff:

  1. Open physical device
  2. In DM thread send a test message
  3. Notif delivered
  4. Message immediately visible in UI
  5. Not seeing any log about the discarded operation.

Reviewers: ashoat, tomek

Reviewed By: ashoat

Differential Revision: https://phab.comm.dev/D13573

Details

Provenance
kamilAuthored on Oct 2 2024, 6:16 AM
Reviewer
ashoat
Differential Revision
D13573: [lib] remove checking for message IDs collision
Parents
rCOMMa68cc470651e: [lib] Don't prefix keyserver-owned holders with device ID
Branches
Unknown
Tags
Unknown