Paths

Table of Contentst

-
services/tunnelbroker/src/
-
tunnelbroker/
-
src/
-
amqp.rs

[tunnelbroker] Ignore connection error messages handled elsewhere
ClosedPublic
Actions

Authored by bartek on Oct 3 2024, 1:37 PM.

Details

Reviewers

kamil
varun
will

Commits

rCOMM424644f989f5: [tunnelbroker] Ignore connection error messages handled elsewhere

Summary

This is to avoid alerting spam for errors from inside lapin library that we handle e.g. by reconnecting to RabbitMQ.

Depends on D13607

Test Plan

When Tunnelbroker is open, stop RabbitMQ server.

Before: Error was displayed with errorType = AMQP_ERROR that connection is lost.
After: The error is not displayed from this handler. Error message appears only when all exponential backoff attempts fail.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Oct 3 2024, 1:37 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 3 2024, 1:38 PM

bartek mentioned this in D13595: [tunnelbroker] Rewrite AMQP handling.Oct 3 2024, 1:39 PM

bartek added a child revision: D13609: [tunnelbroker] Remove legacy AMQP connect function.Oct 3 2024, 1:42 PM

Harbormaster failed remote builds in B32059: Diff 44888!Oct 3 2024, 8:01 PM

bartek mentioned this in D13601: [tunnelbroker] Create thread-safe wrapper over AMQP connection.Oct 4 2024, 3:44 AM

Remove connection pool

bartek published this revision for review.Oct 4 2024, 8:44 AM

Harbormaster completed remote builds in B32073: Diff 44905.Oct 4 2024, 8:58 AM

bartek edited the summary of this revision. (Show Details)Oct 7 2024, 2:27 AM

bartek edited the test plan for this revision. (Show Details)

kamil accepted this revision.Oct 7 2024, 2:50 AM

This revision is now accepted and ready to land.Oct 7 2024, 2:50 AM

Closed by commit rCOMM424644f989f5: [tunnelbroker] Ignore connection error messages handled elsewhere (authored by bartek). · Explain WhyOct 7 2024, 7:28 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM424644f989f5: [tunnelbroker] Ignore connection error messages handled elsewhere.

bartek mentioned this in D13703: [tunnelbroker] Ignore CONNECTIONFORCED error message.Oct 13 2024, 11:20 PM

bartek mentioned this in rCOMMed9275b0a10a: [tunnelbroker] Ignore CONNECTIONFORCED error message.Oct 14 2024, 6:45 AM

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

amqp.rs

25 lines

Diff 44937

View Options

services/tunnelbroker/src/amqp.rs

	Show All 25 Lines
	import type { ClientDBMessageInfo } from 'lib/types/message-types.js';			import type { ClientDBMessageInfo } from 'lib/types/message-types.js';
	import { cookieTypes } from 'lib/types/session-types.js';			import { cookieTypes } from 'lib/types/session-types.js';
	import { defaultConnectionInfo } from 'lib/types/socket-types.js';			import { defaultConnectionInfo } from 'lib/types/socket-types.js';
	import { defaultGlobalThemeInfo } from 'lib/types/theme-types.js';			import { defaultGlobalThemeInfo } from 'lib/types/theme-types.js';
	import type { ClientDBThreadInfo } from 'lib/types/thread-types.js';			import type { ClientDBThreadInfo } from 'lib/types/thread-types.js';
	import { getConfig } from 'lib/utils/config.js';			import { getConfig } from 'lib/utils/config.js';
	import { parseCookies } from 'lib/utils/cookie-utils.js';			import { parseCookies } from 'lib/utils/cookie-utils.js';
	import { isDev } from 'lib/utils/dev-utils.js';			import { isDev } from 'lib/utils/dev-utils.js';
	import { wipeKeyserverStore } from 'lib/utils/keyserver-store-utils.js';
	import {			import {
	generateIDSchemaMigrationOpsForDrafts,			generateIDSchemaMigrationOpsForDrafts,
	convertDraftStoreToNewIDSchema,			convertDraftStoreToNewIDSchema,
	} from 'lib/utils/migration-utils.js';			} from 'lib/utils/migration-utils.js';
	import { entries } from 'lib/utils/objects.js';			import { entries } from 'lib/utils/objects.js';
	import { resetUserSpecificState } from 'lib/utils/reducers-utils.js';
	import {			import {
	convertClientDBThreadInfoToRawThreadInfo,			convertClientDBThreadInfoToRawThreadInfo,
	convertRawThreadInfoToClientDBThreadInfo,			convertRawThreadInfoToClientDBThreadInfo,
	} from 'lib/utils/thread-ops-utils.js';			} from 'lib/utils/thread-ops-utils.js';

	import commReduxStorageEngine from './comm-redux-storage-engine.js';			import commReduxStorageEngine from './comm-redux-storage-engine.js';
	import { defaultWebState } from './default-state.js';			import {
				handleReduxMigrationFailure,
				persistWhitelist,
				} from './handle-redux-migration-failure.js';
	import { rootKey, rootKeyPrefix } from './persist-constants.js';			import { rootKey, rootKeyPrefix } from './persist-constants.js';
	import type { AppState } from './redux-setup.js';			import type { AppState } from './redux-setup.js';
	import { nonUserSpecificFieldsWeb } from './redux-setup.js';
	import { authoritativeKeyserverID } from '../authoritative-keyserver.js';			import { authoritativeKeyserverID } from '../authoritative-keyserver.js';
	import { getCommSharedWorker } from '../shared-worker/shared-worker-provider.js';			import { getCommSharedWorker } from '../shared-worker/shared-worker-provider.js';
	import { getOlmWasmPath } from '../shared-worker/utils/constants.js';			import { getOlmWasmPath } from '../shared-worker/utils/constants.js';
	import { isSQLiteSupported } from '../shared-worker/utils/db-utils.js';			import { isSQLiteSupported } from '../shared-worker/utils/db-utils.js';
	import { workerRequestMessageTypes } from '../types/worker-types.js';			import { workerRequestMessageTypes } from '../types/worker-types.js';

	declare var keyserverURL: string;			declare var keyserverURL: string;

	const persistWhitelist = [
	'enabledApps',
	'alertStore',
	'commServicesAccessToken',
	'keyserverStore',
	'globalThemeInfo',
	'customServer',
	'messageStore',
	];

	function handleReduxMigrationFailure(oldState: AppState): AppState {
	const persistedNonUserSpecificFields = nonUserSpecificFieldsWeb.filter(
	field => persistWhitelist.includes(field) \|\| field === '_persist',
	);
	const stateAfterReset = resetUserSpecificState(
	oldState,
	defaultWebState,
	persistedNonUserSpecificFields,
	);
	return {
	...stateAfterReset,
	keyserverStore: wipeKeyserverStore(stateAfterReset.keyserverStore),
	};
	}

	const migrations = {			const migrations = {
	[1]: async (state: any) => {			[1]: async (state: any) => {
	const {			const {
	primaryIdentityPublicKey,			primaryIdentityPublicKey,
	...stateWithoutPrimaryIdentityPublicKey			...stateWithoutPrimaryIdentityPublicKey
	} = state;			} = state;
	return {			return {
	...stateWithoutPrimaryIdentityPublicKey,			...stateWithoutPrimaryIdentityPublicKey,
	▲ Show 20 Lines • Show All 453 Lines • Show Last 20 Lines

[tunnelbroker] Ignore connection error messages handled elsewhereClosedPublicActions