Details

Reviewers

kamil
varun
will

Commits

rCOMMb43e6708eee6: [tunnelbroker] Refactor Websocket session init

Summary

Separated AMQP and DeviceInfo/auth logic from initiate_session(). Moved channel creation deeper into WebsocketSession::init_amqp()

Depends on D13604

Test Plan

cargo build

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Oct 3 2024, 8:36 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 3 2024, 8:36 PM

bartek added a child revision: D13606: [tunnelbroker] Recover AMQP consumers.Oct 3 2024, 8:37 PM

Harbormaster completed remote builds in B32056: Diff 44885.Oct 3 2024, 9:06 PM

Rebase

Harbormaster completed remote builds in B32063: Diff 44894.Oct 4 2024, 10:45 AM

bartek edited the summary of this revision. (Show Details)Oct 4 2024, 10:53 AM

bartek edited the test plan for this revision. (Show Details)

bartek edited the summary of this revision. (Show Details)

Remove connection pool

bartek published this revision for review.Oct 4 2024, 3:38 PM

Harbormaster completed remote builds in B32070: Diff 44902.Oct 4 2024, 3:42 PM

Looks a lot cleaner now

services/tunnelbroker/src/websockets/session.rs
204 ↗	(On Diff #44902)	I would prefer something like `get_device_info_from_frame`

This revision is now accepted and ready to land.Oct 7 2024, 9:04 AM

Rename

Harbormaster completed remote builds in B32087: Diff 44923.Oct 7 2024, 2:25 PM

Closed by commit rCOMMb43e6708eee6: [tunnelbroker] Refactor Websocket session init. · Explain WhyOct 7 2024, 2:28 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMb43e6708eee6: [tunnelbroker] Refactor Websocket session init.

[tunnelbroker] Refactor Websocket session init
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 44934

services/tunnelbroker/src/websockets/mod.rs

services/tunnelbroker/src/websockets/session.rs

[tunnelbroker] Refactor Websocket session initClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44934

services/tunnelbroker/src/websockets/mod.rs

services/tunnelbroker/src/websockets/session.rs

[tunnelbroker] Refactor Websocket session init
ClosedPublic
Actions

Revision Contents
Changeset List