Page MenuHomePhabricator
Differential D13606

[tunnelbroker] Recover AMQP consumers
Needs ReviewPublic
Actions

Authored by bartek on Thu, Oct 3, 1:37 PM.
Tags
None
Referenced Files
F2894463: D13606.id44903.diff
Fri, Oct 4, 3:54 PM
F2890832: D13606.diff
Fri, Oct 4, 8:39 AM
F2890768: D13606.vs44886.id44903.diff
Fri, Oct 4, 8:33 AM
F2890766: D13606/new/.diff
Fri, Oct 4, 8:32 AM
F2888829: D13606.id44886.diff
Fri, Oct 4, 5:47 AM
F2888795: D13606.id.diff
Fri, Oct 4, 5:47 AM
F2888760: D13606.diff
Fri, Oct 4, 5:45 AM
F2885203: D13606.diff
Thu, Oct 3, 6:23 PM
View All 10 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
will
Summary

When a consumer returns a confirmation error, we can try restoring it without closing the WebSocket session

Depends on D13605

Test Plan

Test plan from D13595 (commtest) sometimes failed on this confirmation. Now it's no longer happening

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Thu, Oct 3, 1:37 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Oct 3, 1:37 PM
bartek added a child revision: D13607: [tunnelbroker] Trigger AMQP reconnect when closing session.Thu, Oct 3, 1:37 PM
Harbormaster completed remote builds in B32057: Diff 44886.Thu, Oct 3, 2:11 PM
bartek mentioned this in D13611: [tunnelbroker] Recover AMQP before publishing messages.Fri, Oct 4, 3:38 AM
bartek published this revision for review.Fri, Oct 4, 3:58 AM
bartek edited the summary of this revision. (Show Details)
bartek edited the test plan for this revision. (Show Details)
bartek added inline comments.
services/tunnelbroker/src/websockets/mod.rs
254 ↗(On Diff #44886)

Should it be warn or error?

bartek updated this revision to Diff 44903.Fri, Oct 4, 8:18 AM

Remove connection pool

Harbormaster completed remote builds in B32071: Diff 44903.Fri, Oct 4, 8:46 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
8 lines
websockets/
32 lines
17 lines

Diff 44903

View Options

services/tunnelbroker/src/amqp.rs

Loading...
View Options

services/tunnelbroker/src/websockets/mod.rs

Loading...
View Options

services/tunnelbroker/src/websockets/session.rs

Loading...