Differential D13594

[tunnelbroker] Add exponential backoff to AMQP connection
ClosedPublic
Actions

Authored by bartek on Oct 3 2024, 8:42 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 18, 10:15 AM

	Unknown Object (File)
	Wed, Dec 18, 10:15 AM

	Unknown Object (File)
	Wed, Dec 18, 10:15 AM

	Unknown Object (File)
	Wed, Dec 18, 10:15 AM

	Unknown Object (File)
	Tue, Nov 26, 4:00 AM

	Unknown Object (File)
	Mon, Nov 25, 3:02 AM

	Unknown Object (File)
	Sat, Nov 23, 3:53 AM

	Unknown Object (File)
	Fri, Nov 22, 12:00 AM

View All 36 Files

Subscribers

Details

Reviewers

kamil
will
varun

Commits

rCOMM826944b480a4: [tunnelbroker] Add exponential backoff to AMQP connection

Summary

Added connection retries for AMQP. This only works on Tunnelbroker startup, it doesn't fix our logic yet for disconnects while TB is already running

Depends on D13593

Test Plan

Started Tunnelbroker, but waited with starting RabbitMQ. After running Rabbit, the connection was established after a few attempts

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Oct 3 2024, 8:42 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 3 2024, 8:42 AM

bartek added a child revision: D13595: [tunnelbroker] Rewrite AMQP handling.Oct 3 2024, 8:57 AM

Harbormaster completed remote builds in B32045: Diff 44872.Oct 3 2024, 8:59 AM

bartek published this revision for review.Oct 3 2024, 9:01 AM

bartek added inline comments.

services/tunnelbroker/src/amqp.rs
32–36 ↗	(On Diff #44872)	I chose this experimentally basing on how long local rabbitmq gets up, but we might want to add more retries.
56 ↗	(On Diff #44872)	I made it this way because this function is going to be split in the next diffs

bartek added a child revision: D13600: [tunnelbroker] Split AMQP connect function.Oct 3 2024, 1:34 PM

kamil accepted this revision.Oct 7 2024, 1:34 AM

This revision is now accepted and ready to land.Oct 7 2024, 1:34 AM

Closed by commit rCOMM826944b480a4: [tunnelbroker] Add exponential backoff to AMQP connection (authored by bartek). · Explain WhyOct 7 2024, 7:28 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM826944b480a4: [tunnelbroker] Add exponential backoff to AMQP connection.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

42 lines

shared/

comm-lib/

src/

5 lines

Diff 44930

services/tunnelbroker/src/amqp.rs

Loading...

shared/comm-lib/src/database.rs

Loading...