Page MenuHomePhabricator
Differential D13608

[tunnelbroker] Ignore connection error messages handled elsewhere
ClosedPublic
Actions

Authored by bartek on Oct 3 2024, 1:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 4:48 PM
Unknown Object (File)
Fri, Nov 22, 4:48 PM
Unknown Object (File)
Thu, Nov 21, 11:20 PM
Unknown Object (File)
Thu, Nov 21, 11:05 PM
Unknown Object (File)
Thu, Nov 21, 5:09 PM
Unknown Object (File)
Sun, Nov 10, 11:38 AM
Unknown Object (File)
Fri, Nov 8, 10:37 PM
Unknown Object (File)
Fri, Nov 8, 1:48 PM
View All 45 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
will
Commits
rCOMM424644f989f5: [tunnelbroker] Ignore connection error messages handled elsewhere
Summary

This is to avoid alerting spam for errors from inside lapin library that we handle e.g. by reconnecting to RabbitMQ.

Depends on D13607

Test Plan

When Tunnelbroker is open, stop RabbitMQ server.

Before: Error was displayed with errorType = AMQP_ERROR that connection is lost.
After: The error is not displayed from this handler. Error message appears only when all exponential backoff attempts fail.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Oct 3 2024, 1:37 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 3 2024, 1:38 PM
bartek mentioned this in D13595: [tunnelbroker] Rewrite AMQP handling.Oct 3 2024, 1:39 PM
bartek added a child revision: D13609: [tunnelbroker] Remove legacy AMQP connect function.Oct 3 2024, 1:42 PM
Harbormaster failed remote builds in B32059: Diff 44888!Oct 3 2024, 8:01 PM
bartek mentioned this in D13601: [tunnelbroker] Create thread-safe wrapper over AMQP connection.Oct 4 2024, 3:44 AM
bartek updated this revision to Diff 44905.Oct 4 2024, 8:18 AM

Remove connection pool

bartek published this revision for review.Oct 4 2024, 8:44 AM
Harbormaster completed remote builds in B32073: Diff 44905.Oct 4 2024, 8:58 AM
bartek edited the summary of this revision. (Show Details)Oct 7 2024, 2:27 AM
bartek edited the test plan for this revision. (Show Details)
kamil accepted this revision.Oct 7 2024, 2:50 AM
This revision is now accepted and ready to land.Oct 7 2024, 2:50 AM
Closed by commit rCOMM424644f989f5: [tunnelbroker] Ignore connection error messages handled elsewhere (authored by bartek). · Explain WhyOct 7 2024, 7:28 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM424644f989f5: [tunnelbroker] Ignore connection error messages handled elsewhere.
bartek mentioned this in D13703: [tunnelbroker] Ignore CONNECTIONFORCED error message.Oct 13 2024, 11:20 PM
bartek mentioned this in rCOMMed9275b0a10a: [tunnelbroker] Ignore CONNECTIONFORCED error message.Oct 14 2024, 6:45 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
25 lines

Diff 44905

View Options

services/tunnelbroker/src/amqp.rs

Loading...