Paths

Table of Contentst

Differential D13657

[lib] Use batch Blob service endpoints in processHolders action
ClosedPublic
Actions

Authored by bartek on Wed, Oct 9, 2:18 AM.

Tags

None

Referenced Files

	F2982819: D13657.id45068.diff
	Wed, Oct 16, 5:54 AM

	F2982338: D13657.id45070.diff
	Wed, Oct 16, 2:45 AM

	Unknown Object (File)
	Tue, Oct 15, 7:25 AM

	Unknown Object (File)
	Tue, Oct 15, 6:39 AM

	Unknown Object (File)
	Tue, Oct 15, 6:38 AM

	Unknown Object (File)
	Tue, Oct 15, 12:06 AM

	Unknown Object (File)
	Fri, Oct 11, 7:27 PM

	Unknown Object (File)
	Fri, Oct 11, 3:55 PM

View All 17 Files

Subscribers

Details

Reviewers

kamil
tomek

Commits

rCOMM6d07670bce77: [lib] Use batch Blob service endpoints in processHolders action

Summary

Address ENG-9355.
When processing holders, we can make 1-2 batch Blob HTTP calls instead of M+N calls for every single processed holder.

Depends on D13656

Test Plan

Start a DM thread, set image thread avatar, then reset back to emoji. With Redux devtools and console logs verify that actions are successful.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Wed, Oct 9, 2:18 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptWed, Oct 9, 2:18 AM

Harbormaster completed remote builds in B32137: Diff 45007.Wed, Oct 9, 2:44 AM

bartek published this revision for review.Wed, Oct 9, 3:05 AM

bartek added inline comments.

lib/actions/holder-actions.js
78–96 ↗	(On Diff #45007)	Generally this scenario for `failedRequests` is very rare, in 99% cases the result will be `success` or `error` (early return) so I don't think we should worry much about n^2 here

kamil accepted this revision.Thu, Oct 10, 3:14 AM

kamil added inline comments.

lib/actions/holder-actions.js
78–96 ↗	(On Diff #45007)	I would use Set with items like `JSON.stringify(failedItem)`, but keep in mind to recreate the object to make sure key order will be deterministic in stringified objects

This revision is now accepted and ready to land.Thu, Oct 10, 3:14 AM

Use approach with Set of JSON-stringified items

Rebase

Harbormaster failed remote builds in B32185: Diff 45068!Thu, Oct 10, 11:25 AM

Harbormaster failed remote builds in B32187: Diff 45070!Thu, Oct 10, 11:48 AM

Rebase

Harbormaster completed remote builds in B32191: Diff 45074.Thu, Oct 10, 12:12 PM

Closed by commit rCOMM6d07670bce77: [lib] Use batch Blob service endpoints in processHolders action (authored by bartek). · Explain WhyThu, Oct 10, 2:06 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM6d07670bce77: [lib] Use batch Blob service endpoints in processHolders action.

Revision Contents
Changeset List

Path

Size

lib/

actions/

holder-actions.js

72 lines

Diff 45090

lib/actions/holder-actions.js

Loading...