Page MenuHomePhabricator
Differential D12818

[identity] remove user ID from "no device list" log
AbandonedPublic
Actions

Authored by varun on Jul 19 2024, 10:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 11, 10:48 AM
Unknown Object (File)
Mar 5 2025, 2:24 PM
Unknown Object (File)
Feb 28 2025, 1:17 AM
Unknown Object (File)
Feb 26 2025, 11:42 AM
Unknown Object (File)
Feb 26 2025, 9:13 AM
Unknown Object (File)
Feb 20 2025, 2:47 AM
Unknown Object (File)
Jan 19 2025, 6:18 PM
Unknown Object (File)
Jan 10 2025, 3:31 PM
View All 43 Files
Subscribers
tomek

Details

Reviewers
bartek
will
ashoat
Summary

we don't want to leak user info in access logs

Test Plan

confirmed that the printed log no longer contains user_id

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
identity/
src/
grpc_services/
2 lines

Diff 42576

View Options

services/identity/src/grpc_services/authenticated.rs

Show First 20 Lines • Show All 354 Lines • ▼ Show 20 Lines if (hasMinCodeVersion(platformDetails, { majorDesktop: 12 })) {
return { return {
notifsOlmDataEncryptionKeyDBLabel: notifsOlmDataEncryptionKeyDBLabel:
getOlmEncryptionKeyDBLabelForCookie(cookie), getOlmEncryptionKeyDBLabelForCookie(cookie),
notifsOlmDataContentKey: getOlmDataContentKeyForCookie(cookie), notifsOlmDataContentKey: getOlmDataContentKeyForCookie(cookie),
}; };
} }
} }
async function reassignLocalForageItem(source: string, destination: string) {
const value = await localforage.getItem<mixed>(source);
if (!value) {
return;
}
await localforage.setItem(destination, value);
await localforage.removeItem(source);
}
const olmAPI: OlmAPI = { const olmAPI: OlmAPI = {
async initializeCryptoAccount(): Promise<void> { async initializeCryptoAccount(): Promise<void> {
const sqliteQueryExecutor = getSQLiteQueryExecutor(); const sqliteQueryExecutor = getSQLiteQueryExecutor();
if (!sqliteQueryExecutor) { if (!sqliteQueryExecutor) {
throw new Error('Database not initialized'); throw new Error('Database not initialized');
} }
const contentAccountResult = getOrCreateOlmAccount( const contentAccountResult = getOrCreateOlmAccount(
▲ Show 20 Lines • Show All 214 Lines • ▼ Show 20 Lines ): Promise<string> {
await Promise.all([ await Promise.all([
localforage.setItem(notifsOlmDataContentKey, encryptedOlmData), localforage.setItem(notifsOlmDataContentKey, encryptedOlmData),
persistEncryptionKeyPromise, persistEncryptionKeyPromise,
]); ]);
return initialNotificationsEncryptedMessage; return initialNotificationsEncryptedMessage;
}, },
async reassignNotificationsSession(
prevCookie: ?string,
newCookie: ?string,
keyserverID: string,
): Promise<void> {
const platformDetails = getPlatformDetails();
if (!platformDetails) {
throw new Error('Worker not initialized');
}
const prevPersistenceKeys = getNotifsPersistenceKeys(
prevCookie,
keyserverID,
platformDetails,
);
const newPersistenceKeys = getNotifsPersistenceKeys(
newCookie,
keyserverID,
platformDetails,
);
await Promise.all([
reassignLocalForageItem(
prevPersistenceKeys.notifsOlmDataContentKey,
newPersistenceKeys.notifsOlmDataContentKey,
),
reassignLocalForageItem(
prevPersistenceKeys.notifsOlmDataEncryptionKeyDBLabel,
newPersistenceKeys.notifsOlmDataEncryptionKeyDBLabel,
),
]);
},
async getOneTimeKeys(numberOfKeys: number): Promise<OneTimeKeysResultValues> { async getOneTimeKeys(numberOfKeys: number): Promise<OneTimeKeysResultValues> {
if (!cryptoStore) { if (!cryptoStore) {
throw new Error('Crypto account not initialized'); throw new Error('Crypto account not initialized');
} }
const { contentAccount, notificationAccount } = cryptoStore; const { contentAccount, notificationAccount } = cryptoStore;
const contentOneTimeKeys = getAccountOneTimeKeys( const contentOneTimeKeys = getAccountOneTimeKeys(
contentAccount, contentAccount,
▲ Show 20 Lines • Show All 82 Lines • Show Last 20 Lines