Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Today

ashoat requested review of D11807: [native] Fix pending state in ExistingEthereumAccount for identity auth.
Fri, Apr 26, 11:57 AM
ashoat closed D11801: [native] Don't auto-capitalize password entry in PasswordSelection.
Fri, Apr 26, 11:55 AM
ashoat committed rCOMMa234956433a8: [native] Don't auto-capitalize password entry in PasswordSelection (authored by ashoat).
[native] Don't auto-capitalize password entry in PasswordSelection
Fri, Apr 26, 11:55 AM
ashoat requested review of D11806: [lib][native][web] Rename LogInExtraInfo to LegacyLogInExtraInfo.
Fri, Apr 26, 11:52 AM
ashoat requested review of D11805: [lib][native][web] Rename some legacy login types.
Fri, Apr 26, 11:46 AM
ashoat requested review of D11804: [lib] Fix payload of KEYSERVER_AUTH_STARTED action.
Fri, Apr 26, 11:43 AM
ashoat requested review of D11803: [lib][native] Rename keyserverRegister to legacyKeyserverRegister.
Fri, Apr 26, 11:42 AM
ashoat requested review of D11802: [lib][native][web] Rename siweAuth to legacySiweAuth.
Fri, Apr 26, 11:40 AM
ashoat added a comment to D11764: [lib][native][web] Rename useLogIn to useLegacyLogIn.
In D11764#338363, @ashoat wrote:
In D11764#338319, @inka wrote:

Should we rename siweAuthActionTypes to legacySiweAuthActionTypes and keyserverRegisterActionTypes to legacyKeyserverRegisterActionTypes?

Good call. I'll do those in separate diffs

Fri, Apr 26, 11:32 AM
ashoat closed D11769: [lib] Don't set dataLoaded on authoritative keyserver auth.
Fri, Apr 26, 8:18 AM
ashoat committed rCOMM6c22f9210dab: [lib] Don't set dataLoaded on authoritative keyserver auth (authored by ashoat).
[lib] Don't set dataLoaded on authoritative keyserver auth
Fri, Apr 26, 8:18 AM
ashoat closed D11768: [lib][native][web] Introduce useWalletLogIn hook.
Fri, Apr 26, 8:18 AM
ashoat closed D11767: [native] Use useRegistrationServerCall in FullscreenSIWEPanel for identity registration.
Fri, Apr 26, 8:18 AM
ashoat committed rCOMM84670804db33: [lib][native][web] Introduce useWalletLogIn hook (authored by ashoat).
[lib][native][web] Introduce useWalletLogIn hook
Fri, Apr 26, 8:18 AM
ashoat committed rCOMMce4b2c8e917d: [native] Use useRegistrationServerCall in FullscreenSIWEPanel for identity… (authored by ashoat).
[native] Use useRegistrationServerCall in FullscreenSIWEPanel for identity…
Fri, Apr 26, 8:18 AM
ashoat closed D11766: [lib][native] Defer saving user credentials until successful auth.
Fri, Apr 26, 8:18 AM
ashoat closed D11765: [lib][native][web] Introduce usePasswordLogIn hook.
Fri, Apr 26, 8:18 AM
ashoat closed D11764: [lib][native][web] Rename useLogIn to useLegacyLogIn.
Fri, Apr 26, 8:18 AM
ashoat committed rCOMM424ea6f92e58: [lib][native] Defer saving user credentials until successful auth (authored by ashoat).
[lib][native] Defer saving user credentials until successful auth
Fri, Apr 26, 8:18 AM
ashoat committed rCOMMb1dff3d63e23: [lib][native][web] Introduce usePasswordLogIn hook (authored by ashoat).
[lib][native][web] Introduce usePasswordLogIn hook
Fri, Apr 26, 8:18 AM
ashoat committed rCOMM60e5ad1f8f90: [lib][native][web] Rename useLogIn to useLegacyLogIn (authored by ashoat).
[lib][native][web] Rename useLogIn to useLegacyLogIn
Fri, Apr 26, 8:18 AM
ashoat closed D11762: [lib] Don't try authing to authoritative keyserver from KeyserverConnectionHandler.
Fri, Apr 26, 8:18 AM
ashoat closed D11763: [native] Auth with authoritative keyserver directly from registration flow.
Fri, Apr 26, 8:18 AM
ashoat committed rCOMMb6892dc7ad72: [lib] Don't try authing to authoritative keyserver from… (authored by ashoat).
[lib] Don't try authing to authoritative keyserver from…
Fri, Apr 26, 8:18 AM
ashoat committed rCOMM6853e9c0f6dd: [native] Auth with authoritative keyserver directly from registration flow (authored by ashoat).
[native] Auth with authoritative keyserver directly from registration flow
Fri, Apr 26, 8:18 AM
ashoat closed D11761: [lib] Extract useRawKeyserverAuth.
Fri, Apr 26, 8:18 AM
ashoat committed rCOMMd8130c105d12: [lib] Extract useRawKeyserverAuth (authored by ashoat).
[lib] Extract useRawKeyserverAuth
Fri, Apr 26, 8:18 AM
ashoat updated the diff for D11768: [lib][native][web] Introduce useWalletLogIn hook.

Use the name walletLogIn for the result of useWalletLogIn(), and rename attemptIdentityWalletLogIn to attemptWalletLogIn

Fri, Apr 26, 8:15 AM
ashoat requested review of D11801: [native] Don't auto-capitalize password entry in PasswordSelection.
Fri, Apr 26, 8:14 AM
ashoat updated the diff for D11765: [lib][native][web] Introduce usePasswordLogIn hook.

waiting_for_identity_login_in_redux -> identity_login_dispatched

Fri, Apr 26, 8:10 AM
ashoat added inline comments to D11767: [native] Use useRegistrationServerCall in FullscreenSIWEPanel for identity registration.
Fri, Apr 26, 8:06 AM
ashoat added a comment to D11764: [lib][native][web] Rename useLogIn to useLegacyLogIn.
In D11764#338319, @inka wrote:

Should we rename siweAuthActionTypes to legacySiweAuthActionTypes and keyserverRegisterActionTypes to legacyKeyserverRegisterActionTypes?

Fri, Apr 26, 8:04 AM
ashoat updated the diff for D11763: [native] Auth with authoritative keyserver directly from registration flow.

waiting_for_identity_registration_in_redux -> identity_registration_dispatched
waiting_for_authoritative_keyserver_registration_in_redux -> authoritative_keyserver_registration_dispatched

Fri, Apr 26, 8:04 AM
ashoat closed D11794: [native] Don't refetch nonce after SIWE is complete.
Fri, Apr 26, 7:59 AM
ashoat committed rCOMMaa57bc6d30c8: [native] Don't refetch nonce after SIWE is complete (authored by ashoat).
[native] Don't refetch nonce after SIWE is complete
Fri, Apr 26, 7:59 AM
ashoat updated the diff for D11794: [native] Don't refetch nonce after SIWE is complete.

doneRef -> nonceNotNeededRef

Fri, Apr 26, 7:59 AM

Yesterday

ashoat resigned from D11793: [native] introduce tag farcaster button.

Copy looks good!

Thu, Apr 25, 7:17 PM
ashoat requested review of D11794: [native] Don't refetch nonce after SIWE is complete.
Thu, Apr 25, 4:23 PM
ashoat added a reverting change for D11771: [native] Don't refetch nonce from identity after identity auth: rCOMM57e75feedec7: Revert "[native] Don't refetch nonce from identity after identity auth".
Thu, Apr 25, 4:01 PM
ashoat added a reverting change for rCOMM7ad3d18e3433: [native] Don't refetch nonce from identity after identity auth: rCOMM57e75feedec7: Revert "[native] Don't refetch nonce from identity after identity auth".
Thu, Apr 25, 4:01 PM
ashoat committed rCOMM57e75feedec7: Revert "[native] Don't refetch nonce from identity after identity auth" (authored by ashoat).
Revert "[native] Don't refetch nonce from identity after identity auth"
Thu, Apr 25, 4:01 PM
ashoat added a comment to D11793: [native] introduce tag farcaster button.

No reviewers specified

Thu, Apr 25, 3:46 PM
ashoat accepted D11792: [lib] Turn `canPromoteSidebar` to `useCanPromoteSidebar` hook.
Thu, Apr 25, 2:33 PM
ashoat accepted D11791: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ThreadSettings`.
Thu, Apr 25, 2:29 PM
ashoat accepted D11790: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `TextMessage`.
Thu, Apr 25, 2:28 PM
ashoat accepted D11789: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ChatInputBar`.
Thu, Apr 25, 2:28 PM
ashoat accepted D11788: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `Entry`.
Thu, Apr 25, 2:13 PM
ashoat accepted D11787: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `CommunityActionsButton`.
Thu, Apr 25, 2:12 PM
ashoat accepted D11786: [native] Replace `threadHasPermission` with `useThreadHasPermission` in `ViewInviteLinksScreen`.
Thu, Apr 25, 2:11 PM
ashoat added a reverting change for rCOMM35d519850c60: [native] Temporary changes for staff release: rCOMM7a33a7028ba9: Revert "[native] Temporary changes for staff release".
Thu, Apr 25, 11:35 AM
ashoat committed rCOMM7a33a7028ba9: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Thu, Apr 25, 11:35 AM
ashoat committed rCOMM976eefcb084a: [native] codeVersion -> 340 (authored by ashoat).
[native] codeVersion -> 340
Thu, Apr 25, 11:35 AM
ashoat committed rCOMM35d519850c60: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Thu, Apr 25, 11:35 AM
ashoat committed rCOMMcdd3244d138a: [native] codeVersion -> 339 (authored by ashoat).
[native] codeVersion -> 339
Thu, Apr 25, 11:35 AM
ashoat committed rCOMM137b4e7c1f85: [web][keyserver] codeVersion -> 80 (authored by ashoat).
[web][keyserver] codeVersion -> 80
Thu, Apr 25, 11:30 AM
ashoat added inline comments to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
Thu, Apr 25, 11:19 AM
ashoat added inline comments to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
Thu, Apr 25, 11:18 AM
ashoat requested changes to D11780: [keyserver] Fix sending a user cookie when olm session creation failed.

I can review this one, as I'm most familiar with the code. General direction makes sense, but I have some concerns

Thu, Apr 25, 11:16 AM
ashoat updated the diff for D11769: [lib] Don't set dataLoaded on authoritative keyserver auth.

Rebase

Thu, Apr 25, 10:52 AM
ashoat updated the diff for D11768: [lib][native][web] Introduce useWalletLogIn hook.

Lint fix following rebase

Thu, Apr 25, 10:51 AM
ashoat resigned from D11782: Let the user skip backup message generation and record it in alert store.

Resigning to let @ginsu review the alert parts. Overall looks good to me, but I think the skippedByUser state can be removed. @marcin – in case you disagree with that, can you re-add me (if possible) or just delay landing until I can confirm that it's good to land?

Thu, Apr 25, 10:45 AM
ashoat updated the diff for D11769: [lib] Don't set dataLoaded on authoritative keyserver auth.

Rebase

Thu, Apr 25, 10:04 AM
ashoat updated the diff for D11768: [lib][native][web] Introduce useWalletLogIn hook.

Rebase

Thu, Apr 25, 10:03 AM
ashoat updated the diff for D11766: [lib][native] Defer saving user credentials until successful auth.

Rebase

Thu, Apr 25, 10:03 AM
ashoat updated the diff for D11765: [lib][native][web] Introduce usePasswordLogIn hook.
  1. waiting_for_identity_registration -> waiting_for_identity_login_in_redux
  2. Add a check that step is inactive in order to avoid triggering auth multiple times
Thu, Apr 25, 9:59 AM
ashoat updated the diff for D11763: [native] Auth with authoritative keyserver directly from registration flow.

Suffix step names with _in_redux

Thu, Apr 25, 9:55 AM
ashoat added inline comments to D11141: [IGNORE] Client hacks for testing multiple keyservers.
Thu, Apr 25, 8:11 AM
ashoat added inline comments to D11773: [keyserver] introduce create_or_update_farcaster_channel_tag endpoint.
Thu, Apr 25, 8:08 AM
ashoat closed D11771: [native] Don't refetch nonce from identity after identity auth.
Thu, Apr 25, 8:03 AM
ashoat committed rCOMM7ad3d18e3433: [native] Don't refetch nonce from identity after identity auth (authored by ashoat).
[native] Don't refetch nonce from identity after identity auth
Thu, Apr 25, 8:03 AM
ashoat accepted D11779: Add missing privacy API declarations and upgrade MMKV.
Thu, Apr 25, 8:01 AM
ashoat closed D11770: [keyserver] Print exception that causes failed_to_retrieve_inbound_keys.
Thu, Apr 25, 7:55 AM
ashoat committed rCOMM05c178babeb7: [keyserver] Print exception that causes failed_to_retrieve_inbound_keys (authored by ashoat).
[keyserver] Print exception that causes failed_to_retrieve_inbound_keys
Thu, Apr 25, 7:55 AM
ashoat added inline comments to D11763: [native] Auth with authoritative keyserver directly from registration flow.
Thu, Apr 25, 6:04 AM
ashoat added inline comments to D11766: [lib][native] Defer saving user credentials until successful auth.
Thu, Apr 25, 5:59 AM
ashoat added inline comments to D11765: [lib][native][web] Introduce usePasswordLogIn hook.
Thu, Apr 25, 5:55 AM
ashoat added inline comments to D11763: [native] Auth with authoritative keyserver directly from registration flow.
Thu, Apr 25, 5:53 AM
ashoat added inline comments to D11763: [native] Auth with authoritative keyserver directly from registration flow.
Thu, Apr 25, 5:47 AM
ashoat added inline comments to D11761: [lib] Extract useRawKeyserverAuth.
Thu, Apr 25, 5:45 AM

Wed, Apr 24

ashoat added inline comments to D11760: [web] Fix missing relationship buttons.
Wed, Apr 24, 6:32 PM
ashoat accepted D11757: [SIWE] Differentiate content for social proof and backup message..
Wed, Apr 24, 6:29 PM
ashoat requested review of D11771: [native] Don't refetch nonce from identity after identity auth.
Wed, Apr 24, 1:41 PM
ashoat requested review of D11770: [keyserver] Print exception that causes failed_to_retrieve_inbound_keys.
Wed, Apr 24, 1:35 PM
ashoat requested review of D11769: [lib] Don't set dataLoaded on authoritative keyserver auth.
Wed, Apr 24, 1:26 PM
ashoat requested review of D11768: [lib][native][web] Introduce useWalletLogIn hook.
Wed, Apr 24, 1:22 PM
ashoat requested review of D11767: [native] Use useRegistrationServerCall in FullscreenSIWEPanel for identity registration.
Wed, Apr 24, 1:16 PM
ashoat requested review of D11766: [lib][native] Defer saving user credentials until successful auth.
Wed, Apr 24, 1:12 PM
ashoat requested review of D11765: [lib][native][web] Introduce usePasswordLogIn hook.
Wed, Apr 24, 1:06 PM
ashoat requested review of D11764: [lib][native][web] Rename useLogIn to useLegacyLogIn.
Wed, Apr 24, 1:01 PM
ashoat requested review of D11762: [lib] Don't try authing to authoritative keyserver from KeyserverConnectionHandler.
Wed, Apr 24, 1:00 PM
ashoat requested review of D11763: [native] Auth with authoritative keyserver directly from registration flow.
Wed, Apr 24, 12:58 PM
ashoat requested review of D11761: [lib] Extract useRawKeyserverAuth.
Wed, Apr 24, 12:56 PM

Tue, Apr 23

ashoat closed D11692: [lib] Don't reduce KEYSERVER_AUTH_SUCCESS in reduceCurrentUserInfo.
Tue, Apr 23, 10:01 AM
ashoat committed rCOMM98dbbf1b5f85: [lib] Don't reduce KEYSERVER_AUTH_SUCCESS in reduceCurrentUserInfo (authored by ashoat).
[lib] Don't reduce KEYSERVER_AUTH_SUCCESS in reduceCurrentUserInfo
Tue, Apr 23, 10:01 AM
ashoat added inline comments to D11739: [web] render `DBOpsHandler` in `TunnelbrokerProvider`.
Tue, Apr 23, 9:41 AM
ashoat added inline comments to D11730: [lib/web/native] update `MessageID` in ops handling.
Tue, Apr 23, 9:40 AM
ashoat accepted D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType.

Looks like steps 2 and 3 are completed here

Tue, Apr 23, 9:32 AM
ashoat added a comment to D11694: [native][web] Align logic in SQLiteDataHandlers across platforms.

Following up on the discussion about extracting an interface, @kamil created a task here

Tue, Apr 23, 8:49 AM

Mon, Apr 22

ashoat updated the diff for D11692: [lib] Don't reduce KEYSERVER_AUTH_SUCCESS in reduceCurrentUserInfo.

Treat LoggedOutUserInfo the same as null/undefined

Mon, Apr 22, 7:02 PM
ashoat added inline comments to D11692: [lib] Don't reduce KEYSERVER_AUTH_SUCCESS in reduceCurrentUserInfo.
Mon, Apr 22, 7:00 PM
Next