Page MenuHomePhabricator

ginsu (Ginsu Eddy)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 23 2022, 10:29 AM (100 w, 1 h)

Recent Activity

Fri, Jul 12

ginsu closed D12716: [lib/native] lift auto join community handler to lib.
Fri, Jul 12, 5:48 PM
ginsu closed D12717: [web] introduce AutoJoinCommunityHandler to web.
Fri, Jul 12, 5:48 PM
ginsu committed rCOMM41181031c715: [web] introduce AutoJoinCommunityHandler to web (authored by ginsu).
[web] introduce AutoJoinCommunityHandler to web
Fri, Jul 12, 5:48 PM
ginsu committed rCOMM6df10a6241b5: [lib/native] lift auto join community handler to lib (authored by ginsu).
[lib/native] lift auto join community handler to lib
Fri, Jul 12, 5:48 PM
ginsu closed D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.
Fri, Jul 12, 5:48 PM
ginsu committed rCOMM41570ee3f402: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook (authored by ginsu).
[native] update AutoJoinCommunityHandler to use useJoinCommunity hook
Fri, Jul 12, 5:48 PM
ginsu updated the diff for D12717: [web] introduce AutoJoinCommunityHandler to web.

rebase before landing

Fri, Jul 12, 5:47 PM
ginsu added inline comments to D12717: [web] introduce AutoJoinCommunityHandler to web.
Fri, Jul 12, 5:46 PM
ginsu updated the diff for D12716: [lib/native] lift auto join community handler to lib.

rebase before landing

Fri, Jul 12, 5:18 PM
ginsu updated the diff for D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.

address comments + rebase before landing

Fri, Jul 12, 4:59 PM

Thu, Jul 11

ginsu closed D12718: [native] fix farcaster prompt being displayed to users with fid on login.
Thu, Jul 11, 11:58 PM
ginsu committed rCOMMdb7542de41c8: [native] fix farcaster prompt being displayed to users with fid on login (authored by ginsu).
[native] fix farcaster prompt being displayed to users with fid on login
Thu, Jul 11, 11:58 PM
ginsu updated the diff for D12718: [native] fix farcaster prompt being displayed to users with fid on login.

rebase before landing

Thu, Jul 11, 11:56 PM
ginsu attached a referenced file: F2247320: Screenshot 2024-07-12 at 12.23.44 AM.png.
Thu, Jul 11, 11:38 PM
ginsu requested review of D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.

It's not clear why you turned this into an object. You don't seem to be using the keys below in joinHandlers, and that seems to be the only place you communitiesToAutoJoin. Why did you update this to an object?

Thu, Jul 11, 11:38 PM
ginsu closed D12713: [lib] make useJoinCommunity compatible with the auto join community handler.
Thu, Jul 11, 9:01 PM
ginsu committed rCOMMc28089f95107: [lib] make useJoinCommunity compatible with the auto join community handler (authored by ginsu).
[lib] make useJoinCommunity compatible with the auto join community handler
Thu, Jul 11, 9:01 PM
ginsu closed D12706: [lib] introduce useJoinCommunity.
Thu, Jul 11, 9:01 PM
ginsu committed rCOMM8e487bb3cb67: [lib] introduce useJoinCommunity (authored by ginsu).
[lib] introduce useJoinCommunity
Thu, Jul 11, 9:01 PM
ginsu updated the diff for D12713: [lib] make useJoinCommunity compatible with the auto join community handler.

rebase before landing

Thu, Jul 11, 8:56 PM
ginsu updated the diff for D12706: [lib] introduce useJoinCommunity.

rebase before landing

Thu, Jul 11, 8:54 PM
ginsu attached a referenced file: F2235986: Screenshot 2024-07-11 at 3.53.12 AM.png.
Thu, Jul 11, 1:18 AM
ginsu added inline comments to D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.
Thu, Jul 11, 1:18 AM
ginsu updated the diff for D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.

update

Thu, Jul 11, 12:54 AM

Wed, Jul 10

ginsu updated the diff for D12713: [lib] make useJoinCommunity compatible with the auto join community handler.

update

Wed, Jul 10, 11:57 PM
ginsu added inline comments to D12706: [lib] introduce useJoinCommunity.
Wed, Jul 10, 11:55 PM
ginsu updated the diff for D12706: [lib] introduce useJoinCommunity.

update

Wed, Jul 10, 11:52 PM
ginsu attached a referenced file: F2235076: Screen Recording 2024-07-11 at 12.44.17 AM.mov.
Wed, Jul 10, 11:51 PM
ginsu updated the test plan for D12718: [native] fix farcaster prompt being displayed to users with fid on login.
Wed, Jul 10, 11:51 PM
ginsu added inline comments to D12718: [native] fix farcaster prompt being displayed to users with fid on login.
Wed, Jul 10, 11:49 PM
ginsu updated the diff for D12718: [native] fix farcaster prompt being displayed to users with fid on login.

address comments

Wed, Jul 10, 11:38 PM
ginsu added a comment to D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.

Hmm... what did you think of my suggestion earlier?

What do you think about making sure this effect is only run once per app startup?

Wed, Jul 10, 2:43 PM
ginsu attached a referenced file: F2231501: Screenshot 2024-07-10 at 4.36.18 PM.png.
Wed, Jul 10, 1:42 PM
ginsu attached a referenced file: F2231502: Screenshot 2024-07-10 at 4.36.44 PM.png.
Wed, Jul 10, 1:42 PM
ginsu added inline comments to D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.
Wed, Jul 10, 1:42 PM
ginsu updated the diff for D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.

update

Wed, Jul 10, 1:23 PM
ginsu planned changes to D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.

Messed something up when stashing + rebasing

Wed, Jul 10, 1:10 PM
ginsu updated the diff for D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.

address comments

Wed, Jul 10, 1:08 PM
ginsu updated the summary of D12717: [web] introduce AutoJoinCommunityHandler to web.
Wed, Jul 10, 3:37 AM
ginsu updated the summary of D12716: [lib/native] lift auto join community handler to lib.
Wed, Jul 10, 3:36 AM
ginsu updated the summary of D12716: [lib/native] lift auto join community handler to lib.
Wed, Jul 10, 3:36 AM
ginsu requested review of D12718: [native] fix farcaster prompt being displayed to users with fid on login.
Wed, Jul 10, 3:22 AM
ginsu requested review of D12717: [web] introduce AutoJoinCommunityHandler to web.
Wed, Jul 10, 3:20 AM
ginsu requested review of D12716: [lib/native] lift auto join community handler to lib.
Wed, Jul 10, 3:12 AM
ginsu attached a referenced file: F2225800: Screenshot 2024-07-10 at 5.04.37 AM.png.
Wed, Jul 10, 2:26 AM
ginsu added inline comments to D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.
Wed, Jul 10, 2:25 AM
ginsu updated the diff for D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.

update

Wed, Jul 10, 2:21 AM
ginsu updated the summary of D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.
Wed, Jul 10, 2:10 AM
ginsu updated the diff for D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.

update

Wed, Jul 10, 1:55 AM
ginsu requested review of D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.
Wed, Jul 10, 12:46 AM

Tue, Jul 9

ginsu requested review of D12713: [lib] make useJoinCommunity compatible with the auto join community handler.
Tue, Jul 9, 11:48 PM
ginsu updated the diff for D12706: [lib] introduce useJoinCommunity.

address comments

Tue, Jul 9, 11:21 PM
ginsu closed D12702: [keyserver] include keyserver url in the farcaster channel tag blob.
Tue, Jul 9, 3:57 PM
ginsu committed rCOMMc3e3a929049a: [keyserver] include keyserver url in the farcaster channel tag blob (authored by ginsu).
[keyserver] include keyserver url in the farcaster channel tag blob
Tue, Jul 9, 3:57 PM
ginsu closed D12685: [lib] check if the user fid is still valid.
Tue, Jul 9, 3:57 PM
ginsu committed rCOMMd5263d00f887: [lib] check if the user fid is still valid (authored by ginsu).
[lib] check if the user fid is still valid
Tue, Jul 9, 3:57 PM
ginsu closed D12569: [lib/web] introduce handleCurrentUserFID to FarcasterDataHandler.
Tue, Jul 9, 3:57 PM
ginsu committed rCOMM97be818970cb: [lib/web] introduce handleCurrentUserFID to FarcasterDataHandler (authored by ginsu).
[lib/web] introduce handleCurrentUserFID to FarcasterDataHandler
Tue, Jul 9, 3:57 PM
ginsu closed D12683: [native] update connect farcaster prompt to be less annyoying.
Tue, Jul 9, 3:57 PM
ginsu committed rCOMMf56e3117de03: [native] update connect farcaster prompt to be less annyoying (authored by ginsu).
[native] update connect farcaster prompt to be less annyoying
Tue, Jul 9, 3:57 PM
ginsu updated the diff for D12702: [keyserver] include keyserver url in the farcaster channel tag blob.

rebase before landing

Tue, Jul 9, 3:32 PM
ginsu updated the diff for D12685: [lib] check if the user fid is still valid.

rebase before landing

Tue, Jul 9, 3:31 PM
ginsu updated the diff for D12569: [lib/web] introduce handleCurrentUserFID to FarcasterDataHandler.

rebase before landing

Tue, Jul 9, 3:30 PM
ginsu updated the diff for D12683: [native] update connect farcaster prompt to be less annyoying.

address comments + rebase before landing

Tue, Jul 9, 3:29 PM
ginsu added a comment to D12685: [lib] check if the user fid is still valid.

Was writing inline comments explaining why fid && fid !== NO_FID_METADATA can be just fid

Tue, Jul 9, 1:48 PM
ginsu added inline comments to D12685: [lib] check if the user fid is still valid.
Tue, Jul 9, 1:42 PM
ginsu updated the diff for D12685: [lib] check if the user fid is still valid.

address comments

Tue, Jul 9, 1:41 PM
ginsu added inline comments to D12683: [native] update connect farcaster prompt to be less annyoying.
Tue, Jul 9, 12:20 PM
ginsu updated the diff for D12569: [lib/web] introduce handleCurrentUserFID to FarcasterDataHandler.

address comments

Tue, Jul 9, 12:10 PM
ginsu added inline comments to D12683: [native] update connect farcaster prompt to be less annyoying.
Tue, Jul 9, 12:03 PM
ginsu updated the diff for D12683: [native] update connect farcaster prompt to be less annyoying.

address comments

Tue, Jul 9, 11:58 AM
ginsu added a comment to D12683: [native] update connect farcaster prompt to be less annyoying.

Don't we now need to consider NO_FID_METADATA in all places we fetch the FID? It seems like it would need to be checked at every place the FID is fetched.

In the linear task we said:

Don't prompt if the FID in Redux is null NONE

Based off this I was under the impression that we only want to keep NO_FID_METADATA something that is only in redux/sqlite and not in the identity service. By keeping NO_FID_METADATA only in redux/sqlite, we would re-show the farcaster prompt to the user if they ever logged out + logged back in on native, and my thinking was that this would act as another one time nudge to the user that they should connect their farcaster account to comm.

It seems like I may have misinterpreted this point. If I did I should be able to easily update this diff so that we also have NO_FID_METADATA stored in the identity service if the user decides not to connect their farcaster account

I think there's some confusion here. I'm not suggesting storing NO_FID_METADATA on identity.

Rather, I'm concerned that we don't have any updates to code that fetches/checks syncedMetadataNames.CURRENT_USER_FID here.

We are storing a new special value in that field, that should be treated equivalently to null/undefined. Don't we need to update the code that fetches/checks syncedMetadataNames.CURRENT_USER_FID so that it knows to treat this special value as null/undefined?

Let me know if I'm missing something!

Tue, Jul 9, 11:58 AM
ginsu requested review of D12706: [lib] introduce useJoinCommunity.
Tue, Jul 9, 10:05 AM
ginsu requested review of D12702: [keyserver] include keyserver url in the farcaster channel tag blob.
Tue, Jul 9, 12:24 AM

Mon, Jul 8

ginsu added a comment to D12683: [native] update connect farcaster prompt to be less annyoying.

Don't we now need to consider NO_FID_METADATA in all places we fetch the FID? It seems like it would need to be checked at every place the FID is fetched.

Mon, Jul 8, 4:41 PM
ginsu updated the summary of D12569: [lib/web] introduce handleCurrentUserFID to FarcasterDataHandler.
Mon, Jul 8, 4:25 PM
ginsu added inline comments to D12685: [lib] check if the user fid is still valid.
Mon, Jul 8, 4:12 PM
ginsu updated the diff for D12685: [lib] check if the user fid is still valid.

forgot to save/commit changes

Mon, Jul 8, 4:01 PM
ginsu attached a referenced file: F2214147: Screenshot 2024-07-08 at 6.47.51 PM.png.
Mon, Jul 8, 3:59 PM
ginsu added inline comments to D12685: [lib] check if the user fid is still valid.
Mon, Jul 8, 3:55 PM
ginsu updated the diff for D12685: [lib] check if the user fid is still valid.

address comments

Mon, Jul 8, 3:55 PM
ginsu updated the diff for D12569: [lib/web] introduce handleCurrentUserFID to FarcasterDataHandler.

update

Mon, Jul 8, 3:21 PM
ginsu updated the test plan for D12569: [lib/web] introduce handleCurrentUserFID to FarcasterDataHandler.
Mon, Jul 8, 2:45 PM
ginsu requested review of D12569: [lib/web] introduce handleCurrentUserFID to FarcasterDataHandler.

If the network issue gets triggered by the keyserver connection status cycling, then we'll want to add some condition to eg. make sure it only runs once per app start / foreground event. If that's the case, please re-request review. Otherwise it looks good to land!

Mon, Jul 8, 2:41 PM
ginsu updated the diff for D12569: [lib/web] introduce handleCurrentUserFID to FarcasterDataHandler.

fix network call getting triggered when client disconnect with the keyserver socket

Mon, Jul 8, 2:39 PM
ginsu closed D12684: [landing/lib/native/web] update copy for thread notifications for the rest of the app.
Mon, Jul 8, 12:56 PM
ginsu committed rCOMM4176f25c2bba: [landing/lib/native/web] update copy for thread notifications for the rest of… (authored by ginsu).
[landing/lib/native/web] update copy for thread notifications for the rest of…
Mon, Jul 8, 12:56 PM
ginsu closed D12581: [native] fix empty media gallery in thread settings.
Mon, Jul 8, 12:56 PM
ginsu committed rCOMM1d4adf7c55f0: [native] fix empty media gallery in thread settings (authored by ginsu).
[native] fix empty media gallery in thread settings
Mon, Jul 8, 12:56 PM
ginsu retitled D12684: [landing/lib/native/web] update copy for thread notifications for the rest of the app from [landing] update copy for thread notifications on landing to [landing/lib/native/web] update copy for thread notifications for the rest of the app.
Mon, Jul 8, 12:54 PM
ginsu updated the diff for D12684: [landing/lib/native/web] update copy for thread notifications for the rest of the app.

rebase before landing

Mon, Jul 8, 12:54 PM
ginsu updated the diff for D12581: [native] fix empty media gallery in thread settings.

rebase before landing

Mon, Jul 8, 12:53 PM
ginsu added 1 blocking reviewer(s) for D12684: [landing/lib/native/web] update copy for thread notifications for the rest of the app: ashoat.

Making @ashoat blocking since this is a copy change diff

Mon, Jul 8, 11:03 AM
ginsu added a comment to D12683: [native] update connect farcaster prompt to be less annyoying.

shouldSkipPushPermissionAlert should probably be updated - if I understand correctly this diff makes it impossible for totalAlerts to exceed 1, is that correct?

Mon, Jul 8, 11:02 AM
ginsu requested review of D12685: [lib] check if the user fid is still valid.
Mon, Jul 8, 1:48 AM
ginsu added inline comments to D12569: [lib/web] introduce handleCurrentUserFID to FarcasterDataHandler.
Mon, Jul 8, 1:13 AM
ginsu added a comment to D12569: [lib/web] introduce handleCurrentUserFID to FarcasterDataHandler.

When do we want handleCurrentUserFID to run?

Mon, Jul 8, 1:10 AM
ginsu updated the summary of D12569: [lib/web] introduce handleCurrentUserFID to FarcasterDataHandler.
Mon, Jul 8, 1:00 AM
ginsu added inline comments to D12684: [landing/lib/native/web] update copy for thread notifications for the rest of the app.
Mon, Jul 8, 12:42 AM
ginsu updated the diff for D12569: [lib/web] introduce handleCurrentUserFID to FarcasterDataHandler.

update

Mon, Jul 8, 12:41 AM