address feedback

address feedback

rebase

update message list header to new desgin

No longer necessary with D7178

In D7132#212051, @ashoat wrote:

Mostly questions

remove stray ?

change order

new version of useGetAvatarForThread

In D7067#212617, @ashoat wrote:

One last thing that would be great if you could test: what happens if you upload a single very "thin" photo? I want to make sure it doesn't expand to take the whole width and then becomes super tall. (Or at least, that there's no regression in this.)

Sorry for all the specific test plan requests, I just remember there being a lot of edge cases with this code from back when I was working on it.

memoize MessageTooltipButtonAvatar

address comments

you almost certainly need to be looking at threadInfoFromRawThreadInfo.

My last proposed solution to fix the chat bubble poking out of the message box is to make the message box a flex container and align the inner text messages (either flex-end or flex-start) depending on if the message came from the viewer or not. This solution is very similar to how we position the InlineEngagement component, which inspired me to implement the solution this way.

add feature flags and fix poking chat bubble

update prop types for thread settings avatar