User Details
- User Since
- Aug 23 2022, 10:29 AM (120 w, 1 h)
Jul 12 2024
rebase before landing
rebase before landing
address comments + rebase before landing
Jul 11 2024
rebase before landing
It's not clear why you turned this into an object. You don't seem to be using the keys below in joinHandlers, and that seems to be the only place you communitiesToAutoJoin. Why did you update this to an object?
rebase before landing
rebase before landing
update
Jul 10 2024
update
address comments
Hmm... what did you think of my suggestion earlier?
What do you think about making sure this effect is only run once per app startup?
update
Messed something up when stashing + rebasing
address comments
update
update
Jul 9 2024
address comments
rebase before landing
rebase before landing
rebase before landing
address comments + rebase before landing
Was writing inline comments explaining why fid && fid !== NO_FID_METADATA can be just fid
address comments
address comments
address comments
Jul 8 2024
Don't we now need to consider NO_FID_METADATA in all places we fetch the FID? It seems like it would need to be checked at every place the FID is fetched.
forgot to save/commit changes
address comments
update
If the network issue gets triggered by the keyserver connection status cycling, then we'll want to add some condition to eg. make sure it only runs once per app start / foreground event. If that's the case, please re-request review. Otherwise it looks good to land!
fix network call getting triggered when client disconnect with the keyserver socket
rebase before landing
rebase before landing
Making @ashoat blocking since this is a copy change diff
shouldSkipPushPermissionAlert should probably be updated - if I understand correctly this diff makes it impossible for totalAlerts to exceed 1, is that correct?
When do we want handleCurrentUserFID to run?
update