Page MenuHomePhabricator

ginsu (Ginsu Eddy)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 23 2022, 10:29 AM (79 w, 5 d)

Recent Activity

Wed, Feb 28

ginsu requested review of D11192: [lib] introduce removeCommunityActionType.

will make sure ci passes before landing

Wed, Feb 28, 6:22 AM
ginsu planned changes to D11191: DRAFT [lib/native/web] introduce migration to populate community store.

native migration not working correctly

Wed, Feb 28, 12:29 AM
ginsu published D11191: DRAFT [lib/native/web] introduce migration to populate community store for review.
Wed, Feb 28, 12:28 AM
ginsu updated the summary of D11167: [lib] populate community store on user login.
Wed, Feb 28, 12:21 AM

Tue, Feb 27

ginsu requested review of D11190: [lib/native/web] read communites from sqlite on app start.
Tue, Feb 27, 11:51 PM
ginsu requested changes to D11188: [web] Redux migration to patch in `specialRole` field.

Question inline about updating version field

Tue, Feb 27, 11:44 PM
ginsu updated the summary of D11167: [lib] populate community store on user login.
Tue, Feb 27, 11:37 PM
ginsu added inline comments to D11167: [lib] populate community store on user login.
Tue, Feb 27, 8:53 PM
ginsu added a comment to D11166: [lib] introduce community reducer.

In this diff, you are starting to process store ops on DB - and it looks like CommunityInfo has a field called enabledApps which I think we already have defined somewhere. Do we need some sort of migration or this is just a brand-new store and we'll start populating it after adding business logic/UI?

Tue, Feb 27, 8:48 PM
ginsu requested review of D11166: [lib] introduce community reducer.
In D11166#323019, @atul wrote:

Mostly looks good, but do we need to handle clearing the data on log out/delete account/etc?

In our current approach, we don't need to do anything: resetUserSpecificState should handle it. Only the fields from nonUserSpecificFieldsWeb and nonUserSpecificFieldsNative survive these actions. But please test it.

Tue, Feb 27, 8:42 PM
ginsu closed D11165: [lib] introduce addCommunityActionType.
Tue, Feb 27, 8:02 PM
ginsu committed rCOMM1ee876eefe7e: [lib] introduce addCommunityActionType (authored by ginsu).
[lib] introduce addCommunityActionType
Tue, Feb 27, 8:02 PM
ginsu closed D11164: [sqlite] implement processing community store ops on worker.
Tue, Feb 27, 8:02 PM
ginsu committed rCOMMbe85d5c7b530: [sqlite] implement processing community store ops on worker (authored by ginsu).
[sqlite] implement processing community store ops on worker
Tue, Feb 27, 8:02 PM
ginsu closed D11153: [sqlite] implement c++ code to get communities.
Tue, Feb 27, 8:02 PM
ginsu closed D11151: [sqlite] add methods to operate on communities table.
Tue, Feb 27, 8:02 PM
ginsu committed rCOMMb1f35f4bd8e6: [sqlite] implement c++ code to get communities (authored by ginsu).
[sqlite] implement c++ code to get communities
Tue, Feb 27, 8:02 PM
ginsu closed D11152: [sqlite] implement C++ community store ops.
Tue, Feb 27, 8:02 PM
ginsu committed rCOMM571ae32fcd45: [sqlite] implement C++ community store ops (authored by ginsu).
[sqlite] implement C++ community store ops
Tue, Feb 27, 8:02 PM
ginsu committed rCOMM68a6672a3569: [sqlite] add methods to operate on communities table (authored by ginsu).
[sqlite] add methods to operate on communities table
Tue, Feb 27, 8:02 PM
ginsu closed D11087: [sqlite] add communites table for community store data.
Tue, Feb 27, 8:02 PM
ginsu committed rCOMM5d3f1a74764f: [sqlite] add communites table for community store data (authored by ginsu).
[sqlite] add communites table for community store data
Tue, Feb 27, 8:02 PM
ginsu updated the diff for D11165: [lib] introduce addCommunityActionType.

rebase before landing

Tue, Feb 27, 7:40 PM
ginsu updated the diff for D11164: [sqlite] implement processing community store ops on worker.

rebase before landing

Tue, Feb 27, 7:39 PM
ginsu updated the diff for D11153: [sqlite] implement c++ code to get communities.

rebase before landing

Tue, Feb 27, 7:38 PM
ginsu updated the diff for D11153: [sqlite] implement c++ code to get communities.

rebase before landing

Tue, Feb 27, 7:37 PM
ginsu updated the diff for D11152: [sqlite] implement C++ community store ops.

rebase before landing

Tue, Feb 27, 7:36 PM
ginsu added a comment to D11153: [sqlite] implement c++ code to get communities.

it will be nice to make the testing process more transparent

Tue, Feb 27, 7:35 PM
ginsu updated the test plan for D11153: [sqlite] implement c++ code to get communities.
Tue, Feb 27, 7:35 PM
ginsu added a comment to D11152: [sqlite] implement C++ community store ops.

it would be great if you could respond and update the test plan

Tue, Feb 27, 7:30 PM
ginsu updated the test plan for D11152: [sqlite] implement C++ community store ops.
Tue, Feb 27, 7:30 PM
ginsu updated the test plan for D11152: [sqlite] implement C++ community store ops.
Tue, Feb 27, 7:30 PM
ginsu updated the diff for D11151: [sqlite] add methods to operate on communities table.

rebase before landing

Tue, Feb 27, 7:19 PM
ginsu updated the diff for D11087: [sqlite] add communites table for community store data.

rebase before landing

Tue, Feb 27, 7:17 PM

Mon, Feb 26

ginsu requested review of D11159: [DO NOT LAND][web] add @neynar/nodejs-sdk dep.
Mon, Feb 26, 2:24 PM
ginsu requested review of D11167: [lib] populate community store on user login.

will make sure ci passes before landing

Mon, Feb 26, 1:13 AM
ginsu requested review of D11166: [lib] introduce community reducer.

will make sure ci passes before landing

Mon, Feb 26, 1:13 AM
ginsu requested review of D11165: [lib] introduce addCommunityActionType.

will make sure ci passes before landing

Mon, Feb 26, 1:08 AM
ginsu published D11164: [sqlite] implement processing community store ops on worker for review.

will make sure ci passes before landing

Mon, Feb 26, 1:08 AM

Fri, Feb 23

ginsu updated the diff for D11151: [sqlite] add methods to operate on communities table.

address feedback

Fri, Feb 23, 5:16 PM
ginsu requested review of D11153: [sqlite] implement c++ code to get communities.

will make sure ci passes before landing

Fri, Feb 23, 12:43 AM
ginsu updated the diff for D11152: [sqlite] implement C++ community store ops.

update

Fri, Feb 23, 12:33 AM
ginsu updated the summary of D11152: [sqlite] implement C++ community store ops.
Fri, Feb 23, 12:27 AM
ginsu requested review of D11151: [sqlite] add methods to operate on communities table.
Fri, Feb 23, 12:19 AM
ginsu requested review of D11152: [sqlite] implement C++ community store ops.
Fri, Feb 23, 12:18 AM

Thu, Feb 22

ginsu updated the diff for D11087: [sqlite] add communites table for community store data.

fix merge conflict with .wasm file

Thu, Feb 22, 2:06 PM

Tue, Feb 20

ginsu closed D10572: [web] introduce light mode to thread notifications modal.
Tue, Feb 20, 11:11 PM
ginsu committed rCOMMee2fa75c836e: [web] introduce light mode to thread notifications modal (authored by ginsu).
[web] introduce light mode to thread notifications modal
Tue, Feb 20, 11:11 PM
ginsu closed D10570: [web] introduce light mode to confirm leave thread modal.
Tue, Feb 20, 11:11 PM
ginsu committed rCOMMd3f8d846c067: [web] introduce light mode to confirm leave thread modal (authored by ginsu).
[web] introduce light mode to confirm leave thread modal
Tue, Feb 20, 11:11 PM
ginsu updated the diff for D10572: [web] introduce light mode to thread notifications modal.

rebase before landing

Tue, Feb 20, 10:26 PM
ginsu added a comment to D10572: [web] introduce light mode to thread notifications modal.

Hm, radio button doesn't have much contrast when selected. Guessing that component will get updated later as part of this work?

Tue, Feb 20, 10:26 PM
ginsu updated the diff for D10570: [web] introduce light mode to confirm leave thread modal.

rebase before landing

Tue, Feb 20, 10:20 PM
ginsu added a comment to D10570: [web] introduce light mode to confirm leave thread modal.

Several things look weird about this modal:

  1. The "Are you sure" line isn't aligned, neither with the icon nor with the header text
  2. The spacing between the "Are you sure" line and the one above seems too light given the spacing elsewhere
  3. It doesn't have a separation between the button area and the text area. I thought Ted's most recent designs for modals introduced this, but I'm not sure if it was meant to apply universally or not

Not sure this diff is meant to address any of this. Feel free to land without addressing, but in that case please link a relevant Linear issue that explicitly mentions all of the above before landing

Tue, Feb 20, 10:19 PM
ginsu abandoned D10571: [web] introduce light mode to sidebar promote modal.

D10276 makes this diff obsolete

Tue, Feb 20, 9:11 PM

Fri, Feb 16

ginsu added a comment to D11087: [sqlite] add communites table for community store data.

Looks good, two nits:

  1. The file from the test plan is not visible
  2. Can you also check if it works on the web? Logs on the worker are enough - here is how you can access them
Fri, Feb 16, 12:40 PM
ginsu attached a referenced file: F1166566: Screenshot 2024-02-16 at 3.39.19 PM.png.
Fri, Feb 16, 12:40 PM
ginsu updated the test plan for D11087: [sqlite] add communites table for community store data.
Fri, Feb 16, 12:40 PM
ginsu attached a referenced file: F1164684: Screenshot 2024-02-15 at 5.04.59 PM.png.
Fri, Feb 16, 12:30 PM

Thu, Feb 15

ginsu requested review of D11087: [sqlite] add communites table for community store data.
Thu, Feb 15, 2:28 PM
ginsu closed D11069: [web] cleanup members modal.
Thu, Feb 15, 4:26 AM
ginsu committed rCOMM3e8dfacf7781: [web] cleanup members modal (authored by ginsu).
[web] cleanup members modal
Thu, Feb 15, 4:26 AM
ginsu closed D11067: [web] remove deprecated members modals code.
Thu, Feb 15, 4:26 AM
ginsu closed D11068: [web] cleanup user list modals.
Thu, Feb 15, 4:26 AM
ginsu closed D11066: [web] cleanup compose subchannel modal.
Thu, Feb 15, 4:26 AM
ginsu committed rCOMM0b5afdd1f622: [web] cleanup user list modals (authored by ginsu).
[web] cleanup user list modals
Thu, Feb 15, 4:26 AM
ginsu committed rCOMM8cc1ac138075: [web] remove deprecated members modals code (authored by ginsu).
[web] remove deprecated members modals code
Thu, Feb 15, 4:26 AM
ginsu committed rCOMMb4d6a33e84b0: [web] cleanup compose subchannel modal (authored by ginsu).
[web] cleanup compose subchannel modal
Thu, Feb 15, 4:26 AM
ginsu closed D11065: [web] use AddUsersList in SubchannelMembers.
Thu, Feb 15, 4:26 AM
ginsu committed rCOMM81790dae5333: [web] use AddUsersList in SubchannelMembers (authored by ginsu).
[web] use AddUsersList in SubchannelMembers
Thu, Feb 15, 4:26 AM
ginsu closed D10994: [web] cleanup change member role modal.
Thu, Feb 15, 4:26 AM
ginsu closed D11064: [web] cleanup create roles modal.
Thu, Feb 15, 4:26 AM
ginsu committed rCOMMdd294640b92d: [web] cleanup change member role modal (authored by ginsu).
[web] cleanup change member role modal
Thu, Feb 15, 4:26 AM
ginsu closed D11063: [web] cleanup enum option component when there is no icon.
Thu, Feb 15, 4:26 AM
ginsu committed rCOMM8649bf6fd93a: [web] cleanup create roles modal (authored by ginsu).
[web] cleanup create roles modal
Thu, Feb 15, 4:26 AM
ginsu closed D11035: [web] reintroduce error message to thread settings modal.
Thu, Feb 15, 4:26 AM
ginsu committed rCOMM5a837285d13d: [web] cleanup enum option component when there is no icon (authored by ginsu).
[web] cleanup enum option component when there is no icon
Thu, Feb 15, 4:26 AM
ginsu closed D11034: [web] cleanup thread settings general + privacy tabs.
Thu, Feb 15, 4:26 AM
ginsu committed rCOMMd8a26aec9621: [web] reintroduce error message to thread settings modal (authored by ginsu).
[web] reintroduce error message to thread settings modal
Thu, Feb 15, 4:26 AM
ginsu committed rCOMMf6fc837d607e: [web] cleanup thread settings general + privacy tabs (authored by ginsu).
[web] cleanup thread settings general + privacy tabs
Thu, Feb 15, 4:26 AM
ginsu closed D11033: [web] cleanup thread settings relationship tab.
Thu, Feb 15, 4:26 AM
ginsu committed rCOMMe99258c6d643: [web] cleanup thread settings relationship tab (authored by ginsu).
[web] cleanup thread settings relationship tab
Thu, Feb 15, 4:26 AM
ginsu closed D11032: [web] cleanup thread settings modal delete tab.
Thu, Feb 15, 4:26 AM
ginsu committed rCOMMdd4ec081e9c8: [web] cleanup thread settings modal delete tab (authored by ginsu).
[web] cleanup thread settings modal delete tab
Thu, Feb 15, 4:26 AM
ginsu updated the diff for D11069: [web] cleanup members modal.

rebase before landing

Thu, Feb 15, 4:23 AM
ginsu updated the diff for D11068: [web] cleanup user list modals.

rebase before landing

Thu, Feb 15, 4:22 AM
ginsu updated the diff for D11067: [web] remove deprecated members modals code.

rebase before landing

Thu, Feb 15, 4:22 AM
ginsu updated the diff for D11066: [web] cleanup compose subchannel modal.

rebase before landing

Thu, Feb 15, 4:21 AM
ginsu added inline comments to D11066: [web] cleanup compose subchannel modal.
Thu, Feb 15, 4:20 AM
ginsu updated the diff for D11065: [web] use AddUsersList in SubchannelMembers.

address feedback + rebase before landing

Thu, Feb 15, 4:18 AM
ginsu updated the diff for D10994: [web] cleanup change member role modal.

address comments + rebase before landing

Thu, Feb 15, 4:14 AM
ginsu added inline comments to D10994: [web] cleanup change member role modal.
Thu, Feb 15, 4:11 AM
ginsu updated the diff for D11064: [web] cleanup create roles modal.

rebase before landing

Thu, Feb 15, 4:10 AM
ginsu updated the diff for D11063: [web] cleanup enum option component when there is no icon.

address feedback + rebase before landing

Thu, Feb 15, 4:09 AM
ginsu updated the diff for D11035: [web] reintroduce error message to thread settings modal.

rebase before landing

Thu, Feb 15, 4:06 AM
ginsu updated the diff for D11034: [web] cleanup thread settings general + privacy tabs.

rebase before landing

Thu, Feb 15, 4:05 AM
ginsu added a comment to D11034: [web] cleanup thread settings general + privacy tabs.

Can you make sure removing form doesn't affect functionality?

Thu, Feb 15, 4:05 AM
ginsu updated the diff for D11033: [web] cleanup thread settings relationship tab.

rebase before landing

Thu, Feb 15, 4:04 AM
ginsu updated the diff for D11032: [web] cleanup thread settings modal delete tab.

rebase before landing

Thu, Feb 15, 4:03 AM
ginsu closed D11031: [web] introduce thread settings utils.
Thu, Feb 15, 2:26 AM