User Details
User Details
- User Since
- Aug 23 2022, 10:29 AM (56 w, 4 d)
Yesterday
Yesterday
ginsu requested review of D9271: [native] improve organization of user profiles work.
ginsu updated the summary of D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.
ginsu planned changes to D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.
changing stack order/will need to rebase
ginsu attached a referenced file: F770513: Screenshot 2023-09-22 at 4.34.33 PM.png.
ginsu updated the summary of D9252: [native] introduce UserProfileMessageButton.
ginsu attached a referenced file: F770483: Screenshot 2023-09-22 at 4.25.11 PM.png.
ginsu updated the summary of D9258: [native] introduce UserProfileRelationshipButton.
ginsu attached a referenced file: F770478: Screenshot 2023-09-22 at 4.15.11 PM.png.
ginsu updated the test plan for D9258: [native] introduce UserProfileRelationshipButton.
ginsu added inline comments to D9258: [native] introduce UserProfileRelationshipButton.
ginsu updated the diff for D9258: [native] introduce UserProfileRelationshipButton.
rebase
ginsu attached a referenced file: F770444: Screenshot 2023-09-22 at 4.15.11 PM.png.
ginsu updated the test plan for D9252: [native] introduce UserProfileMessageButton.
ginsu added inline comments to D9252: [native] introduce UserProfileMessageButton.
ginsu updated the diff for D9252: [native] introduce UserProfileMessageButton.
we should also not show message button if the user and/or viewer is blocked
Thu, Sep 21
Thu, Sep 21
ginsu updated the diff for D9258: [native] introduce UserProfileRelationshipButton.
fix icon
ginsu committed rCOMM9e4fe445626b: [lib] introduce threadInfosSelectorForThreadType selector (authored by ginsu).
[lib] introduce threadInfosSelectorForThreadType selector
ginsu committed rCOMM37a9f269f73e: [lib] introduce createPendingPersonalThread function (authored by ginsu).
[lib] introduce createPendingPersonalThread function
ginsu updated the diff for D9204: [lib] introduce threadInfosSelectorForThreadType selector.
rebase before landing
ginsu updated the diff for D9235: [lib] introduce createPendingPersonalThread function.
rebase before landing
ginsu committed rCOMM0bdf8c8da1a4: [nix] add logs to console while waiting for MariaDB to come up (authored by ginsu).
[nix] add logs to console while waiting for MariaDB to come up
ginsu requested review of D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.
ginsu updated the summary of D9260: [native] improve BottomSheet component close function.
ginsu requested review of D9260: [native] improve BottomSheet component close function.
ginsu attached a referenced file: F769080: Screenshot 2023-09-21 at 2.03.59 PM.png.
ginsu attached a referenced file: F769081: Screenshot 2023-09-21 at 2.02.28 PM.png.
ginsu attached a referenced file: F769082: Screenshot 2023-09-21 at 2.04.07 PM.png.
ginsu attached a referenced file: F769112: Screen Recording 2023-09-21 at 2.10.10 PM.mov.
ginsu attached a referenced file: F769113: Screen Recording 2023-09-21 at 2.11.46 PM.mov.
ginsu attached a referenced file: F769117: Screenshot 2023-09-20 at 4.49.07 PM.png.
ginsu updated the test plan for D9258: [native] introduce UserProfileRelationshipButton.
ginsu updated subscribers of D9258: [native] introduce UserProfileRelationshipButton.
ginsu requested review of D9258: [native] introduce UserProfileRelationshipButton.
ginsu requested review of D9235: [lib] introduce createPendingPersonalThread function.
ginsu updated the diff for D9223: [nix] add logs to console while waiting for MariaDB to come up.
simplify/address comments
[web] introduce AppearanceChangeModal
ginsu committed rCOMM10935364caf9: [native] update UserProfileBottomSheet to get a userInfo from a userID (authored by ginsu).
[native] update UserProfileBottomSheet to get a userInfo from a userID
Wed, Sep 20
Wed, Sep 20
ginsu updated the diff for D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.
rebase before landing
ginsu updated the diff for D9203: [web] introduce AppearanceChangeModal.
rebase before landing
ginsu updated the diff for D9223: [nix] add logs to console while waiting for MariaDB to come up.
address @atul's comments
ginsu requested review of D9252: [native] introduce UserProfileMessageButton.
ginsu requested review of D9204: [lib] introduce threadInfosSelectorForThreadType selector.
ginsu added a comment to D9204: [lib] introduce threadInfosSelectorForThreadType selector.
D9235 factors out the logic in the search experience for creating a "pending" thread if that thread doesn't exist yet. This logic will be shared between the search experience and the user profiles experience.
ginsu requested review of D9247: [lib] introduce useUserProfileThreadInfo hook.
ginsu attached a referenced file: F767708: Screenshot 2023-09-20 at 1.10.51 PM.png.
ginsu attached a referenced file: F767831: Screen Recording 2023-09-20 at 2.32.13 PM.mov.
ginsu updated the test plan for D9247: [lib] introduce useUserProfileThreadInfo hook.
ginsu added inline comments to D9247: [lib] introduce useUserProfileThreadInfo hook.
ginsu updated the summary of D9204: [lib] introduce threadInfosSelectorForThreadType selector.
ginsu updated the summary of D9235: [lib] introduce createPendingPersonalThread function.
ginsu planned changes to D9247: [lib] introduce useUserProfileThreadInfo hook.
still need to write some comments + update test plan (will rerequest review when finished with that)
ginsu requested review of D9247: [lib] introduce useUserProfileThreadInfo hook.
ginsu updated the diff for D9235: [lib] introduce createPendingPersonalThread function.
remove export
Tue, Sep 19
Tue, Sep 19
ginsu updated the diff for D9235: [lib] introduce createPendingPersonalThread function.
simplify
ginsu updated the summary of D9235: [lib] introduce createPendingPersonalThread function.
ginsu requested review of D9235: [lib] introduce createPendingPersonalThread function.
Mon, Sep 18
Mon, Sep 18
ginsu updated the diff for D9223: [nix] add logs to console while waiting for MariaDB to come up.
add capitalization
ginsu updated the diff for D9223: [nix] add logs to console while waiting for MariaDB to come up.
address comments
ginsu added inline comments to D9203: [web] introduce AppearanceChangeModal.
ginsu updated the diff for D9203: [web] introduce AppearanceChangeModal.
address @atul's feedback
ginsu requested review of D9223: [nix] add logs to console while waiting for MariaDB to come up.
ginsu added a comment to D9204: [lib] introduce threadInfosSelectorForThreadType selector.
How does the code for search results currently handle this?
Thu, Sep 14
Thu, Sep 14
ginsu added inline comments to D9205: [native] Introduce naive `ChatThreadListSearch` component.
accepting, but please take a look at the inline comments
ginsu attached a referenced file: F759614: Screenshot 2023-09-14 at 2.04.17 PM.png.
ginsu updated the summary of D9204: [lib] introduce threadInfosSelectorForThreadType selector.
ginsu requested review of D9204: [lib] introduce threadInfosSelectorForThreadType selector.
ginsu added inline comments to D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.
ginsu attached a referenced file: F759554: Screen Recording 2023-09-14 at 1.00.25 PM.mov.
ginsu updated the test plan for D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.
ginsu updated the diff for D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.
address feedback
ginsu requested review of D9203: [web] introduce AppearanceChangeModal.
ginsu resigned from D9202: [keyserver/web/native] Covert AES-256 key from Uint8Array representation to hex string representation.
Code looks good to me, but resigning to give others a chance to review
ginsu committed rCOMMe14ab1b818cb: [web] introduce preferences settings in account settings (authored by ginsu).
[web] introduce preferences settings in account settings
[web] introduce useStaffCanSee hook for web
ginsu committed rCOMM1f06786df4ed: [lib/native] lift useIsCurrentUserStaff hook into lib (authored by ginsu).
[lib/native] lift useIsCurrentUserStaff hook into lib
ginsu updated the diff for D9195: [web] introduce preferences settings in account settings.
address feedback
ginsu added a comment to D9194: [web] introduce useStaffCanSee hook for web.
Seems reasonable, does it make sense to preemptively just put this in lib as well though like useIsCurrentUserStaff
Wed, Sep 13
Wed, Sep 13
ginsu committed rCOMMdf8e1881cd14: [native] use stringForUserExplicit function to determine username text for… (authored by ginsu).
[native] use stringForUserExplicit function to determine username text for…
ginsu requested review of D9195: [web] introduce preferences settings in account settings.
ginsu requested review of D9194: [web] introduce useStaffCanSee hook for web.
ginsu requested review of D9193: [lib/native] lift useIsCurrentUserStaff hook into lib.
Seems reasonable, but not super familiar with the requirements
One question inline