Page MenuHomePhabricator

ginsu (Ginsu Eddy)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 23 2022, 10:29 AM (56 w, 4 d)

Recent Activity

Yesterday

ginsu requested review of D9271: [native] improve organization of user profiles work.
Fri, Sep 22, 2:22 PM
ginsu updated the summary of D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.
Fri, Sep 22, 2:07 PM
ginsu planned changes to D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.

changing stack order/will need to rebase

Fri, Sep 22, 1:43 PM
ginsu attached a referenced file: F770513: Screenshot 2023-09-22 at 4.34.33 PM.png.
Fri, Sep 22, 1:36 PM
ginsu updated the summary of D9252: [native] introduce UserProfileMessageButton.
Fri, Sep 22, 1:35 PM
ginsu attached a referenced file: F770483: Screenshot 2023-09-22 at 4.25.11 PM.png.
Fri, Sep 22, 1:33 PM
ginsu updated the summary of D9258: [native] introduce UserProfileRelationshipButton.
Fri, Sep 22, 1:33 PM
ginsu attached a referenced file: F770478: Screenshot 2023-09-22 at 4.15.11 PM.png.
Fri, Sep 22, 1:23 PM
ginsu updated the test plan for D9258: [native] introduce UserProfileRelationshipButton.
Fri, Sep 22, 1:23 PM
ginsu added inline comments to D9258: [native] introduce UserProfileRelationshipButton.
Fri, Sep 22, 1:22 PM
ginsu updated the diff for D9258: [native] introduce UserProfileRelationshipButton.

rebase

Fri, Sep 22, 1:17 PM
ginsu attached a referenced file: F770444: Screenshot 2023-09-22 at 4.15.11 PM.png.
Fri, Sep 22, 1:16 PM
ginsu updated the test plan for D9252: [native] introduce UserProfileMessageButton.
Fri, Sep 22, 1:15 PM
ginsu added inline comments to D9252: [native] introduce UserProfileMessageButton.
Fri, Sep 22, 1:14 PM
ginsu updated the diff for D9252: [native] introduce UserProfileMessageButton.

we should also not show message button if the user and/or viewer is blocked

Fri, Sep 22, 1:12 PM

Thu, Sep 21

ginsu updated the diff for D9258: [native] introduce UserProfileRelationshipButton.

fix icon

Thu, Sep 21, 8:43 PM
ginsu closed D9204: [lib] introduce threadInfosSelectorForThreadType selector.
Thu, Sep 21, 1:45 PM
ginsu committed rCOMM9e4fe445626b: [lib] introduce threadInfosSelectorForThreadType selector (authored by ginsu).
[lib] introduce threadInfosSelectorForThreadType selector
Thu, Sep 21, 1:45 PM
ginsu closed D9235: [lib] introduce createPendingPersonalThread function.
Thu, Sep 21, 1:45 PM
ginsu committed rCOMM37a9f269f73e: [lib] introduce createPendingPersonalThread function (authored by ginsu).
[lib] introduce createPendingPersonalThread function
Thu, Sep 21, 1:45 PM
ginsu updated the diff for D9204: [lib] introduce threadInfosSelectorForThreadType selector.

rebase before landing

Thu, Sep 21, 1:42 PM
ginsu updated the diff for D9235: [lib] introduce createPendingPersonalThread function.

rebase before landing

Thu, Sep 21, 1:41 PM
ginsu closed D9223: [nix] add logs to console while waiting for MariaDB to come up.
Thu, Sep 21, 1:37 PM
ginsu committed rCOMM0bdf8c8da1a4: [nix] add logs to console while waiting for MariaDB to come up (authored by ginsu).
[nix] add logs to console while waiting for MariaDB to come up
Thu, Sep 21, 1:37 PM
ginsu requested review of D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.
Thu, Sep 21, 12:18 PM
ginsu updated the summary of D9260: [native] improve BottomSheet component close function.
Thu, Sep 21, 12:00 PM
ginsu requested review of D9260: [native] improve BottomSheet component close function.
Thu, Sep 21, 11:45 AM
ginsu attached a referenced file: F769080: Screenshot 2023-09-21 at 2.03.59 PM.png.
Thu, Sep 21, 11:15 AM
ginsu attached a referenced file: F769081: Screenshot 2023-09-21 at 2.02.28 PM.png.
Thu, Sep 21, 11:15 AM
ginsu attached a referenced file: F769082: Screenshot 2023-09-21 at 2.04.07 PM.png.
Thu, Sep 21, 11:15 AM
ginsu attached a referenced file: F769112: Screen Recording 2023-09-21 at 2.10.10 PM.mov.
Thu, Sep 21, 11:15 AM
ginsu attached a referenced file: F769113: Screen Recording 2023-09-21 at 2.11.46 PM.mov.
Thu, Sep 21, 11:15 AM
ginsu attached a referenced file: F769117: Screenshot 2023-09-20 at 4.49.07 PM.png.
Thu, Sep 21, 11:15 AM
ginsu updated the test plan for D9258: [native] introduce UserProfileRelationshipButton.
Thu, Sep 21, 11:15 AM
ginsu updated subscribers of D9258: [native] introduce UserProfileRelationshipButton.
Thu, Sep 21, 11:14 AM
ginsu requested review of D9258: [native] introduce UserProfileRelationshipButton.
Thu, Sep 21, 11:14 AM
ginsu requested review of D9235: [lib] introduce createPendingPersonalThread function.
Thu, Sep 21, 10:41 AM
ginsu updated the diff for D9223: [nix] add logs to console while waiting for MariaDB to come up.

simplify/address comments

Thu, Sep 21, 10:07 AM
ginsu closed D9203: [web] introduce AppearanceChangeModal.
Thu, Sep 21, 9:52 AM
ginsu committed rCOMM57caceed7b27: [web] introduce AppearanceChangeModal (authored by ginsu).
[web] introduce AppearanceChangeModal
Thu, Sep 21, 9:52 AM
ginsu closed D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.
Thu, Sep 21, 9:51 AM
ginsu committed rCOMM10935364caf9: [native] update UserProfileBottomSheet to get a userInfo from a userID (authored by ginsu).
[native] update UserProfileBottomSheet to get a userInfo from a userID
Thu, Sep 21, 9:51 AM

Wed, Sep 20

ginsu updated the diff for D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.

rebase before landing

Wed, Sep 20, 2:09 PM
ginsu updated the diff for D9203: [web] introduce AppearanceChangeModal.

rebase before landing

Wed, Sep 20, 2:07 PM
ginsu updated the diff for D9223: [nix] add logs to console while waiting for MariaDB to come up.

address @atul's comments

Wed, Sep 20, 2:05 PM
ginsu requested review of D9252: [native] introduce UserProfileMessageButton.
Wed, Sep 20, 2:02 PM
ginsu accepted D9250: [keyserver] Increase timeout for getInitialReduxState.
Wed, Sep 20, 1:20 PM
ginsu requested review of D9204: [lib] introduce threadInfosSelectorForThreadType selector.
Wed, Sep 20, 12:12 PM
ginsu added a comment to D9204: [lib] introduce threadInfosSelectorForThreadType selector.

D9235 factors out the logic in the search experience for creating a "pending" thread if that thread doesn't exist yet. This logic will be shared between the search experience and the user profiles experience.

Wed, Sep 20, 12:12 PM
ginsu requested review of D9247: [lib] introduce useUserProfileThreadInfo hook.
Wed, Sep 20, 11:34 AM
ginsu attached a referenced file: F767708: Screenshot 2023-09-20 at 1.10.51 PM.png.
Wed, Sep 20, 11:34 AM
ginsu attached a referenced file: F767831: Screen Recording 2023-09-20 at 2.32.13 PM.mov.
Wed, Sep 20, 11:34 AM
ginsu updated the test plan for D9247: [lib] introduce useUserProfileThreadInfo hook.
Wed, Sep 20, 11:34 AM
ginsu added inline comments to D9247: [lib] introduce useUserProfileThreadInfo hook.
Wed, Sep 20, 10:24 AM
ginsu updated the summary of D9204: [lib] introduce threadInfosSelectorForThreadType selector.
Wed, Sep 20, 10:07 AM
ginsu updated the summary of D9235: [lib] introduce createPendingPersonalThread function.
Wed, Sep 20, 10:07 AM
ginsu planned changes to D9247: [lib] introduce useUserProfileThreadInfo hook.

still need to write some comments + update test plan (will rerequest review when finished with that)

Wed, Sep 20, 9:48 AM
ginsu requested review of D9247: [lib] introduce useUserProfileThreadInfo hook.
Wed, Sep 20, 9:47 AM
ginsu updated the diff for D9235: [lib] introduce createPendingPersonalThread function.

remove export

Wed, Sep 20, 9:20 AM

Tue, Sep 19

ginsu updated the diff for D9235: [lib] introduce createPendingPersonalThread function.

simplify

Tue, Sep 19, 3:37 PM
ginsu updated the summary of D9235: [lib] introduce createPendingPersonalThread function.
Tue, Sep 19, 3:30 PM
ginsu requested review of D9235: [lib] introduce createPendingPersonalThread function.
Tue, Sep 19, 3:27 PM

Mon, Sep 18

ginsu updated the diff for D9223: [nix] add logs to console while waiting for MariaDB to come up.

add capitalization

Mon, Sep 18, 3:30 PM
ginsu updated the diff for D9223: [nix] add logs to console while waiting for MariaDB to come up.

address comments

Mon, Sep 18, 3:27 PM
ginsu added inline comments to D9203: [web] introduce AppearanceChangeModal.
Mon, Sep 18, 3:22 PM
ginsu updated the diff for D9203: [web] introduce AppearanceChangeModal.

address @atul's feedback

Mon, Sep 18, 3:19 PM
ginsu requested review of D9223: [nix] add logs to console while waiting for MariaDB to come up.
Mon, Sep 18, 2:20 PM
ginsu accepted D9221: [web] Fix capitalization of roles modal.
Mon, Sep 18, 1:30 PM
ginsu added a comment to D9204: [lib] introduce threadInfosSelectorForThreadType selector.

How does the code for search results currently handle this?

Mon, Sep 18, 6:28 AM

Thu, Sep 14

ginsu added inline comments to D9205: [native] Introduce naive `ChatThreadListSearch` component.
Thu, Sep 14, 1:46 PM
ginsu accepted D9205: [native] Introduce naive `ChatThreadListSearch` component.

accepting, but please take a look at the inline comments

Thu, Sep 14, 1:10 PM
ginsu attached a referenced file: F759614: Screenshot 2023-09-14 at 2.04.17 PM.png.
Thu, Sep 14, 11:09 AM
ginsu updated the summary of D9204: [lib] introduce threadInfosSelectorForThreadType selector.
Thu, Sep 14, 11:07 AM
ginsu requested review of D9204: [lib] introduce threadInfosSelectorForThreadType selector.
Thu, Sep 14, 10:48 AM
ginsu added inline comments to D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.
Thu, Sep 14, 10:05 AM
ginsu attached a referenced file: F759554: Screen Recording 2023-09-14 at 1.00.25 PM.mov.
Thu, Sep 14, 10:03 AM
ginsu updated the test plan for D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.
Thu, Sep 14, 10:03 AM
ginsu updated the diff for D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.

address feedback

Thu, Sep 14, 10:01 AM
ginsu requested review of D9203: [web] introduce AppearanceChangeModal.
Thu, Sep 14, 9:23 AM
ginsu resigned from D9202: [keyserver/web/native] Covert AES-256 key from Uint8Array representation to hex string representation.

Code looks good to me, but resigning to give others a chance to review

Thu, Sep 14, 8:35 AM
ginsu closed D9195: [web] introduce preferences settings in account settings.
Thu, Sep 14, 8:29 AM
ginsu closed D9194: [web] introduce useStaffCanSee hook for web.
Thu, Sep 14, 8:29 AM
ginsu committed rCOMMe14ab1b818cb: [web] introduce preferences settings in account settings (authored by ginsu).
[web] introduce preferences settings in account settings
Thu, Sep 14, 8:29 AM
ginsu committed rCOMM00b30f802217: [web] introduce useStaffCanSee hook for web (authored by ginsu).
[web] introduce useStaffCanSee hook for web
Thu, Sep 14, 8:29 AM
ginsu closed D9193: [lib/native] lift useIsCurrentUserStaff hook into lib.
Thu, Sep 14, 8:29 AM
ginsu committed rCOMM1f06786df4ed: [lib/native] lift useIsCurrentUserStaff hook into lib (authored by ginsu).
[lib/native] lift useIsCurrentUserStaff hook into lib
Thu, Sep 14, 8:29 AM
ginsu updated the diff for D9195: [web] introduce preferences settings in account settings.

address feedback

Thu, Sep 14, 8:24 AM
ginsu added a comment to D9194: [web] introduce useStaffCanSee hook for web.

Seems reasonable, does it make sense to preemptively just put this in lib as well though like useIsCurrentUserStaff

Thu, Sep 14, 8:19 AM

Wed, Sep 13

ginsu closed D9119: [native] use stringForUserExplicit function to determine username text for profiles.
Wed, Sep 13, 3:02 PM
ginsu committed rCOMMdf8e1881cd14: [native] use stringForUserExplicit function to determine username text for… (authored by ginsu).
[native] use stringForUserExplicit function to determine username text for…
Wed, Sep 13, 3:02 PM
ginsu requested review of D9195: [web] introduce preferences settings in account settings.
Wed, Sep 13, 2:18 PM
ginsu requested review of D9194: [web] introduce useStaffCanSee hook for web.
Wed, Sep 13, 2:09 PM
ginsu requested review of D9193: [lib/native] lift useIsCurrentUserStaff hook into lib.
Wed, Sep 13, 1:59 PM
ginsu resigned from D9181: [keyserver] Generate an AES256 key (ephemeral) to encode.

Seems reasonable, but not super familiar with the requirements

Wed, Sep 13, 1:32 PM
ginsu accepted D9191: [native] Remove `ChatThreadList` class component.
Wed, Sep 13, 1:30 PM
ginsu accepted D9188: [native] Lift `onTabPress` to `ConnectedChatThreadList`.
Wed, Sep 13, 1:25 PM
ginsu accepted D9184: [native] Lift `FlatList` to `ConnectedChatThreadList`.

One question inline

Wed, Sep 13, 1:23 PM
ginsu accepted D9183: [native] Lift `floatingAction` to `ConnectedChatThreadList`.
Wed, Sep 13, 1:16 PM
ginsu accepted D9174: [native] Replace `listDataSelector` with `useMemo` in `ChatThreadList`.
Wed, Sep 13, 1:13 PM
ginsu accepted D9180: [keyserver] Print out a QR code to the terminal.
Wed, Sep 13, 9:52 AM