User Details
User Details
- User Since
- Aug 23 2022, 10:29 AM (86 w, 2 d)
Today
Today
[lib/web] fix error handling indirection
ginsu updated the diff for D11689: [lib/web] fix error handling indirection.
rebase before landing
ginsu updated the test plan for D11689: [lib/web] fix error handling indirection.
ginsu requested review of D11689: [lib/web] fix error handling indirection.
ginsu committed rCOMM409e47a1b60b: [native] introduce screen options to tag farcaster channel stack navigator (authored by ginsu).
[native] introduce screen options to tag farcaster channel stack navigator
ginsu added inline comments to D11683: [native] implement UI for selecting a farcaster channel.
ginsu added inline comments to D11683: [native] implement UI for selecting a farcaster channel.
ginsu added inline comments to D11683: [native] implement UI for selecting a farcaster channel.
ginsu committed rCOMMfa258611a1ef: [native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel… (authored by ginsu).
[native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel…
ginsu updated the diff for D11662: [native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel screen.
rebase before landing
ginsu committed rCOMMb9c03cdb74fb: [lib] introduce fetchFollowedFarcasterChannels to neynar client class (authored by ginsu).
[lib] introduce fetchFollowedFarcasterChannels to neynar client class
[lib] refine fetchFriendFIDs function
ginsu updated the diff for D11676: [lib] introduce fetchFollowedFarcasterChannels to neynar client class.
rebase before landing
ginsu updated the diff for D11675: [lib] refine fetchFriendFIDs function.
rebase before landing
Yesterday
Yesterday
ginsu requested review of D11683: [native] implement UI for selecting a farcaster channel.
ginsu requested review of D11682: [native] introduce screen options to tag farcaster channel stack navigator.
ginsu added inline comments to D11662: [native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel screen.
ginsu updated the diff for D11662: [native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel screen.
rebase
ginsu updated the diff for D11676: [lib] introduce fetchFollowedFarcasterChannels to neynar client class.
address comments
ginsu added inline comments to D11675: [lib] refine fetchFriendFIDs function.
ginsu updated the diff for D11675: [lib] refine fetchFriendFIDs function.
address comments
ginsu updated subscribers of D11662: [native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel screen.
ginsu updated the diff for D11662: [native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel screen.
address comments + update gating logic for showing tag farcaster channel to check fid is present as well
ginsu requested review of D11676: [lib] introduce fetchFollowedFarcasterChannels to neynar client class.
ginsu updated the summary of D11675: [lib] refine fetchFriendFIDs function.
ginsu requested review of D11675: [lib] refine fetchFriendFIDs function.
Mon, Apr 15
Mon, Apr 15
[native] fix copy in FarcasterPrompt
ginsu committed rCOMM0de3396b7379: [lib/native] introduce connect farcaster alert handler (authored by ginsu).
[lib/native] introduce connect farcaster alert handler
ginsu updated the diff for D11621: [native] fix copy in FarcasterPrompt.
rebase before landing
ginsu updated the diff for D11613: [lib/native] introduce connect farcaster alert handler.
rebase before landing
ginsu added a comment to D11613: [lib/native] introduce connect farcaster alert handler.
Code changes look good, would be good to make sure all other notes left by other reviewers are addressed/responded to before landing.
ginsu added inline comments to D11613: [lib/native] introduce connect farcaster alert handler.
ginsu added inline comments to D11662: [native] introduce barebones TagFarcasterChannelNavigator + TagFarcasterChannel screen.
Sun, Apr 14
Sun, Apr 14
Fri, Apr 12
Fri, Apr 12
would be good to get a screenshot to see the colors visually as a sanity check for the colors but the color variables follow our conventions
ginsu retitled D11613: [lib/native] introduce connect farcaster alert handler from [lib/native] introduce farcaster handler to [lib/native] introduce connect farcaster alert handler.
ginsu added inline comments to D11613: [lib/native] introduce connect farcaster alert handler.
ginsu updated the diff for D11613: [lib/native] introduce connect farcaster alert handler.
address comments
ginsu added inline comments to D11613: [lib/native] introduce connect farcaster alert handler.
Thu, Apr 11
Thu, Apr 11
ginsu added a comment to D11626: [lib] have landing send `fid` as a string and not a number.
thanks for catching this @will. I thought I addressed this but looking at connect-farcaster.react.js now I can see I accidentally only toString() the farcaster auth url. Would you mind updating this diff to remove the toString() for the auth url? It's typed as a string already so doesn't make sense to toString() a string
Wed, Apr 10
Wed, Apr 10
ginsu added inline comments to D11613: [lib/native] introduce connect farcaster alert handler.
ginsu added inline comments to D11613: [lib/native] introduce connect farcaster alert handler.
ginsu updated the diff for D11613: [lib/native] introduce connect farcaster alert handler.
update
ginsu committed rCOMMdbc17db48d23: [native/web] introduce migration to update notifPermissionAlertInfo to… (authored by ginsu).
[native/web] introduce migration to update notifPermissionAlertInfo to…
ginsu committed rCOMMc1de79d8d1b9: [lib/native/web] refactor recordNotifPermissionAlertActionType to… (authored by ginsu).
[lib/native/web] refactor recordNotifPermissionAlertActionType to…
ginsu committed rCOMM0435c3ab5f6e: [lib/native/web] introduce CONNECT_FARCASTER alert type (authored by ginsu).
[lib/native/web] introduce CONNECT_FARCASTER alert type
ginsu committed rCOMMa9c0d8c0fcc9: [lib/native/web] move recordNotifPermissionAlertActionType into seperate… (authored by ginsu).
[lib/native/web] move recordNotifPermissionAlertActionType into seperate…
ginsu committed rCOMM05921b8302a9: [lib/native/web] refactor notif permission alert info reducer (authored by ginsu).
[lib/native/web] refactor notif permission alert info reducer
ginsu updated the diff for D11601: [native/web] introduce migration to update notifPermissionAlertInfo to alertStore in redux.
rebase before landing
ginsu updated the diff for D11600: [lib/native/web] refactor recordNotifPermissionAlertActionType to recordAlertActionType.
rebase
ginsu updated the diff for D11599: [lib/native/web] move recordNotifPermissionAlertActionType into seperate actions file.
rebase
ginsu updated the diff for D11569: [lib/native/web] introduce CONNECT_FARCASTER alert type.
rebase + confirm ci passes
ginsu updated the diff for D11568: [lib/native/web] refactor notif permission alert info reducer.
rebase + confirm ci passes
ginsu attached a referenced file: F1511189: Screenshot 2024-04-10 at 3.28.26 PM.png.
ginsu added inline comments to D11600: [lib/native/web] refactor recordNotifPermissionAlertActionType to recordAlertActionType.
[lib/native/web] introduce alert types
ginsu committed rCOMMd7827e8b38e1: [native] handle successful connection from connect farcaster bottom sheet (authored by ginsu).
[native] handle successful connection from connect farcaster bottom sheet
ginsu committed rCOMM39cda6c1f115: [native] flip farcaster prompt based on fid prop instead of context (authored by ginsu).
[native] flip farcaster prompt based on fid prop instead of context
ginsu updated the diff for D11567: [lib/native/web] introduce alert types.
rebase before landing + make sure ci passes
ginsu updated the diff for D11598: [native] handle successful connection from connect farcaster bottom sheet.
address comments
ginsu added inline comments to D11598: [native] handle successful connection from connect farcaster bottom sheet.
ginsu requested review of D11621: [native] fix copy in FarcasterPrompt.
ginsu added inline comments to D11597: [native] flip farcaster prompt based on fid prop instead of context.
ginsu added inline comments to D11597: [native] flip farcaster prompt based on fid prop instead of context.
ginsu added a comment to D11484: [native] update FarcasterPrompt based on if the fid is set or not.
Tue, Apr 9
Tue, Apr 9
ginsu requested review of D11613: [lib/native] introduce connect farcaster alert handler.
will make sure ci passes before landing
ginsu requested review of D11600: [lib/native/web] refactor recordNotifPermissionAlertActionType to recordAlertActionType.
actually jk, I confused myself there is no bug with this diff
ginsu updated the summary of D11600: [lib/native/web] refactor recordNotifPermissionAlertActionType to recordAlertActionType.
ginsu planned changes to D11600: [lib/native/web] refactor recordNotifPermissionAlertActionType to recordAlertActionType.
found a bug
ginsu requested review of D11598: [native] handle successful connection from connect farcaster bottom sheet.
ginsu updated the summary of D11567: [lib/native/web] introduce alert types.
ginsu requested review of D11597: [native] flip farcaster prompt based on fid prop instead of context.
Sun, Apr 7
Sun, Apr 7
ginsu requested review of D11569: [lib/native/web] introduce CONNECT_FARCASTER alert type.
will make sure ci passes before landing
ginsu requested review of D11568: [lib/native/web] refactor notif permission alert info reducer.
will make sure ci passes before landing
ginsu requested review of D11567: [lib/native/web] introduce alert types.
will make sure ci passes before landing
Fri, Apr 5
Fri, Apr 5
seems reasonable, but want to make sure @kamil can also review this
Thu, Apr 4
Thu, Apr 4