[native] fix empty media gallery in thread settings
Needs ReviewPublic
Actions

Authored by ginsu on Thu, Jun 27, 12:28 AM.

Details

Reviewers

Summary

We had a bug in our thread settings where we would show ui elements for the media gallery even if no items were present. This diff fixes that

Linear task: https://linear.app/comm/issue/ENG-3301/[native]-empty-media-gallery-looks-out-of-place

Test Plan

Please see the demo video below

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Thu, Jun 27, 12:28 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Jun 27, 12:28 AM

ginsu edited the summary of this revision. (Show Details)Thu, Jun 27, 12:31 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added a reviewer: inka.

ginsu attached a referenced file: F2125153: Screen Recording 2024-06-26 at 5.54.53 PM.mov. (Show Details)

ginsu added inline comments.

native/chat/settings/thread-settings-media-gallery.react.js
34	This is optional because we use this component in other places where we don't want the "See more" button.

Harbormaster completed remote builds in B29946: Diff 41743.Thu, Jun 27, 12:45 AM

ginsu requested review of this revision.Thu, Jun 27, 12:45 AM

Revision Contents
Changeset List

Path

Size

native/

chat/

settings/

thread-settings-media-gallery.react.js

59 lines

thread-settings.react.js

15 lines

Diff 41743

View Options

native/chat/settings/thread-settings-media-gallery.react.js