[lib] make useJoinCommunity compatible with the auto join community handler
ClosedPublic
Actions

Authored by ginsu on Jul 10 2024, 6:27 AM.

Details

Reviewers

ashoat
inka

Commits

rCOMMc28089f95107: [lib] make useJoinCommunity compatible with the auto join community handler

Summary

This diff updates useJoinCommunity to be more agnostic so that this hook can be used for both invite links + auto join community handler

Depends on D12706

Test Plan

flow + confirmed that there were no regressions with the joining a community through accepitng an invite link user flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jul 10 2024, 6:27 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 10 2024, 6:27 AM

ginsu edited the summary of this revision. (Show Details)Jul 10 2024, 6:37 AM

ginsu added reviewers: ashoat, inka.

ginsu added a parent revision: D12706: [lib] introduce useJoinCommunity.

Harbormaster completed remote builds in B30256: Diff 42196.Jul 10 2024, 6:48 AM

ginsu requested review of this revision.Jul 10 2024, 6:48 AM

ginsu added a child revision: D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.Jul 10 2024, 9:10 AM

ashoat accepted this revision.Jul 10 2024, 5:56 PM

This revision is now accepted and ready to land.Jul 10 2024, 5:56 PM

update

Harbormaster completed remote builds in B30277: Diff 42219.Jul 11 2024, 7:13 AM

rebase before landing

This revision was landed with ongoing or failed builds.Jul 12 2024, 4:01 AM

Closed by commit rCOMMc28089f95107: [lib] make useJoinCommunity compatible with the auto join community handler. · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMc28089f95107: [lib] make useJoinCommunity compatible with the auto join community handler.

Harbormaster completed remote builds in B30297: Diff 42245.Jul 12 2024, 4:12 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

community-utils.js

23 lines

Diff 42247

View Options

lib/shared/community-utils.js

[lib] make useJoinCommunity compatible with the auto join community handlerClosedPublicActions