Page MenuHomePhabricator

[keyserver] include keyserver url in the farcaster channel tag blob
ClosedPublic

Authored by ginsu on Jul 9 2024, 12:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 29, 6:04 AM
Unknown Object (File)
Mon, Aug 19, 5:16 AM
Unknown Object (File)
Sat, Aug 17, 9:09 AM
Unknown Object (File)
Sat, Aug 10, 8:39 AM
Unknown Object (File)
Fri, Aug 9, 8:57 AM
Unknown Object (File)
Fri, Aug 9, 8:57 AM
Unknown Object (File)
Fri, Aug 9, 8:57 AM
Unknown Object (File)
Fri, Aug 9, 8:56 AM
Subscribers

Details

Summary

When we add + auth keyservers that are unknown we will need to make sure the keyserver url we are trying to auth + add is valid. To do this with the auto join community handler we will need to include the keyserver url in the farcaster channel tag blob payload so that we can validate it later.

Test Plan

Created a farcaster channel tag blob and logged out + confirmed that the keyserver url was present in the blob payload

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu added reviewers: ashoat, inka.
ginsu requested review of this revision.Jul 9 2024, 12:24 AM

Looking at uploadInviteLinkBlob, this appears to be the same thing we do there

This revision is now accepted and ready to land.Jul 9 2024, 10:35 AM