Page MenuHomePhabricator

[keyserver] include keyserver url in the farcaster channel tag blob
ClosedPublic

Authored by ginsu on Jul 9 2024, 12:07 AM.
Tags
None
Referenced Files
F3140533: D12702.diff
Sun, Nov 3, 4:48 AM
Unknown Object (File)
Mon, Oct 21, 7:40 AM
Unknown Object (File)
Fri, Oct 11, 11:16 PM
Unknown Object (File)
Fri, Oct 11, 3:31 AM
Unknown Object (File)
Fri, Oct 11, 3:31 AM
Unknown Object (File)
Fri, Oct 11, 3:31 AM
Unknown Object (File)
Fri, Oct 11, 3:31 AM
Unknown Object (File)
Fri, Oct 11, 3:31 AM
Subscribers

Details

Summary

When we add + auth keyservers that are unknown we will need to make sure the keyserver url we are trying to auth + add is valid. To do this with the auto join community handler we will need to include the keyserver url in the farcaster channel tag blob payload so that we can validate it later.

Test Plan

Created a farcaster channel tag blob and logged out + confirmed that the keyserver url was present in the blob payload

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu added reviewers: ashoat, inka.
ginsu requested review of this revision.Jul 9 2024, 12:24 AM

Looking at uploadInviteLinkBlob, this appears to be the same thing we do there

This revision is now accepted and ready to land.Jul 9 2024, 10:35 AM