Page MenuHomePhabricator

[web] introduce AutoJoinCommunityHandler to web
ClosedPublic

Authored by ginsu on Wed, Jul 10, 2:58 AM.
Tags
None
Referenced Files
F2321711: D12717.id42264.diff
Tue, Jul 23, 5:56 AM
Unknown Object (File)
Mon, Jul 22, 8:31 AM
Unknown Object (File)
Sun, Jul 21, 12:36 PM
Unknown Object (File)
Fri, Jul 19, 1:19 PM
Unknown Object (File)
Fri, Jul 19, 12:44 PM
Unknown Object (File)
Thu, Jul 18, 8:33 PM
Unknown Object (File)
Thu, Jul 18, 1:54 PM
Unknown Object (File)
Thu, Jul 18, 11:46 AM
Subscribers

Details

Summary

This diff simply introduces the version of AutoJoinCommunityHandler for web

Depends on D12716

Test Plan

Confirmed that the auto join community mechanism also works on web

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, inka.
ginsu requested review of this revision.Wed, Jul 10, 3:20 AM
ashoat added inline comments.
web/components/auto-join-community-handler.react.js
8 ↗(On Diff #42204)

What's nonThread mean here again? Exclusing sidebars?

This revision is now accepted and ready to land.Wed, Jul 10, 10:39 AM
web/components/auto-join-community-handler.react.js
8 ↗(On Diff #42204)

It seems like we are using this to filter out all the calendar filters with the type THREAD_LIST from an array of calendar filters.

So it looks like "nonThread" refers to any calendar query that are not related to threads

https://github.com/CommE2E/comm/blob/master/lib/selectors/calendar-filter-selectors.js#L36-L60

This revision was landed with ongoing or failed builds.Fri, Jul 12, 5:48 PM
This revision was automatically updated to reflect the committed changes.