Page MenuHomePhabricator
Differential D12717

[web] introduce AutoJoinCommunityHandler to web
ClosedPublic
Actions

Authored by ginsu on Jul 10 2024, 2:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 10:38 PM
Unknown Object (File)
Fri, Nov 22, 6:27 PM
Unknown Object (File)
Wed, Nov 20, 3:42 AM
Unknown Object (File)
Wed, Nov 20, 3:41 AM
Unknown Object (File)
Wed, Nov 20, 3:10 AM
Unknown Object (File)
Fri, Nov 8, 10:39 PM
Unknown Object (File)
Fri, Nov 8, 6:16 AM
Unknown Object (File)
Tue, Nov 5, 3:22 AM
View All 74 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
inka
Commits
rCOMM41181031c715: [web] introduce AutoJoinCommunityHandler to web
Summary

This diff simply introduces the version of AutoJoinCommunityHandler for web

Depends on D12716

Test Plan

Confirmed that the auto join community mechanism also works on web

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jul 10 2024, 2:58 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 10 2024, 2:58 AM
ginsu edited the summary of this revision. (Show Details)Jul 10 2024, 2:59 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, inka.
ginsu added a parent revision: D12716: [lib/native] lift auto join community handler to lib.
Harbormaster completed remote builds in B30263: Diff 42204.Jul 10 2024, 3:20 AM
ginsu requested review of this revision.Jul 10 2024, 3:20 AM
ginsu edited the summary of this revision. (Show Details)Jul 10 2024, 3:37 AM
ashoat accepted this revision.Jul 10 2024, 10:39 AM
ashoat added inline comments.
web/components/auto-join-community-handler.react.js
8

What's nonThread mean here again? Exclusing sidebars?

This revision is now accepted and ready to land.Jul 10 2024, 10:39 AM
ginsu added inline comments.Jul 12 2024, 5:46 PM
web/components/auto-join-community-handler.react.js
8

It seems like we are using this to filter out all the calendar filters with the type THREAD_LIST from an array of calendar filters.

So it looks like "nonThread" refers to any calendar query that are not related to threads

https://github.com/CommE2E/comm/blob/master/lib/selectors/calendar-filter-selectors.js#L36-L60

ginsu updated this revision to Diff 42264.Jul 12 2024, 5:47 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jul 12 2024, 5:48 PM
Closed by commit rCOMM41181031c715: [web] introduce AutoJoinCommunityHandler to web (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM41181031c715: [web] introduce AutoJoinCommunityHandler to web.
Harbormaster completed remote builds in B30307: Diff 42264.Jul 12 2024, 6:04 PM

Revision Contents
Changeset List

PathSize
web/
2 lines
components/
16 lines

Diff 42204

View Options

web/app.react.js

Loading...
View Options

web/components/auto-join-community-handler.react.js

Loading...