Page MenuHomePhabricator
Feed Advanced Search

Yesterday

ginsu updated the diff for D10145: [web] introduce light mode to create/edit role modal.

address comments

Mon, Dec 4, 11:52 PM
ginsu added a comment to D10144: [web] introduce light mode to community creation modal.

we should probably just continue to get a "minimally viable light mode" and then consider tweaking color values at that point?

Mon, Dec 4, 11:48 PM
ginsu attached a referenced file: F912123: Screenshot 2023-12-05 at 2.39.27 AM.png.
Mon, Dec 4, 11:42 PM
ginsu updated the test plan for D10144: [web] introduce light mode to community creation modal.
Mon, Dec 4, 11:42 PM
ginsu updated the diff for D10144: [web] introduce light mode to community creation modal.

address comments

Mon, Dec 4, 11:39 PM
ginsu closed D10154: [web] add keyserver url validation logic and error handling to the add keyserver modal.
Mon, Dec 4, 11:02 PM
ginsu committed rCOMMc9a676d83f82: [web] add keyserver url validation logic and error handling to the add… (authored by ginsu).
[web] add keyserver url validation logic and error handling to the add…
Mon, Dec 4, 11:02 PM
ginsu closed D10094: [web] implement onClickAddKeyserver callback.
Mon, Dec 4, 11:02 PM
ginsu closed D10093: [web] save the recently deleted server url to customServer redux state.
Mon, Dec 4, 11:02 PM
ginsu committed rCOMM7cfdb6216480: [web] implement onClickAddKeyserver callback (authored by ginsu).
[web] implement onClickAddKeyserver callback
Mon, Dec 4, 11:02 PM
ginsu committed rCOMM22222927772e: [web] save the recently deleted server url to customServer redux state (authored by ginsu).
[web] save the recently deleted server url to customServer redux state
Mon, Dec 4, 11:02 PM
ginsu closed D10092: [lib/native/web] lift customServer redux state into lib.
Mon, Dec 4, 11:02 PM
ginsu closed D10090: [lib/native] lift set custom server action type into lib.
Mon, Dec 4, 11:02 PM
ginsu committed rCOMM7797b12e0e16: [lib/native/web] lift customServer redux state into lib (authored by ginsu).
[lib/native/web] lift customServer redux state into lib
Mon, Dec 4, 11:02 PM
ginsu committed rCOMMf68ce52a93a2: [lib/native] lift set custom server action type into lib (authored by ginsu).
[lib/native] lift set custom server action type into lib
Mon, Dec 4, 11:02 PM
ginsu closed D9906: [native] save the recently deleted server url to customServer redux state.
Mon, Dec 4, 11:02 PM
ginsu committed rCOMMdf29fd4b968e: [native] save the recently deleted server url to customServer redux state (authored by ginsu).
[native] save the recently deleted server url to customServer redux state
Mon, Dec 4, 11:02 PM
ginsu updated the diff for D10154: [web] add keyserver url validation logic and error handling to the add keyserver modal.

rebase before landing

Mon, Dec 4, 10:58 PM
ginsu updated the diff for D10094: [web] implement onClickAddKeyserver callback.

rebase before landing

Mon, Dec 4, 10:57 PM
ginsu updated the diff for D10093: [web] save the recently deleted server url to customServer redux state.

rebase before landing

Mon, Dec 4, 10:56 PM
ginsu updated the diff for D10092: [lib/native/web] lift customServer redux state into lib.

rebase before landing

Mon, Dec 4, 10:55 PM
ginsu updated the diff for D10090: [lib/native] lift set custom server action type into lib.

rebase one more time

Mon, Dec 4, 10:53 PM
ginsu updated the diff for D9906: [native] save the recently deleted server url to customServer redux state.

rebase one more time

Mon, Dec 4, 10:52 PM
ginsu added a comment to D10092: [lib/native/web] lift customServer redux state into lib.

Can you also check if calling setCustomServerActionType on web sets the value in the store?

Mon, Dec 4, 10:52 PM
ginsu attached a referenced file: F911854: Screen Recording 2023-12-05 at 1.50.05 AM.mov.
Mon, Dec 4, 10:51 PM
ginsu updated the test plan for D10092: [lib/native/web] lift customServer redux state into lib.
Mon, Dec 4, 10:51 PM
ginsu added inline comments to D9673: [lib] correctly skip using established socket when urlPrefix is overriden.
Mon, Dec 4, 10:46 PM
ginsu closed D9667: [lib/native] add keyserver url validation logic and error handling to the add keyserver screen.
Mon, Dec 4, 10:31 PM
ginsu committed rCOMMe250e5ccff7b: [lib/native] add keyserver url validation logic and error handling to the add… (authored by ginsu).
[lib/native] add keyserver url validation logic and error handling to the add…
Mon, Dec 4, 10:31 PM
ginsu closed D9666: [lib/native] introduce useIsKeyserverURLValid hook.
Mon, Dec 4, 10:31 PM
ginsu committed rCOMM232d032138c0: [lib/native] introduce useIsKeyserverURLValid hook (authored by ginsu).
[lib/native] introduce useIsKeyserverURLValid hook
Mon, Dec 4, 10:31 PM
ginsu updated the diff for D9667: [lib/native] add keyserver url validation logic and error handling to the add keyserver screen.

rebase one more time

Mon, Dec 4, 10:29 PM
ginsu updated the diff for D9666: [lib/native] introduce useIsKeyserverURLValid hook.

rebase one more time

Mon, Dec 4, 10:27 PM
ginsu accepted D10175: [web] await baseSetThreadAvatar/baseSetUserAvatar in onImageSelected.
Mon, Dec 4, 9:50 PM
ginsu accepted D10172: [lib] Fix pinned messages not working.
Mon, Dec 4, 9:49 PM
ginsu accepted D10167: [native] Pass on nativeSetUserAvatar's Promise to actionSheetConfig.
Mon, Dec 4, 9:47 PM
ginsu requested review of D10154: [web] add keyserver url validation logic and error handling to the add keyserver modal.
Mon, Dec 4, 7:26 AM
ginsu updated the diff for D10090: [lib/native] lift set custom server action type into lib.

rebase before landing

Mon, Dec 4, 7:17 AM
ginsu updated the diff for D9906: [native] save the recently deleted server url to customServer redux state.

rebase before landing

Mon, Dec 4, 7:16 AM
ginsu abandoned D9673: [lib] correctly skip using established socket when urlPrefix is overriden.

After merging + rebasing @inka's changes where she introduced the useGetVersion hook, we now use this hook instead of using useServerCall(getVersion). When the useGetVersion hook calls the callServerEndpoint function it will skip using the established socket by default, making this diff not necessary anymore

Mon, Dec 4, 7:13 AM
ginsu updated the diff for D9667: [lib/native] add keyserver url validation logic and error handling to the add keyserver screen.

rebase before landing

Mon, Dec 4, 7:03 AM
ginsu updated the diff for D9666: [lib/native] introduce useIsKeyserverURLValid hook.

rebase before landing

Mon, Dec 4, 7:02 AM
ginsu requested review of D10149: [web] introduce light mode to app directory modal.
Mon, Dec 4, 12:36 AM
ginsu closed D10141: [web] introduce light mode to roles modal.
Mon, Dec 4, 12:32 AM
ginsu committed rCOMM7f461010fa90: [web] introduce light mode to roles modal (authored by ginsu).
[web] introduce light mode to roles modal
Mon, Dec 4, 12:32 AM
ginsu updated the diff for D10141: [web] introduce light mode to roles modal.

rebase before landing

Mon, Dec 4, 12:25 AM

Fri, Dec 1

ginsu attached a referenced file: F906475: Screenshot 2023-12-01 at 5.27.13 PM.png.
Fri, Dec 1, 2:50 PM
ginsu requested review of D10146: [web] introduce light to delete role modal.
Fri, Dec 1, 2:49 PM
ginsu requested review of D10145: [web] introduce light mode to create/edit role modal.
Fri, Dec 1, 2:42 PM
ginsu requested review of D10144: [web] introduce light mode to community creation modal.
Fri, Dec 1, 2:27 PM
ginsu requested review of D10141: [web] introduce light mode to roles modal.
Fri, Dec 1, 11:40 AM
ginsu closed D10104: [web] introduce light mode to public link modal.
Fri, Dec 1, 11:20 AM
ginsu committed rCOMMce536ff838e4: [web] introduce light mode to public link modal (authored by ginsu).
[web] introduce light mode to public link modal
Fri, Dec 1, 11:20 AM
ginsu updated the diff for D10104: [web] introduce light mode to public link modal.

rebase before landing

Fri, Dec 1, 11:15 AM
ginsu updated subscribers of D7277: [web] gate avatars rendering.
Fri, Dec 1, 8:26 AM

Thu, Nov 30

ginsu updated subscribers of D7099: [native] add feature flag to avatars render work.
Thu, Nov 30, 9:40 PM
ginsu closed D10103: [web] introduce light mode to view invite link modal.
Thu, Nov 30, 9:32 PM
ginsu committed rCOMM476e0b3ad021: [web] introduce light mode to view invite link modal (authored by ginsu).
[web] introduce light mode to view invite link modal
Thu, Nov 30, 9:32 PM
ginsu closed D10101: [web] introduce light mode to manage invite link modal.
Thu, Nov 30, 9:32 PM
ginsu committed rCOMM6508a0a7bbd3: [web] introduce light mode to manage invite link modal (authored by ginsu).
[web] introduce light mode to manage invite link modal
Thu, Nov 30, 9:32 PM
ginsu updated the diff for D10103: [web] introduce light mode to view invite link modal.

rebase before landing

Thu, Nov 30, 9:30 PM
ginsu updated the diff for D10101: [web] introduce light mode to manage invite link modal.

rebase before landing

Thu, Nov 30, 9:30 PM
ginsu accepted D10120: [native] Fix KeyboardAvoidingView animation when cross-fade animations enabled on iOS.
Thu, Nov 30, 5:00 PM
ginsu accepted D10100: [native] Use consistent panel colors in QR code screens.
Thu, Nov 30, 4:59 PM
ginsu requested review of D10104: [web] introduce light mode to public link modal.
Thu, Nov 30, 10:02 AM
ginsu requested review of D10103: [web] introduce light mode to view invite link modal.
Thu, Nov 30, 9:39 AM
ginsu requested review of D10101: [web] introduce light mode to manage invite link modal.
Thu, Nov 30, 9:28 AM

Wed, Nov 29

ginsu closed D10089: [web] introduce on click remove keyserver functionality.
Wed, Nov 29, 10:42 PM
ginsu committed rCOMM2a9f5f4b299c: [web] introduce on click remove keyserver functionality (authored by ginsu).
[web] introduce on click remove keyserver functionality
Wed, Nov 29, 10:42 PM
ginsu closed D10080: [web] introduce temp onClickDisconnectKeyserver.
Wed, Nov 29, 10:42 PM
ginsu closed D10081: [web] introduce confirmation alert component.
Wed, Nov 29, 10:42 PM
ginsu committed rCOMM8571cfe07878: [web] introduce temp onClickDisconnectKeyserver (authored by ginsu).
[web] introduce temp onClickDisconnectKeyserver
Wed, Nov 29, 10:42 PM
ginsu committed rCOMMd19f5c7d992a: [web] introduce confirmation alert component (authored by ginsu).
[web] introduce confirmation alert component
Wed, Nov 29, 10:42 PM
ginsu closed D10079: [web] update the keyserver selection modal based on the connection status.
Wed, Nov 29, 10:42 PM
ginsu committed rCOMMd08e659a6c69: [web] update the keyserver selection modal based on the connection status (authored by ginsu).
[web] update the keyserver selection modal based on the connection status
Wed, Nov 29, 10:42 PM
ginsu updated the diff for D10089: [web] introduce on click remove keyserver functionality.

rebase before landing

Wed, Nov 29, 10:03 PM
ginsu updated the diff for D10081: [web] introduce confirmation alert component.

rebase before landing

Wed, Nov 29, 10:00 PM
ginsu attached a referenced file: F902252: Screenshot 2023-11-30 at 12.59.25 AM.png.
Wed, Nov 29, 10:00 PM
ginsu added a comment to D10081: [web] introduce confirmation alert component.

Thanks for doing this! Could you share a screenshot for what the delete roles modal looks like now please?

Wed, Nov 29, 10:00 PM
ginsu updated the diff for D10080: [web] introduce temp onClickDisconnectKeyserver.

address comments + rebase before landing

Wed, Nov 29, 9:57 PM
ginsu updated the diff for D10079: [web] update the keyserver selection modal based on the connection status.

rebase before landing

Wed, Nov 29, 9:11 PM
ginsu updated the diff for D9666: [lib/native] introduce useIsKeyserverURLValid hook.

rebase before landing

Wed, Nov 29, 9:06 PM
ginsu updated the diff for D10079: [web] update the keyserver selection modal based on the connection status.

fix copy

Wed, Nov 29, 10:43 AM
ginsu added inline comments to D10079: [web] update the keyserver selection modal based on the connection status.
Wed, Nov 29, 10:41 AM
ginsu requested review of D10094: [web] implement onClickAddKeyserver callback.
Wed, Nov 29, 2:20 AM
ginsu requested review of D10093: [web] save the recently deleted server url to customServer redux state.
Wed, Nov 29, 1:41 AM
ginsu requested review of D10090: [lib/native] lift set custom server action type into lib.
Wed, Nov 29, 1:25 AM
ginsu requested review of D10092: [lib/native/web] lift customServer redux state into lib.
Wed, Nov 29, 1:20 AM

Tue, Nov 28

ginsu requested review of D10089: [web] introduce on click remove keyserver functionality.
Tue, Nov 28, 10:18 PM
ginsu requested review of D10081: [web] introduce confirmation alert component.
Tue, Nov 28, 9:08 PM
ginsu requested review of D10080: [web] introduce temp onClickDisconnectKeyserver.
Tue, Nov 28, 8:53 PM
ginsu requested review of D10079: [web] update the keyserver selection modal based on the connection status.
Tue, Nov 28, 8:33 PM
ginsu closed D9918: [web] introduce add keyserver button.
Tue, Nov 28, 8:07 PM
ginsu closed D9920: [web] introduce keyserver selection modal.
Tue, Nov 28, 8:07 PM
ginsu committed rCOMM63b03a1c242c: [web] introduce add keyserver button (authored by ginsu).
[web] introduce add keyserver button
Tue, Nov 28, 8:07 PM
ginsu committed rCOMM8ef417bec6ff: [web] introduce keyserver selection modal (authored by ginsu).
[web] introduce keyserver selection modal
Tue, Nov 28, 8:07 PM
ginsu closed D9916: [web] introduce add keyserver modal.
Tue, Nov 28, 8:07 PM
ginsu committed rCOMM01beb1a4d4ac: [web] introduce add keyserver modal (authored by ginsu).
[web] introduce add keyserver modal
Tue, Nov 28, 8:07 PM
ginsu updated the diff for D9920: [web] introduce keyserver selection modal.

rebase before landing

Tue, Nov 28, 7:23 PM
ginsu updated the diff for D9918: [web] introduce add keyserver button.

address comments + rebase before landing

Tue, Nov 28, 7:16 PM