Page MenuHomePhabricator
Differential D11768

[lib][native][web] Introduce useWalletLogIn hook
ClosedPublic
Actions

Authored by ashoat on Wed, Apr 24, 12:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 8:17 PM
Unknown Object (File)
Thu, May 2, 4:37 PM
Unknown Object (File)
Thu, May 2, 2:39 PM
Unknown Object (File)
Thu, May 2, 1:23 PM
Unknown Object (File)
Wed, May 1, 4:45 PM
Unknown Object (File)
Tue, Apr 30, 3:09 PM
Unknown Object (File)
Wed, Apr 24, 2:39 PM
Unknown Object (File)
Wed, Apr 24, 2:38 PM
View All 9 Files
Subscribers
None

Details

Reviewers
tomek
inka
Commits
rCOMM84670804db33: [lib][native][web] Introduce useWalletLogIn hook
Summary

This addresses ENG-7680, ENG-7670, and ENG-7672.

This furthers the goal of the parent task, which is to move authoritative keyserver auth from KeyserverConnectionHandler to the individual components responsible for login.

Depends on D11767

Test Plan

This whole stack was tested with the following steps:

  1. On native, attempting to log in with an ETH account that hasn’t been registered yet
  2. On native, attemping to register with an ETH account that has already been registered
  3. On native, log in with an ETH account that has already been registered
  4. On native, register with an ETH account that hasn’t already been registered
  5. On native, register with a password account
  6. On native, log in with a password account
  7. On web, attempting to log in with an ETH account that hasn’t been registered yet
  8. On web, log in with an ETH account that has already been registered
  9. On web, log in with a password account

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Wed, Apr 24, 12:43 PM
ashoat added a child revision: D11769: [lib] Don't set dataLoaded on authoritative keyserver auth.
Harbormaster completed remote builds in B28444: Diff 39454.Wed, Apr 24, 1:22 PM
ashoat requested review of this revision.Wed, Apr 24, 1:22 PM
ashoat updated this revision to Diff 39501.Thu, Apr 25, 10:03 AM

Rebase

Harbormaster failed remote builds in B28473: Diff 39501!Thu, Apr 25, 10:18 AM
ashoat updated this revision to Diff 39504.Thu, Apr 25, 10:51 AM

Lint fix following rebase

Harbormaster completed remote builds in B28476: Diff 39504.Thu, Apr 25, 11:07 AM
inka accepted this revision.Fri, Apr 26, 6:53 AM
inka added inline comments.
web/account/siwe-login-form.react.js
81 ↗(On Diff #39504)

If we removed identity from useWalletLogIn name, should we also remove it from identityWalletLogIn and attemptIdentityWalletLogIn?

This revision is now accepted and ready to land.Fri, Apr 26, 6:53 AM
ashoat updated this revision to Diff 39551.Fri, Apr 26, 8:15 AM

Use the name walletLogIn for the result of useWalletLogIn(), and rename attemptIdentityWalletLogIn to attemptWalletLogIn

This revision was landed with ongoing or failed builds.Fri, Apr 26, 8:18 AM
Closed by commit rCOMM84670804db33: [lib][native][web] Introduce useWalletLogIn hook (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM84670804db33: [lib][native][web] Introduce useWalletLogIn hook.
Harbormaster completed remote builds in B28515: Diff 39551.Fri, Apr 26, 8:31 AM

Revision Contents
Changeset List

PathSize
lib/
hooks/
77 lines
native/
account/
12 lines
registration/
12 lines
27 lines
web/
account/
44 lines

Diff 39559

View Options

lib/hooks/login-hooks.js

Loading...
View Options

native/account/fullscreen-siwe-panel.react.js

Loading...
View Options

native/account/registration/existing-ethereum-account.react.js

Loading...
View Options

native/account/siwe-hooks.js

Loading...
View Options

web/account/siwe-login-form.react.js

Loading...