Details

Reviewers

tomek
inka

Commits

rCOMM84670804db33: [lib][native][web] Introduce useWalletLogIn hook

Summary

This addresses ENG-7680, ENG-7670, and ENG-7672.

This furthers the goal of the parent task, which is to move authoritative keyserver auth from KeyserverConnectionHandler to the individual components responsible for login.

Depends on D11767

Test Plan

This whole stack was tested with the following steps:

On native, attempting to log in with an ETH account that hasn’t been registered yet
On native, attemping to register with an ETH account that has already been registered
On native, log in with an ETH account that has already been registered
On native, register with an ETH account that hasn’t already been registered
On native, register with a password account
On native, log in with a password account
On web, attempting to log in with an ETH account that hasn’t been registered yet
On web, log in with an ETH account that has already been registered
On web, log in with a password account

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 24 2024, 12:43 PM

ashoat added a child revision: D11769: [lib] Don't set dataLoaded on authoritative keyserver auth.

Harbormaster completed remote builds in B28444: Diff 39454.Apr 24 2024, 1:22 PM

ashoat requested review of this revision.Apr 24 2024, 1:22 PM

Rebase

Harbormaster failed remote builds in B28473: Diff 39501!Apr 25 2024, 10:18 AM

Lint fix following rebase

Harbormaster completed remote builds in B28476: Diff 39504.Apr 25 2024, 11:07 AM

inka accepted this revision.Apr 26 2024, 6:53 AM

inka added inline comments.

web/account/siwe-login-form.react.js
81 ↗	(On Diff #39504)	If we removed `identity` from `useWalletLogIn` name, should we also remove it from `identityWalletLogIn` and `attemptIdentityWalletLogIn`?