[native] rename `<Registration` components to `<Auth` components
ClosedPublic
Actions

Authored by kamil on Dec 18 2024, 5:20 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM39d7f06a7465: [native] rename `<Registration*` components to `<Auth*` components

Summary

This is a follow-up to what I suggested in D14114 - to avoid confusion renaming to something more generic as now those components are also used outside of registration flow.

This diff is only rename, I am going to move them to a different directory in next diff to make review easy.

Depends on D14169

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Dec 18 2024, 5:20 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptDec 18 2024, 5:20 AM

Harbormaster completed remote builds in B33173: Diff 46567.Dec 18 2024, 5:37 AM

kamil retitled this revision from [native] rename `<Registration*` components to ``<Auth*` components to [native] rename `<Registration*` components to `<Auth*` components.Dec 18 2024, 5:55 AM

kamil added a child revision: D14171: [native] move `<Auth*` components to a `/auth-components` directory.Dec 18 2024, 5:57 AM

kamil published this revision for review.Dec 19 2024, 2:40 AM

bartek accepted this revision.Dec 19 2024, 5:19 AM

This revision is now accepted and ready to land.Dec 19 2024, 5:19 AM

rebase

Harbormaster completed remote builds in B33199: Diff 46607.Jan 8 2025, 2:19 AM

Closed by commit rCOMM39d7f06a7465: [native] rename `<Registration*` components to `<Auth*` components (authored by kamil). · Explain WhyJan 9 2025, 4:16 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM39d7f06a7465: [native] rename `<Registration*` components to `<Auth*` components.

Revision Contents
Changeset List

Path

Size

native/

account/

qr-auth/

connect-secondary-device.react.js

18 lines

qr-auth-not-primary-device.react.js

18 lines

secondary-device-connected.react.js

18 lines

secondary-device-not-responding.react.js

18 lines

qr-code-screen.react.js

18 lines

registration/

account-does-not-exist.react.js

18 lines

avatar-selection.react.js

18 lines

connect-ethereum.react.js

18 lines

connect-farcaster.react.js

18 lines

cool-or-nerd-mode-selection.react.js

18 lines

emoji-avatar-selection.react.js

12 lines

existing-ethereum-account.react.js

18 lines

keyserver-selection.react.js

18 lines

password-selection.react.js

18 lines

registration-button-container.react.js

4 lines

registration-container.react.js

4 lines

registration-content-container.react.js

4 lines

registration-terms.react.js

18 lines

siwe-backup-message-creation.react.js

32 lines

username-selection.react.js

18 lines

restore-backup-screen.react.js

12 lines

restore-password-account-screen.react.js

18 lines

restore-prompt-screen.react.js

18 lines

community-creation/

community-configuration.react.js

18 lines

Diff 46628

View Options

native/account/qr-auth/connect-secondary-device.react.js

	use std::collections::HashMap;			use std::collections::{HashMap, HashSet};

	use chrono::{DateTime, Utc};			use chrono::{DateTime, Utc};
	use comm_lib::{			use comm_lib::{
	aws::ddb::{			aws::ddb::{
	operation::{get_item::GetItemOutput, query::builders::QueryFluentBuilder},			operation::{get_item::GetItemOutput, query::builders::QueryFluentBuilder},
	types::{			types::{
	error::TransactionCanceledException, AttributeValue, Delete,			error::TransactionCanceledException, AttributeValue, Delete,
	DeleteRequest, Put, TransactWriteItem, Update, WriteRequest,			DeleteRequest, Put, TransactWriteItem, Update, WriteRequest,
	▲ Show 20 Lines • Show All 1,753 Lines • ▼ Show 20 Lines

	/// Deletes all device data for user. Keeps device list rows.			/// Deletes all device data for user. Keeps device list rows.
	/// Returns list of deleted device IDs			/// Returns list of deleted device IDs
	#[tracing::instrument(skip_all)]			#[tracing::instrument(skip_all)]
	pub async fn delete_devices_data_for_user(			pub async fn delete_devices_data_for_user(
	&self,			&self,
	user_id: impl Into<String>,			user_id: impl Into<String>,
	) -> Result<Vec<String>, Error> {			) -> Result<Vec<String>, Error> {
				self.delete_user_devices_data_excluding(user_id, &[]).await
				}

				/// Same as [`DatabaseClient::delete_devices_data_for_user`]
				/// but allows to exclude certain device IDs.
				#[tracing::instrument(skip_all)]
				pub async fn delete_user_devices_data_excluding(
				&self,
				user_id: impl Into<String>,
				excluded_device_ids: &[&String],
				) -> Result<Vec<String>, Error> {
	let user_id: String = user_id.into();			let user_id: String = user_id.into();
				let excluded_device_ids: HashSet<&String> =
				excluded_device_ids.iter().cloned().collect();

	// we project only the primary keys so we can pass these directly to delete requests			// we project only the primary keys so we can pass these directly to delete requests
	let primary_keys =			let primary_keys =
	query_rows_with_prefix(self, &user_id, DEVICE_ITEM_KEY_PREFIX)			query_rows_with_prefix(self, &user_id, DEVICE_ITEM_KEY_PREFIX)
	.projection_expression(format!("{ATTR_USER_ID}, {ATTR_ITEM_ID}"))			.projection_expression(format!("{ATTR_USER_ID}, {ATTR_ITEM_ID}"))
	.send()			.send()
	.await			.await
	.map_err(\|e\| {			.map_err(\|e\| {
	error!(			error!(
	errorType = error_types::DEVICE_LIST_DB_LOG,			errorType = error_types::DEVICE_LIST_DB_LOG,
	"Failed to list user's devices' primary keys: {:?}", e			"Failed to list user's devices' primary keys: {:?}", e
	);			);
	Error::AwsSdk(e.into())			Error::AwsSdk(e.into())
	})?			})?
	.items			.items
	.unwrap_or_default();			.unwrap_or_default();

	let device_ids = primary_keys			let filtered_keys_iter = primary_keys.into_iter().filter_map(\|pk_attrs\| {
	.iter()			let item_id = pk_attrs.get(devices_table::ATTR_ITEM_ID).cloned();
	.map(\|attrs\| {			let device_id_result =
	let attr = attrs.get(devices_table::ATTR_ITEM_ID).cloned();			DeviceIDAttribute::try_from(item_id).map(DeviceIDAttribute::into_inner);
	DeviceIDAttribute::try_from(attr).map(DeviceIDAttribute::into_inner)
	})			match device_id_result {
	.collect::<Result<_, _>>()?;			Err(err) => Some(Err(err)),
				Ok(device_id) if excluded_device_ids.contains(&device_id) => None,
	let delete_requests = primary_keys			Ok(device_id) => {
	.into_iter()
	.map(\|item\| {
	let request = DeleteRequest::builder()			let request = DeleteRequest::builder()
	.set_key(Some(item))			.set_key(Some(pk_attrs))
	.build()			.build()
	.expect("key not set in DeleteRequest builder");			.expect("key not set in DeleteRequest builder");
	WriteRequest::builder().delete_request(request).build()			let request = WriteRequest::builder().delete_request(request).build();
	})
	.collect::<Vec<_>>();			Some(Ok((device_id, request)))
				}
				}
				});

				let (device_ids, delete_requests) =
				filtered_keys_iter.collect::<Result<(Vec<_>, Vec<_>), _>>()?;

	comm_lib::database::batch_operations::batch_write(			comm_lib::database::batch_operations::batch_write(
	&self.client,			&self.client,
	devices_table::NAME,			devices_table::NAME,
	delete_requests,			delete_requests,
	Default::default(),			Default::default(),
	)			)
	.await?;			.await?;
	▲ Show 20 Lines • Show All 683 Lines • Show Last 20 Lines

View Options

native/account/qr-auth/qr-auth-not-primary-device.react.js

	use std::collections::HashMap;			use std::collections::{HashMap, HashSet};

	use chrono::{DateTime, Utc};			use chrono::{DateTime, Utc};
	use comm_lib::{			use comm_lib::{
	aws::ddb::{			aws::ddb::{
	operation::{get_item::GetItemOutput, query::builders::QueryFluentBuilder},			operation::{get_item::GetItemOutput, query::builders::QueryFluentBuilder},
	types::{			types::{
	error::TransactionCanceledException, AttributeValue, Delete,			error::TransactionCanceledException, AttributeValue, Delete,
	DeleteRequest, Put, TransactWriteItem, Update, WriteRequest,			DeleteRequest, Put, TransactWriteItem, Update, WriteRequest,
	▲ Show 20 Lines • Show All 1,753 Lines • ▼ Show 20 Lines

	/// Deletes all device data for user. Keeps device list rows.			/// Deletes all device data for user. Keeps device list rows.
	/// Returns list of deleted device IDs			/// Returns list of deleted device IDs
	#[tracing::instrument(skip_all)]			#[tracing::instrument(skip_all)]
	pub async fn delete_devices_data_for_user(			pub async fn delete_devices_data_for_user(
	&self,			&self,
	user_id: impl Into<String>,			user_id: impl Into<String>,
	) -> Result<Vec<String>, Error> {			) -> Result<Vec<String>, Error> {
				self.delete_user_devices_data_excluding(user_id, &[]).await
				}

				/// Same as [`DatabaseClient::delete_devices_data_for_user`]
				/// but allows to exclude certain device IDs.
				#[tracing::instrument(skip_all)]
				pub async fn delete_user_devices_data_excluding(
				&self,
				user_id: impl Into<String>,
				excluded_device_ids: &[&String],
				) -> Result<Vec<String>, Error> {
	let user_id: String = user_id.into();			let user_id: String = user_id.into();
				let excluded_device_ids: HashSet<&String> =
				excluded_device_ids.iter().cloned().collect();

	// we project only the primary keys so we can pass these directly to delete requests			// we project only the primary keys so we can pass these directly to delete requests
	let primary_keys =			let primary_keys =
	query_rows_with_prefix(self, &user_id, DEVICE_ITEM_KEY_PREFIX)			query_rows_with_prefix(self, &user_id, DEVICE_ITEM_KEY_PREFIX)
	.projection_expression(format!("{ATTR_USER_ID}, {ATTR_ITEM_ID}"))			.projection_expression(format!("{ATTR_USER_ID}, {ATTR_ITEM_ID}"))
	.send()			.send()
	.await			.await
	.map_err(\|e\| {			.map_err(\|e\| {
	error!(			error!(
	errorType = error_types::DEVICE_LIST_DB_LOG,			errorType = error_types::DEVICE_LIST_DB_LOG,
	"Failed to list user's devices' primary keys: {:?}", e			"Failed to list user's devices' primary keys: {:?}", e
	);			);
	Error::AwsSdk(e.into())			Error::AwsSdk(e.into())
	})?			})?
	.items			.items
	.unwrap_or_default();			.unwrap_or_default();

	let device_ids = primary_keys			let filtered_keys_iter = primary_keys.into_iter().filter_map(\|pk_attrs\| {
	.iter()			let item_id = pk_attrs.get(devices_table::ATTR_ITEM_ID).cloned();
	.map(\|attrs\| {			let device_id_result =
	let attr = attrs.get(devices_table::ATTR_ITEM_ID).cloned();			DeviceIDAttribute::try_from(item_id).map(DeviceIDAttribute::into_inner);
	DeviceIDAttribute::try_from(attr).map(DeviceIDAttribute::into_inner)
	})			match device_id_result {
	.collect::<Result<_, _>>()?;			Err(err) => Some(Err(err)),
				Ok(device_id) if excluded_device_ids.contains(&device_id) => None,
	let delete_requests = primary_keys			Ok(device_id) => {
	.into_iter()
	.map(\|item\| {
	let request = DeleteRequest::builder()			let request = DeleteRequest::builder()
	.set_key(Some(item))			.set_key(Some(pk_attrs))
	.build()			.build()
	.expect("key not set in DeleteRequest builder");			.expect("key not set in DeleteRequest builder");
	WriteRequest::builder().delete_request(request).build()			let request = WriteRequest::builder().delete_request(request).build();
	})
	.collect::<Vec<_>>();			Some(Ok((device_id, request)))
				}
				}
				});

				let (device_ids, delete_requests) =
				filtered_keys_iter.collect::<Result<(Vec<_>, Vec<_>), _>>()?;

	comm_lib::database::batch_operations::batch_write(			comm_lib::database::batch_operations::batch_write(
	&self.client,			&self.client,
	devices_table::NAME,			devices_table::NAME,
	delete_requests,			delete_requests,
	Default::default(),			Default::default(),
	)			)
	.await?;			.await?;
	▲ Show 20 Lines • Show All 683 Lines • Show Last 20 Lines

View Options

native/account/qr-auth/secondary-device-connected.react.js

	use std::collections::HashMap;			use std::collections::{HashMap, HashSet};

	use chrono::{DateTime, Utc};			use chrono::{DateTime, Utc};
	use comm_lib::{			use comm_lib::{
	aws::ddb::{			aws::ddb::{
	operation::{get_item::GetItemOutput, query::builders::QueryFluentBuilder},			operation::{get_item::GetItemOutput, query::builders::QueryFluentBuilder},
	types::{			types::{
	error::TransactionCanceledException, AttributeValue, Delete,			error::TransactionCanceledException, AttributeValue, Delete,
	DeleteRequest, Put, TransactWriteItem, Update, WriteRequest,			DeleteRequest, Put, TransactWriteItem, Update, WriteRequest,
	▲ Show 20 Lines • Show All 1,753 Lines • ▼ Show 20 Lines

	/// Deletes all device data for user. Keeps device list rows.			/// Deletes all device data for user. Keeps device list rows.
	/// Returns list of deleted device IDs			/// Returns list of deleted device IDs
	#[tracing::instrument(skip_all)]			#[tracing::instrument(skip_all)]
	pub async fn delete_devices_data_for_user(			pub async fn delete_devices_data_for_user(
	&self,			&self,
	user_id: impl Into<String>,			user_id: impl Into<String>,
	) -> Result<Vec<String>, Error> {			) -> Result<Vec<String>, Error> {
				self.delete_user_devices_data_excluding(user_id, &[]).await
				}

				/// Same as [`DatabaseClient::delete_devices_data_for_user`]
				/// but allows to exclude certain device IDs.
				#[tracing::instrument(skip_all)]
				pub async fn delete_user_devices_data_excluding(
				&self,
				user_id: impl Into<String>,
				excluded_device_ids: &[&String],
				) -> Result<Vec<String>, Error> {
	let user_id: String = user_id.into();			let user_id: String = user_id.into();
				let excluded_device_ids: HashSet<&String> =
				excluded_device_ids.iter().cloned().collect();

	// we project only the primary keys so we can pass these directly to delete requests			// we project only the primary keys so we can pass these directly to delete requests
	let primary_keys =			let primary_keys =
	query_rows_with_prefix(self, &user_id, DEVICE_ITEM_KEY_PREFIX)			query_rows_with_prefix(self, &user_id, DEVICE_ITEM_KEY_PREFIX)
	.projection_expression(format!("{ATTR_USER_ID}, {ATTR_ITEM_ID}"))			.projection_expression(format!("{ATTR_USER_ID}, {ATTR_ITEM_ID}"))
	.send()			.send()
	.await			.await
	.map_err(\|e\| {			.map_err(\|e\| {
	error!(			error!(
	errorType = error_types::DEVICE_LIST_DB_LOG,			errorType = error_types::DEVICE_LIST_DB_LOG,
	"Failed to list user's devices' primary keys: {:?}", e			"Failed to list user's devices' primary keys: {:?}", e
	);			);
	Error::AwsSdk(e.into())			Error::AwsSdk(e.into())
	})?			})?
	.items			.items
	.unwrap_or_default();			.unwrap_or_default();

	let device_ids = primary_keys			let filtered_keys_iter = primary_keys.into_iter().filter_map(\|pk_attrs\| {
	.iter()			let item_id = pk_attrs.get(devices_table::ATTR_ITEM_ID).cloned();
	.map(\|attrs\| {			let device_id_result =
	let attr = attrs.get(devices_table::ATTR_ITEM_ID).cloned();			DeviceIDAttribute::try_from(item_id).map(DeviceIDAttribute::into_inner);
	DeviceIDAttribute::try_from(attr).map(DeviceIDAttribute::into_inner)
	})			match device_id_result {
	.collect::<Result<_, _>>()?;			Err(err) => Some(Err(err)),
				Ok(device_id) if excluded_device_ids.contains(&device_id) => None,
	let delete_requests = primary_keys			Ok(device_id) => {
	.into_iter()
	.map(\|item\| {
	let request = DeleteRequest::builder()			let request = DeleteRequest::builder()
	.set_key(Some(item))			.set_key(Some(pk_attrs))
	.build()			.build()
	.expect("key not set in DeleteRequest builder");			.expect("key not set in DeleteRequest builder");
	WriteRequest::builder().delete_request(request).build()			let request = WriteRequest::builder().delete_request(request).build();
	})
	.collect::<Vec<_>>();			Some(Ok((device_id, request)))
				}
				}
				});

				let (device_ids, delete_requests) =
				filtered_keys_iter.collect::<Result<(Vec<_>, Vec<_>), _>>()?;

	comm_lib::database::batch_operations::batch_write(			comm_lib::database::batch_operations::batch_write(
	&self.client,			&self.client,
	devices_table::NAME,			devices_table::NAME,
	delete_requests,			delete_requests,
	Default::default(),			Default::default(),
	)			)
	.await?;			.await?;
	▲ Show 20 Lines • Show All 683 Lines • Show Last 20 Lines

View Options

native/account/qr-auth/secondary-device-not-responding.react.js

	use std::collections::HashMap;			use std::collections::{HashMap, HashSet};

	use chrono::{DateTime, Utc};			use chrono::{DateTime, Utc};
	use comm_lib::{			use comm_lib::{
	aws::ddb::{			aws::ddb::{
	operation::{get_item::GetItemOutput, query::builders::QueryFluentBuilder},			operation::{get_item::GetItemOutput, query::builders::QueryFluentBuilder},
	types::{			types::{
	error::TransactionCanceledException, AttributeValue, Delete,			error::TransactionCanceledException, AttributeValue, Delete,
	DeleteRequest, Put, TransactWriteItem, Update, WriteRequest,			DeleteRequest, Put, TransactWriteItem, Update, WriteRequest,
	▲ Show 20 Lines • Show All 1,753 Lines • ▼ Show 20 Lines

	/// Deletes all device data for user. Keeps device list rows.			/// Deletes all device data for user. Keeps device list rows.
	/// Returns list of deleted device IDs			/// Returns list of deleted device IDs
	#[tracing::instrument(skip_all)]			#[tracing::instrument(skip_all)]
	pub async fn delete_devices_data_for_user(			pub async fn delete_devices_data_for_user(
	&self,			&self,
	user_id: impl Into<String>,			user_id: impl Into<String>,
	) -> Result<Vec<String>, Error> {			) -> Result<Vec<String>, Error> {
				self.delete_user_devices_data_excluding(user_id, &[]).await
				}

				/// Same as [`DatabaseClient::delete_devices_data_for_user`]
				/// but allows to exclude certain device IDs.
				#[tracing::instrument(skip_all)]
				pub async fn delete_user_devices_data_excluding(
				&self,
				user_id: impl Into<String>,
				excluded_device_ids: &[&String],
				) -> Result<Vec<String>, Error> {
	let user_id: String = user_id.into();			let user_id: String = user_id.into();
				let excluded_device_ids: HashSet<&String> =
				excluded_device_ids.iter().cloned().collect();

	// we project only the primary keys so we can pass these directly to delete requests			// we project only the primary keys so we can pass these directly to delete requests
	let primary_keys =			let primary_keys =
	query_rows_with_prefix(self, &user_id, DEVICE_ITEM_KEY_PREFIX)			query_rows_with_prefix(self, &user_id, DEVICE_ITEM_KEY_PREFIX)
	.projection_expression(format!("{ATTR_USER_ID}, {ATTR_ITEM_ID}"))			.projection_expression(format!("{ATTR_USER_ID}, {ATTR_ITEM_ID}"))
	.send()			.send()
	.await			.await
	.map_err(\|e\| {			.map_err(\|e\| {
	error!(			error!(
	errorType = error_types::DEVICE_LIST_DB_LOG,			errorType = error_types::DEVICE_LIST_DB_LOG,
	"Failed to list user's devices' primary keys: {:?}", e			"Failed to list user's devices' primary keys: {:?}", e
	);			);
	Error::AwsSdk(e.into())			Error::AwsSdk(e.into())
	})?			})?
	.items			.items
	.unwrap_or_default();			.unwrap_or_default();

	let device_ids = primary_keys			let filtered_keys_iter = primary_keys.into_iter().filter_map(\|pk_attrs\| {
	.iter()			let item_id = pk_attrs.get(devices_table::ATTR_ITEM_ID).cloned();
	.map(\|attrs\| {			let device_id_result =
	let attr = attrs.get(devices_table::ATTR_ITEM_ID).cloned();			DeviceIDAttribute::try_from(item_id).map(DeviceIDAttribute::into_inner);
	DeviceIDAttribute::try_from(attr).map(DeviceIDAttribute::into_inner)
	})			match device_id_result {
	.collect::<Result<_, _>>()?;			Err(err) => Some(Err(err)),
				Ok(device_id) if excluded_device_ids.contains(&device_id) => None,
	let delete_requests = primary_keys			Ok(device_id) => {
	.into_iter()
	.map(\|item\| {
	let request = DeleteRequest::builder()			let request = DeleteRequest::builder()
	.set_key(Some(item))			.set_key(Some(pk_attrs))
	.build()			.build()
	.expect("key not set in DeleteRequest builder");			.expect("key not set in DeleteRequest builder");
	WriteRequest::builder().delete_request(request).build()			let request = WriteRequest::builder().delete_request(request).build();
	})
	.collect::<Vec<_>>();			Some(Ok((device_id, request)))
				}
				}
				});

				let (device_ids, delete_requests) =
				filtered_keys_iter.collect::<Result<(Vec<_>, Vec<_>), _>>()?;

	comm_lib::database::batch_operations::batch_write(			comm_lib::database::batch_operations::batch_write(
	&self.client,			&self.client,
	devices_table::NAME,			devices_table::NAME,
	delete_requests,			delete_requests,
	Default::default(),			Default::default(),
	)			)
	.await?;			.await?;
	▲ Show 20 Lines • Show All 683 Lines • Show Last 20 Lines