Page MenuHomePhabricator
Differential D14185

[native] add graphics to QR Auth Flow
ClosedPublic
Actions

Authored by kamil on Wed, Jan 8, 5:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 22, 12:17 PM
Unknown Object (File)
Wed, Jan 22, 3:56 AM
Unknown Object (File)
Tue, Jan 21, 9:25 PM
Unknown Object (File)
Tue, Jan 21, 5:26 PM
Unknown Object (File)
Sun, Jan 19, 10:03 PM
Unknown Object (File)
Sat, Jan 18, 8:51 AM
Unknown Object (File)
Fri, Jan 17, 2:55 PM
Unknown Object (File)
Fri, Jan 17, 1:24 PM
View All 40 Files
Subscribers
ashoat

Details

Reviewers
angelika
tomek
Commits
rCOMMa3dcf5af2bc1: [native] add graphics to QR Auth Flow
Summary

ENG-10030.

Figma link

Scanning on native:

IMG_5127.PNG (1×828 px, 71 KB)

Scanning non-native:

IMG_5128.PNG (1×828 px, 71 KB)

Device not responding:

IMG_5129.PNG (1×828 px, 68 KB)

Device added:

IMG_5134.PNG (1×828 px, 68 KB)

Scanning on non-primary:

IMG_5135.PNG (1×828 px, 88 KB)

Recording of Flow:

Test Plan

Test Flow to navigate to all screens

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Wed, Jan 8, 5:33 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptWed, Jan 8, 5:33 AM
kamil removed a parent revision: D14166: [lib] rename `QRAuthContext` to `SecondaryDeviceQRAuthContext`.Wed, Jan 8, 5:34 AM
kamil added a parent revision: D14171: [native] move `<Auth*` components to a `/auth-components` directory.
kamil edited the summary of this revision. (Show Details)Wed, Jan 8, 5:38 AM
kamil added a parent revision: D14166: [lib] rename `QRAuthContext` to `SecondaryDeviceQRAuthContext`.
kamil updated this revision to Diff 46610.Wed, Jan 8, 5:43 AM

flow

kamil edited the summary of this revision. (Show Details)Wed, Jan 8, 5:43 AM
kamil removed a parent revision: D14166: [lib] rename `QRAuthContext` to `SecondaryDeviceQRAuthContext`.
Harbormaster failed remote builds in B33201: Diff 46609!Wed, Jan 8, 5:48 AM
kamil published this revision for review.Wed, Jan 8, 5:50 AM
Harbormaster completed remote builds in B33202: Diff 46610.Wed, Jan 8, 6:04 AM
tomek accepted this revision.Wed, Jan 8, 7:58 AM
This revision is now accepted and ready to land.Wed, Jan 8, 7:58 AM
kamil updated this revision to Diff 46630.Thu, Jan 9, 5:15 AM
kamil edited the summary of this revision. (Show Details)

minor improvements

Harbormaster completed remote builds in B33212: Diff 46630.Thu, Jan 9, 5:32 AM
Closed by commit rCOMMa3dcf5af2bc1: [native] add graphics to QR Auth Flow (authored by kamil). · Explain WhyThu, Jan 9, 5:41 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMa3dcf5af2bc1: [native] add graphics to QR Auth Flow.

Revision Contents
Changeset List

Diff 46631

View Options

native/account/qr-auth/connect-secondary-device.react.js

Loading...
View Options

native/account/qr-auth/qr-auth-not-primary-device.react.js

Loading...
View Options

native/account/qr-auth/secondary-device-connected.react.js

Loading...
View Options

native/account/qr-auth/secondary-device-not-responding.react.js

Loading...
View Options

native/vectors/connect-secondary-device-laptop-icon.react.js

Loading...
View Options

native/vectors/connect-secondary-device-mobile-icon.react.js

Loading...
View Options

native/vectors/device-not-primary-icon.react.js

Loading...
View Options

native/vectors/secondary-device-added-icon.react.js

Loading...
View Options

native/vectors/secondary-device-not-responding-icon.react.js

Loading...