Page MenuHomePhabricator
Differential D14166

[lib] rename `QRAuthContext` to `SecondaryDeviceQRAuthContext`
ClosedPublic
Actions

Authored by kamil on Dec 17 2024, 8:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 15, 12:27 PM
Unknown Object (File)
Sun, Apr 13, 12:14 PM
Unknown Object (File)
Mon, Mar 31, 7:27 AM
Unknown Object (File)
Wed, Mar 26, 4:06 PM
Unknown Object (File)
Wed, Mar 26, 1:10 PM
Unknown Object (File)
Wed, Mar 26, 3:59 AM
Unknown Object (File)
Tue, Mar 25, 11:05 AM
Unknown Object (File)
Mon, Mar 24, 6:43 PM
View All 63 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM9e9ce9532073: [lib] rename `QRAuthContext` to `SecondaryDeviceQRAuthContext`
Summary

In D14105 I introduced context and turned out, that what I added and existing context on the secondary side have the same names, to avoid confusion I am renaming them to SecondaryDeviceQRAuthContext and PrimaryDeviceQRAuthContext.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Dec 17 2024, 8:36 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptDec 17 2024, 8:36 AM
Harbormaster completed remote builds in B33168: Diff 46559.Dec 17 2024, 8:55 AM
kamil added a child revision: D14169: [native] rename `QRAuthContext` to `PrimaryDeviceQRAuthContext`.Dec 18 2024, 5:08 AM
kamil published this revision for review.Dec 19 2024, 1:59 AM
kamil added inline comments.
lib/components/secondary-device-qr-auth-context-provider.react.js
222 ↗(On Diff #46559)

Leftover

kamil updated this revision to Diff 46575.Dec 19 2024, 2:02 AM

fix typo

Harbormaster completed remote builds in B33179: Diff 46575.Dec 19 2024, 2:24 AM
bartek accepted this revision.Dec 19 2024, 5:17 AM
This revision is now accepted and ready to land.Dec 19 2024, 5:17 AM
kamil added a child revision: D14185: [native] add graphics to QR Auth Flow.Jan 8 2025, 5:33 AM
kamil removed a child revision: D14185: [native] add graphics to QR Auth Flow.Jan 8 2025, 5:34 AM
kamil added a child revision: D14185: [native] add graphics to QR Auth Flow.Jan 8 2025, 5:38 AM
kamil removed a child revision: D14185: [native] add graphics to QR Auth Flow.Jan 8 2025, 5:43 AM
Closed by commit rCOMM9e9ce9532073: [lib] rename `QRAuthContext` to `SecondaryDeviceQRAuthContext` (authored by kamil). · Explain WhyJan 9 2025, 4:16 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM9e9ce9532073: [lib] rename `QRAuthContext` to `SecondaryDeviceQRAuthContext`.

Revision Contents
Changeset List

PathSize
lib/
components/
23 lines
native/
account/
4 lines
6 lines
web/
account/
4 lines
6 lines

Diff 46626

View Options

lib/components/qr-auth-provider.react.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

lib/components/secondary-device-qr-auth-context-provider.react.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

native/account/qr-code-screen.react.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

native/root.react.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

web/account/qr-code-login.react.js

Loading...
View Options

web/app.react.js

Loading...