Page MenuHomePhabricator
Differential D14105

[native] implement QR Auth context
Needs ReviewPublic
Actions

Authored by kamil on Wed, Dec 11, 7:37 AM.

Details

Reviewers
ashoat
tomek
Summary

ENG-9959.

We need to wrap this logic in context so this will be available on all the screens in the flow.

This diff only introduces the context, not changing the logic - just moving it to the context.

In ENG-9968 there is an example of how this looks like

Depends on D14101

Test Plan

Test adding secondary device - should work exactly the same.

Diff Detail

Repository
rCOMM Comm
Branch
qr-work
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Wed, Dec 11, 7:37 AM
kamil held this revision as a draft.
kamil edited the summary of this revision. (Show Details)Wed, Dec 11, 7:37 AM
kamil added inline comments.
native/account/qr-auth/qr-auth-context.js
5–7

It will have more props later in the stack

kamil added a child revision: D14114: [native] implement screen when scanning QR code a non-primary device.Wed, Dec 11, 8:15 AM
Harbormaster completed remote builds in B33005: Diff 46323.Wed, Dec 11, 8:19 AM
kamil published this revision for review.Wed, Dec 11, 8:28 AM
kamil edited the summary of this revision. (Show Details)
ashoat added inline comments.Wed, Dec 11, 9:40 AM
native/account/qr-auth/qr-auth-context-provider.js
55

It's hard to review this one because you're removing a bunch of stuff (such as the permissions check), and I can't tell where (or whether) it's reintroduced

Revision Contents
Changeset List

PathSize
native/
account/
qr-auth/
qr-auth-context-provider.js
secondary-device-qr-code-scanner.react.js
231 lines
12 lines
17 lines
255 lines

Diff 46323

View Options

native/account/qr-auth/qr-auth-context-provider.js

Loading...
View Options

native/account/qr-auth/qr-auth-context.js

Loading...
View Options

native/account/qr-auth/qr-auth-navigator.react.js

Loading...
View Options

native/account/qr-auth/secondary-device-qr-code-scanner.react.js

Loading...