Page MenuHomePhabricator
Differential D14152

[native] implement screen when secondary device is not responding
ClosedPublic
Actions

Authored by kamil on Dec 12 2024, 11:34 AM.
Tags
None
Referenced Files
F5054206: D14152.diff
Tue, Mar 25, 5:31 AM
Unknown Object (File)
Thu, Mar 6, 2:54 PM
Unknown Object (File)
Thu, Mar 6, 2:53 PM
Unknown Object (File)
Thu, Mar 6, 2:53 PM
Unknown Object (File)
Wed, Mar 5, 3:32 PM
Unknown Object (File)
Mon, Mar 3, 6:22 AM
Unknown Object (File)
Feb 20 2025, 7:19 PM
Unknown Object (File)
Feb 18 2025, 9:14 AM
View All 49 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMe8e641205114: [native] implement screen when secondary device is not responding
Summary

ENG-9959.

Copy was discussed in ENG-8226#comment-dea392ea.

I am not sure how to solve this in terms of UX, the time when removing the device is pending:

  1. Like this, there might be a lag before navigating to Linked devices.
  2. Not await promise, but in this case user might see the device on the list, and will disappear after this promise is finished.
  3. Somehow show progress, but don't know how to handle the Ignore button then.

Also, swallowing errors here and just navigating to the Linked devices screen, we could show an Alert but wondering if this is worth it.

In ENG-9968 there is an example of how this looks like.

IMG_4790 (1).PNG (1×828 px, 57 KB)

Depends on D14151

Test Plan

Navigate to this screen

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Dec 12 2024, 11:34 AM
kamil held this revision as a draft.
kamil edited the summary of this revision. (Show Details)Dec 12 2024, 11:35 AM
kamil edited the summary of this revision. (Show Details)Dec 12 2024, 11:41 AM
kamil added a child revision: D14153: [native] handle waiting for secondary device response.Dec 12 2024, 11:49 AM
Harbormaster completed remote builds in B33066: Diff 46387.Dec 12 2024, 11:52 AM
kamil published this revision for review.Dec 12 2024, 11:58 AM
ashoat accepted this revision.Dec 12 2024, 12:24 PM

Rahul has a graphic almost ready for this! We can either amend it here, or handle it later if it takes a bit before he can deliver the final version.

native/account/qr-auth/secondary-device-not-responding.react.js
57 ↗(On Diff #46387)

Nit

72 ↗(On Diff #46387)

Let's add a period at the end here

This revision is now accepted and ready to land.Dec 12 2024, 12:24 PM
kamil updated this revision to Diff 46540.Dec 17 2024, 4:55 AM
  • add period
  • address nit
Harbormaster completed remote builds in B33161: Diff 46540.Dec 17 2024, 5:12 AM
Closed by commit rCOMMe8e641205114: [native] implement screen when secondary device is not responding (authored by kamil). · Explain WhyDec 17 2024, 7:06 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMe8e641205114: [native] implement screen when secondary device is not responding.

Revision Contents
Changeset List

PathSize
native/
account/
qr-auth/
7 lines
106 lines
navigation/
3 lines

Diff 46552

View Options

native/account/qr-auth/qr-auth-navigator.react.js

Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
export const ThreadSettingsNotificationsRouteName = export const ThreadSettingsNotificationsRouteName =
'ThreadSettingsNotifications'; 'ThreadSettingsNotifications';
export const IntroTipRouteName = 'IntroTip'; export const IntroTipRouteName = 'IntroTip';
export const CommunityDrawerTipRouteName = 'CommunityDrawerTip'; export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';
export const HomeTabTipRouteName = 'HomeTabTip'; export const HomeTabTipRouteName = 'HomeTabTip';
export const MutedTabTipRouteName = 'MutedTabTip'; export const MutedTabTipRouteName = 'MutedTabTip';
export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop'; export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';
export const QRAuthNavigatorRouteName = 'QRAuthNavigator'; export const QRAuthNavigatorRouteName = 'QRAuthNavigator';
export const QRAuthNotPrimaryDeviceRouteName = 'QRAuthNotPrimaryDevice';
export type RootParamList = { export type RootParamList = {
+LoggedOutModal: void, +LoggedOutModal: void,
+App: void, +App: void,
+ThreadPickerModal: ThreadPickerModalParams, +ThreadPickerModal: ThreadPickerModalParams,
+AddUsersModal: AddUsersModalParams, +AddUsersModal: AddUsersModalParams,
+CustomServerModal: CustomServerModalParams, +CustomServerModal: CustomServerModalParams,
+ColorSelectorModal: ColorSelectorModalParams, +ColorSelectorModal: ColorSelectorModalParams,
▲ Show 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
export type UserProfileBottomSheetParamList = { export type UserProfileBottomSheetParamList = {
+UserProfileBottomSheet: UserProfileBottomSheetParams, +UserProfileBottomSheet: UserProfileBottomSheetParams,
+UserProfileAvatarModal: UserProfileAvatarModalParams, +UserProfileAvatarModal: UserProfileAvatarModalParams,
+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams, +UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
}; };
export type QRAuthNavigatorParamList = { export type QRAuthNavigatorParamList = {
+SecondaryDeviceQRCodeScanner: void, +SecondaryDeviceQRCodeScanner: void,
+QRAuthNotPrimaryDevice: void,
}; };
export type ScreenParamList = { export type ScreenParamList = {
...RootParamList, ...RootParamList,
...OverlayParamList, ...OverlayParamList,
...TabParamList, ...TabParamList,
...ChatParamList, ...ChatParamList,
...ChatTopTabsParamList, ...ChatTopTabsParamList,
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines
View Options

native/account/qr-auth/secondary-device-not-responding.react.js

Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
export const ThreadSettingsNotificationsRouteName = export const ThreadSettingsNotificationsRouteName =
'ThreadSettingsNotifications'; 'ThreadSettingsNotifications';
export const IntroTipRouteName = 'IntroTip'; export const IntroTipRouteName = 'IntroTip';
export const CommunityDrawerTipRouteName = 'CommunityDrawerTip'; export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';
export const HomeTabTipRouteName = 'HomeTabTip'; export const HomeTabTipRouteName = 'HomeTabTip';
export const MutedTabTipRouteName = 'MutedTabTip'; export const MutedTabTipRouteName = 'MutedTabTip';
export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop'; export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';
export const QRAuthNavigatorRouteName = 'QRAuthNavigator'; export const QRAuthNavigatorRouteName = 'QRAuthNavigator';
export const QRAuthNotPrimaryDeviceRouteName = 'QRAuthNotPrimaryDevice';
export type RootParamList = { export type RootParamList = {
+LoggedOutModal: void, +LoggedOutModal: void,
+App: void, +App: void,
+ThreadPickerModal: ThreadPickerModalParams, +ThreadPickerModal: ThreadPickerModalParams,
+AddUsersModal: AddUsersModalParams, +AddUsersModal: AddUsersModalParams,
+CustomServerModal: CustomServerModalParams, +CustomServerModal: CustomServerModalParams,
+ColorSelectorModal: ColorSelectorModalParams, +ColorSelectorModal: ColorSelectorModalParams,
▲ Show 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
export type UserProfileBottomSheetParamList = { export type UserProfileBottomSheetParamList = {
+UserProfileBottomSheet: UserProfileBottomSheetParams, +UserProfileBottomSheet: UserProfileBottomSheetParams,
+UserProfileAvatarModal: UserProfileAvatarModalParams, +UserProfileAvatarModal: UserProfileAvatarModalParams,
+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams, +UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
}; };
export type QRAuthNavigatorParamList = { export type QRAuthNavigatorParamList = {
+SecondaryDeviceQRCodeScanner: void, +SecondaryDeviceQRCodeScanner: void,
+QRAuthNotPrimaryDevice: void,
}; };
export type ScreenParamList = { export type ScreenParamList = {
...RootParamList, ...RootParamList,
...OverlayParamList, ...OverlayParamList,
...TabParamList, ...TabParamList,
...ChatParamList, ...ChatParamList,
...ChatTopTabsParamList, ...ChatTopTabsParamList,
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines
View Options

native/navigation/route-names.js

Show First 20 Lines • Show All 174 Lines • ▼ Show 20 Lines
export const ThreadSettingsNotificationsRouteName = export const ThreadSettingsNotificationsRouteName =
'ThreadSettingsNotifications'; 'ThreadSettingsNotifications';
export const IntroTipRouteName = 'IntroTip'; export const IntroTipRouteName = 'IntroTip';
export const CommunityDrawerTipRouteName = 'CommunityDrawerTip'; export const CommunityDrawerTipRouteName = 'CommunityDrawerTip';
export const HomeTabTipRouteName = 'HomeTabTip'; export const HomeTabTipRouteName = 'HomeTabTip';
export const MutedTabTipRouteName = 'MutedTabTip'; export const MutedTabTipRouteName = 'MutedTabTip';
export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop'; export const NUXTipOverlayBackdropRouteName = 'NUXTipOverlayBackdrop';
export const QRAuthNavigatorRouteName = 'QRAuthNavigator'; export const QRAuthNavigatorRouteName = 'QRAuthNavigator';
export const QRAuthNotPrimaryDeviceRouteName = 'QRAuthNotPrimaryDevice';
export type RootParamList = { export type RootParamList = {
+LoggedOutModal: void, +LoggedOutModal: void,
+App: void, +App: void,
+ThreadPickerModal: ThreadPickerModalParams, +ThreadPickerModal: ThreadPickerModalParams,
+AddUsersModal: AddUsersModalParams, +AddUsersModal: AddUsersModalParams,
+CustomServerModal: CustomServerModalParams, +CustomServerModal: CustomServerModalParams,
+ColorSelectorModal: ColorSelectorModalParams, +ColorSelectorModal: ColorSelectorModalParams,
▲ Show 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
export type UserProfileBottomSheetParamList = { export type UserProfileBottomSheetParamList = {
+UserProfileBottomSheet: UserProfileBottomSheetParams, +UserProfileBottomSheet: UserProfileBottomSheetParams,
+UserProfileAvatarModal: UserProfileAvatarModalParams, +UserProfileAvatarModal: UserProfileAvatarModalParams,
+UserRelationshipTooltipModal: UserRelationshipTooltipModalParams, +UserRelationshipTooltipModal: UserRelationshipTooltipModalParams,
}; };
export type QRAuthNavigatorParamList = { export type QRAuthNavigatorParamList = {
+SecondaryDeviceQRCodeScanner: void, +SecondaryDeviceQRCodeScanner: void,
+QRAuthNotPrimaryDevice: void,
}; };
export type ScreenParamList = { export type ScreenParamList = {
...RootParamList, ...RootParamList,
...OverlayParamList, ...OverlayParamList,
...TabParamList, ...TabParamList,
...ChatParamList, ...ChatParamList,
...ChatTopTabsParamList, ...ChatTopTabsParamList,
▲ Show 20 Lines • Show All 50 Lines • Show Last 20 Lines