Page MenuHomePhabricator
Differential D14114

[native] implement screen when scanning QR code a non-primary device
ClosedPublic
Actions

Authored by kamil on Dec 11 2024, 8:15 AM.
Tags
None
Referenced Files
F5026272: D14114.id46549.diff
Mon, Mar 24, 11:45 AM
F5025878: D14114.id46332.diff
Mon, Mar 24, 7:45 AM
Unknown Object (File)
Wed, Mar 19, 11:08 AM
Unknown Object (File)
Sat, Mar 15, 12:21 AM
Unknown Object (File)
Sat, Mar 15, 12:21 AM
Unknown Object (File)
Sat, Mar 15, 12:20 AM
Unknown Object (File)
Sat, Mar 15, 12:20 AM
Unknown Object (File)
Fri, Mar 14, 6:22 AM
View All 45 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM5811d1942814: [native] implement screen when scanning QR code a non-primary device
Summary

ENG-9959.

Copy is taken from ENG-9936

Styles are taken from similar register screens, and there is a chance that those will duplicate with other QR Auth screens - if so I am going to refactor this but for now I prefer to keep this like this if there are any changes needed specific to a screen.

Also, after this is done maybe worth renaming the <Registration* components to <Auth* components to avoid confusion.

In ENG-9968 there is an example of what the flow looks like.

IMG_375B92D671D6-1.jpeg (1×828 px, 130 KB)

Depends on D14105

Test Plan

Navigate to screen

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Dec 11 2024, 8:15 AM
kamil held this revision as a draft.
kamil added a child revision: D14115: [native] implement screen when connecting secondary device.
kamil edited the summary of this revision. (Show Details)Dec 11 2024, 8:20 AM
kamil added inline comments.
native/account/qr-auth/qr-auth-not-primary-device.react.js
57 ↗(On Diff #46332)

This probably needs to be updated as this is not taking user back (to camera) but to Linked Devices screen

kamil published this revision for review.Dec 11 2024, 8:29 AM
Harbormaster completed remote builds in B33014: Diff 46332.Dec 11 2024, 9:49 AM
ashoat accepted this revision.Dec 12 2024, 10:58 AM
ashoat added inline comments.
native/account/qr-auth/qr-auth-not-primary-device.react.js
57 ↗(On Diff #46332)

Not sure it matters a ton

This revision is now accepted and ready to land.Dec 12 2024, 10:58 AM
Closed by commit rCOMM5811d1942814: [native] implement screen when scanning QR code a non-primary device (authored by kamil). · Explain WhyDec 17 2024, 7:06 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM5811d1942814: [native] implement screen when scanning QR code a non-primary device.
kamil mentioned this in D14170: [native] rename `<Registration*` components to `<Auth*` components.Dec 18 2024, 5:20 AM
kamil mentioned this in D14171: [native] move `<Auth*` components to a `/auth-components` directory.Dec 18 2024, 5:57 AM
kamil mentioned this in rCOMM39d7f06a7465: [native] rename `<Registration*` components to `<Auth*` components.Jan 9 2025, 4:16 AM
kamil mentioned this in rCOMMef2bd4d961f0: [native] move `<Auth*` components to a `/auth-components` directory.

Revision Contents
Changeset List

PathSize
native/
account/
qr-auth/
6 lines
80 lines
navigation/
2 lines

Diff 46548

View Options

native/account/qr-auth/qr-auth-navigator.react.js

Loading...
View Options

native/account/qr-auth/qr-auth-not-primary-device.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...