Page MenuHomePhabricator

[native] implement screen when scanning QR code a non-primary device
AcceptedPublic

Authored by kamil on Wed, Dec 11, 8:15 AM.

Details

Reviewers
ashoat
tomek
Summary

ENG-9959.

Copy is taken from ENG-9936

Styles are taken from similar register screens, and there is a chance that those will duplicate with other QR Auth screens - if so I am going to refactor this but for now I prefer to keep this like this if there are any changes needed specific to a screen.

Also, after this is done maybe worth renaming the <Registration* components to <Auth* components to avoid confusion.

In ENG-9968 there is an example of what the flow looks like.

IMG_375B92D671D6-1.jpeg (1×828 px, 130 KB)

Depends on D14105

Test Plan

Navigate to screen

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil added inline comments.
native/account/qr-auth/qr-auth-not-primary-device.react.js
57

This probably needs to be updated as this is not taking user back (to camera) but to Linked Devices screen

kamil published this revision for review.Wed, Dec 11, 8:29 AM
ashoat added inline comments.
native/account/qr-auth/qr-auth-not-primary-device.react.js
57

Not sure it matters a ton

This revision is now accepted and ready to land.Thu, Dec 12, 10:58 AM