[native] update `PrimaryButton` to handle light theme
ClosedPublic
Actions

Authored by kamil on Dec 17 2024, 10:41 AM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM5e9bd8ad9676: [native] update `PrimaryButton` to handle light theme

Summary

Part of ENG-9959.

Tracked in ENG-10025.

Rendered all possible button variants in this order:

enabled
disabled
loading
outline
danger

Light theme:

Screenshot 2024-12-17 at 11.54.34.png (636×738 px, 50 KB)

Dark theme:

Screenshot 2024-12-17 at 11.54.50.png (606×720 px, 50 KB)

Depends on D14159

Test Plan

Render button

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Dec 17 2024, 10:41 AM

kamil held this revision as a draft.

kamil edited the summary of this revision. (Show Details)Dec 17 2024, 10:55 AM

kamil added a child revision: D14162: [native] use `HeaderBackButton` in QR Auth Flow to support light theme.Dec 17 2024, 10:59 AM

Harbormaster completed remote builds in B33154: Diff 46529.Dec 17 2024, 10:59 AM

kamil published this revision for review.Dec 17 2024, 11:20 AM

tomek accepted this revision.Dec 18 2024, 11:36 AM

This revision is now accepted and ready to land.Dec 18 2024, 11:36 AM

Closed by commit rCOMM5e9bd8ad9676: [native] update `PrimaryButton` to handle light theme. · Explain WhyDec 18 2024, 12:29 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM5e9bd8ad9676: [native] update `PrimaryButton` to handle light theme.

Revision Contents
Changeset List

Path

Size

native/

components/

primary-button.react.js

8 lines

Diff 46564

View Options

native/components/primary-button.react.js

[native] update `PrimaryButton` to handle light themeClosedPublicActions