Paths

Table of Contentst

[native] update `PrimaryButton` to handle light theme
AcceptedPublic
Actions

Authored by kamil on Tue, Dec 17, 2:41 AM.

Tags

None

Referenced Files

	F3485175: D14161.id46529.diff
	Tue, Dec 17, 6:50 PM

	F3485156: D14161.id.diff
	Tue, Dec 17, 6:49 PM

	F3485145: D14161.diff
	Tue, Dec 17, 6:48 PM

	F3481427: Screenshot 2024-12-17 at 11.54.50.png
	Tue, Dec 17, 2:55 AM

	F3481426: Screenshot 2024-12-17 at 11.54.34.png
	Tue, Dec 17, 2:55 AM

Subscribers

None

Details

Reviewers

ashoat
tomek

Summary

Part of ENG-9959.

Tracked in ENG-10025.

Rendered all possible button variants in this order:

enabled
disabled
loading
outline
danger

Light theme:

Screenshot 2024-12-17 at 11.54.34.png (636×738 px, 50 KB)

Dark theme:

Screenshot 2024-12-17 at 11.54.50.png (606×720 px, 50 KB)

Depends on D14159

Test Plan

Render button

Diff Detail

Repository

rCOMM Comm

Branch

qr-work

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Tue, Dec 17, 2:41 AM

kamil held this revision as a draft.

kamil edited the summary of this revision. (Show Details)Tue, Dec 17, 2:55 AM

kamil added a child revision: D14162: [native] use `HeaderBackButton` in QR Auth Flow to support light theme.Tue, Dec 17, 2:59 AM

Harbormaster completed remote builds in B33154: Diff 46529.Tue, Dec 17, 2:59 AM

kamil published this revision for review.Tue, Dec 17, 3:20 AM

tomek accepted this revision.Wed, Dec 18, 3:36 AM

This revision is now accepted and ready to land.Wed, Dec 18, 3:36 AM

Revision Contents
Changeset List

Path

Size

native/

components/

primary-button.react.js

8 lines

Diff 46529

View Options

native/components/primary-button.react.js

[native] update `PrimaryButton` to handle light themeAcceptedPublicActions