[native] Don't refetch nonce from identity after identity auth
ClosedPublic
Actions

Authored by ashoat on Wed, Apr 24, 12:45 PM.

Details

Reviewers

varun
tomek

Commits

rCOMM7ad3d18e3433: [native] Don't refetch nonce from identity after identity auth

Summary

Noticed that generateNonce was getting called after the user auth'd with identity, probably because the effect was re-run.

Adding this condition prevented it from getting rerun unnecessarily.

Test Plan

Confirm that I'm not seeing IDENTITY_GENERATE_NONCE_STARTED and IDENTITY_GENERATE_NONCE_SUCCESS dispatched after identity auth during login

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Wed, Apr 24, 12:45 PM

Harbormaster completed remote builds in B28448: Diff 39458.Wed, Apr 24, 1:41 PM

ashoat requested review of this revision.Wed, Apr 24, 1:41 PM

tomek accepted this revision.Thu, Apr 25, 6:44 AM

This revision is now accepted and ready to land.Thu, Apr 25, 6:44 AM

Closed by commit rCOMM7ad3d18e3433: [native] Don't refetch nonce from identity after identity auth (authored by ashoat). · Explain WhyThu, Apr 25, 8:03 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM7ad3d18e3433: [native] Don't refetch nonce from identity after identity auth.

ashoat added a reverting change: rCOMM57e75feedec7: Revert "[native] Don't refetch nonce from identity after identity auth".Thu, Apr 25, 4:01 PM

ashoat mentioned this in D11794: [native] Don't refetch nonce after SIWE is complete.Thu, Apr 25, 4:06 PM

ashoat mentioned this in rCOMMaa57bc6d30c8: [native] Don't refetch nonce after SIWE is complete.Fri, Apr 26, 7:59 AM

Revision Contents
Changeset List

Path

Size

native/

account/

siwe-panel.react.js

8 lines

Diff 39489

View Options

native/account/siwe-panel.react.js

[native] Don't refetch nonce from identity after identity authClosedPublicActions