Show All 19 Lines	import {
type FetchMessageInfosRequest,		type FetchMessageInfosRequest,
defaultNumberPerThread,		defaultNumberPerThread,
type SendMessageResponse,		type SendMessageResponse,
type SendEditMessageResponse,		type SendEditMessageResponse,
type FetchPinnedMessagesRequest,		type FetchPinnedMessagesRequest,
type FetchPinnedMessagesResult,		type FetchPinnedMessagesResult,
type SearchMessagesResponse,		type SearchMessagesResponse,
type SearchMessagesKeyserverRequest,		type SearchMessagesKeyserverRequest,
		type DeleteMessageRequest,
		type DeleteMessageResponse,
		isComposableMessageType,
} from 'lib/types/message-types.js';		} from 'lib/types/message-types.js';
		import type { DeleteMessageData } from 'lib/types/messages/delete.js';
import type { EditMessageData } from 'lib/types/messages/edit.js';		import type { EditMessageData } from 'lib/types/messages/edit.js';
import type { ReactionMessageData } from 'lib/types/messages/reaction.js';		import type { ReactionMessageData } from 'lib/types/messages/reaction.js';
import type { TextMessageData } from 'lib/types/messages/text.js';		import type { TextMessageData } from 'lib/types/messages/text.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js';		import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { ServerError } from 'lib/utils/errors.js';		import { ServerError } from 'lib/utils/errors.js';
import { values } from 'lib/utils/objects.js';		import { values } from 'lib/utils/objects.js';
import {		import {
tRegex,		tRegex,
▲ Show 20 Lines • Show All 373 Lines • ▼ Show 20 Lines	): Promise<SearchMessagesResponse> {
return await searchMessagesInSingleChat(		return await searchMessagesInSingleChat(
request.query,		request.query,
request.threadID,		request.threadID,
viewer,		viewer,
request.cursor,		request.cursor,
);		);
}		}

		export const deleteMessageRequestValidator: TInterface<DeleteMessageRequest> =
		tShape<DeleteMessageRequest>({
		targetMessageID: tID,
		});

		async function deleteMessageResponder(
		viewer: Viewer,
		request: DeleteMessageRequest,
		): Promise<DeleteMessageResponse> {
		const { targetMessageID } = request;

		const targetMessageInfo = await fetchMessageInfoByID(viewer, targetMessageID);
		if (!targetMessageInfo \|\| !targetMessageInfo.id) {
		throw new ServerError('invalid_parameters');
		}

		if (!isComposableMessageType(targetMessageInfo.type)) {
		throw new ServerError('invalid_parameters');
		}

		const { threadID } = targetMessageInfo;

		const [
		serverThreadInfos,
		hasDeleteOwnMessagesPermission,
		hasDeleteAllMessagesPermission,
		rawSidebarThreadInfos,
		] = await Promise.all([
		fetchServerThreadInfos({ threadID }),
		checkThreadPermission(
		viewer,
		threadID,
		threadPermissions.DELETE_OWN_MESSAGES,
		),
		checkThreadPermission(
		viewer,
		threadID,
		threadPermissions.DELETE_ALL_MESSAGES,
		),
		ashoatUnsubmitted Not Done Inline Actions We are issuing the exact same query here twice at the same time. Can this be avoided? ashoat: We are issuing the exact same query here twice at the same time. Can this be avoided?
		fetchServerThreadInfos({
		parentThreadID: threadID,
		sourceMessageID: targetMessageID,
		}),
		]);

		const targetMessageThreadInfo = serverThreadInfos.threadInfos[threadID];
		if (targetMessageThreadInfo.sourceMessageID === targetMessageID) {
		// We are deleting first message of the sidebar
		// If client wants to do that it sends id of the sourceMessage instead
		ashoatUnsubmitted Not Done Inline Actions This comment is a bit confusing... you suggest that the client should send the ID of the `sourceMessage` instead, but the check seems to indicate that is exactly what the client did (it sent `targetMessageThreadInfo.sourceMessageID`, right?) ashoat: This comment is a bit confusing... you suggest that the client should send the ID of the…
		throw new ServerError('invalid_parameters');
		}

		if (
		!hasDeleteAllMessagesPermission &&
		!(
		hasDeleteOwnMessagesPermission &&
		targetMessageInfo.creatorID !== viewer.id
		)
		) {
		throw new ServerError('invalid_parameters');
		}
		ashoatUnsubmitted Not Done Inline Actions Should we add another check here to prevent the client from deleting a `sidebarCreation` message? Context here ashoat: Should we add another check here to prevent the client from deleting a `sidebarCreation`…

		const time = Date.now();
		const messagesData: Array<DeleteMessageData> = [];
		messagesData.push({
		type: messageTypes.DELETE_MESSAGE,
		threadID,
		creatorID: viewer.id,
		time,
		targetMessageID,
		});

		const sidebarThreadValues = values(rawSidebarThreadInfos.threadInfos);
		for (const sidebarThreadValue of sidebarThreadValues) {
		if (sidebarThreadValue && sidebarThreadValue.id) {
		messagesData.push({
		type: messageTypes.DELETE_MESSAGE,
		threadID: sidebarThreadValue.id,
		creatorID: viewer.id,
		time,
		targetMessageID,
		});
		ashoatUnsubmitted Not Done Inline Actions What is the effect of deleting the `SIDEBAR_SOURCE` message like this? Should it be allowed? ashoat: What is the effect of deleting the `SIDEBAR_SOURCE` message like this? Should it be allowed?
		}
		}

		const newMessageInfos = await createMessages(viewer, messagesData);

		return { newMessageInfos };
		}

export {		export {
textMessageCreationResponder,		textMessageCreationResponder,
messageFetchResponder,		messageFetchResponder,
multimediaMessageCreationResponder,		multimediaMessageCreationResponder,
reactionMessageCreationResponder,		reactionMessageCreationResponder,
editMessageCreationResponder,		editMessageCreationResponder,
fetchPinnedMessagesResponder,		fetchPinnedMessagesResponder,
searchMessagesResponder,		searchMessagesResponder,
		deleteMessageResponder,
};		};

[native] Don't refetch nonce from identity after identity authClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39489

native/account/siwe-panel.react.js

[native] Don't refetch nonce from identity after identity auth
ClosedPublic
Actions

Revision Contents
Changeset List