Page MenuHomePhabricator

[native] Don't refetch nonce after SIWE is complete
ClosedPublic

Authored by ashoat on Apr 25 2024, 4:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 8:04 AM
Unknown Object (File)
Sun, Nov 24, 9:43 PM
Unknown Object (File)
Sun, Nov 3, 12:16 PM
Unknown Object (File)
Nov 3 2024, 6:06 AM
Unknown Object (File)
Nov 3 2024, 6:06 AM
Unknown Object (File)
Nov 3 2024, 6:06 AM
Unknown Object (File)
Nov 3 2024, 6:06 AM
Unknown Object (File)
Nov 3 2024, 6:06 AM
Subscribers
None

Details

Summary

This is an alternative to D11771, which has been reverted because it caused ENG-7969.

Test Plan
  1. Tested main SIWE workflow
  2. Tested backup secret generation via SIWE
  3. Tested what happens when we get an expired nonce in the main SIWE workflow
  4. Read through the code carefully (all three uses of SIWEPanel) to make sure that in all cases, once onClosing or onClosed is triggered, the SIWEPanel will be unmounted

I tested both SIWE and backup generation, as well as some error cases such as expired nonce. I also read through the code carefully to make

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin added inline comments.
native/account/siwe-panel.react.js
85 ↗(On Diff #39520)

I would rename it to something more specific like: nonceFetchingCompletedRef.

This revision is now accepted and ready to land.Apr 26 2024, 1:10 AM

doneRef -> nonceNotNeededRef

This revision was landed with ongoing or failed builds.Apr 26 2024, 7:59 AM
This revision was automatically updated to reflect the committed changes.