Page MenuHomePhabricator
Differential D11794

[native] Don't refetch nonce after SIWE is complete
ClosedPublic
Actions

Authored by ashoat on Thu, Apr 25, 4:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 8:42 PM
Unknown Object (File)
Tue, Apr 30, 12:12 PM
Unknown Object (File)
Tue, Apr 30, 11:00 AM
Unknown Object (File)
Sun, Apr 28, 8:13 PM
Unknown Object (File)
Thu, Apr 25, 6:30 PM
Unknown Object (File)
Thu, Apr 25, 6:26 PM
Subscribers
None

Details

Reviewers
tomek
marcin
Commits
rCOMMaa57bc6d30c8: [native] Don't refetch nonce after SIWE is complete
Summary

This is an alternative to D11771, which has been reverted because it caused ENG-7969.

Test Plan
  1. Tested main SIWE workflow
  2. Tested backup secret generation via SIWE
  3. Tested what happens when we get an expired nonce in the main SIWE workflow
  4. Read through the code carefully (all three uses of SIWEPanel) to make sure that in all cases, once onClosing or onClosed is triggered, the SIWEPanel will be unmounted

I tested both SIWE and backup generation, as well as some error cases such as expired nonce. I also read through the code carefully to make

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Thu, Apr 25, 4:06 PM
Harbormaster completed remote builds in B28490: Diff 39520.Thu, Apr 25, 4:23 PM
ashoat requested review of this revision.Thu, Apr 25, 4:23 PM
marcin accepted this revision.Fri, Apr 26, 1:10 AM
marcin added inline comments.
native/account/siwe-panel.react.js
85 ↗(On Diff #39520)

I would rename it to something more specific like: nonceFetchingCompletedRef.

This revision is now accepted and ready to land.Fri, Apr 26, 1:10 AM
marcin added a parent revision: D11645: Force already logged in ETH users to create and sign backup message.Fri, Apr 26, 1:21 AM
marcin added a child revision: D11781: Move MissingRegistrationDataHandler to NavigationHandler.
ashoat updated this revision to Diff 39547.Fri, Apr 26, 7:59 AM

doneRef -> nonceNotNeededRef

This revision was landed with ongoing or failed builds.Fri, Apr 26, 7:59 AM
Closed by commit rCOMMaa57bc6d30c8: [native] Don't refetch nonce after SIWE is complete (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMaa57bc6d30c8: [native] Don't refetch nonce after SIWE is complete.
Harbormaster completed remote builds in B28512: Diff 39547.Fri, Apr 26, 8:15 AM

Revision Contents
Changeset List

PathSize
native/
account/
20 lines

Diff 39548

View Options

native/account/siwe-panel.react.js

Loading...