Details
Details
- Tested main SIWE workflow
- Tested backup secret generation via SIWE
- Tested what happens when we get an expired nonce in the main SIWE workflow
- Read through the code carefully (all three uses of SIWEPanel) to make sure that in all cases, once onClosing or onClosed is triggered, the SIWEPanel will be unmounted
I tested both SIWE and backup generation, as well as some error cases such as expired nonce. I also read through the code carefully to make
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
native/account/siwe-panel.react.js | ||
---|---|---|
85 ↗ | (On Diff #39520) | I would rename it to something more specific like: nonceFetchingCompletedRef. |