Page MenuHomePhabricator
Differential D11735

Introduce new JSI call to retrieve backup message for latest siwe backup
AcceptedPublic
Actions

Authored by marcin on Tue, Apr 23, 3:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 7:28 AM
Unknown Object (File)
Thu, May 2, 2:31 AM
Unknown Object (File)
Mon, Apr 29, 2:28 PM
Unknown Object (File)
Sat, Apr 27, 1:36 PM
Unknown Object (File)
Thu, Apr 25, 6:40 PM
Unknown Object (File)
Tue, Apr 23, 9:18 PM
Unknown Object (File)
Tue, Apr 23, 9:18 PM
Unknown Object (File)
Tue, Apr 23, 9:17 PM
Subscribers
ashoat
tomek

Details

Reviewers
kamil
bartek
Summary

This differential introduces new JSI call to fetch latest backup id and associated backup message for SIWE user.

Test Plan
  1. Log in as SIWE user.
  2. In use-backu-client add call to this function after awaiting createNewBackup. Log the result.
  3. Ensure that the result logged is the same as backup message in dynamodb web viewer.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-5267
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Tue, Apr 23, 3:56 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Apr 23, 3:56 AM
marcin added a parent revision: D11734: Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse'.Tue, Apr 23, 3:57 AM
Harbormaster completed remote builds in B28397: Diff 39392.Tue, Apr 23, 4:12 AM
marcin requested review of this revision.Tue, Apr 23, 4:12 AM
bartek requested changes to this revision.Wed, Apr 24, 2:09 AM
bartek added inline comments.
native/schema/CommCoreModuleSchema.js
163 ↗(On Diff #39392)

The Rust retrieve_latest_siwe_backup_data() calls handle_string_result_as_callback but here you have Promise<void>

This revision now requires changes to proceed.Wed, Apr 24, 2:09 AM
marcin updated this revision to Diff 39542.Fri, Apr 26, 6:26 AM
  1. Rename msg_backup to siwe_backup_message
  2. Fix JSI type
Harbormaster completed remote builds in B28507: Diff 39542.Fri, Apr 26, 7:00 AM
bartek accepted this revision.Sun, Apr 28, 11:07 PM
This revision is now accepted and ready to land.Sun, Apr 28, 11:07 PM

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
1 line
9 lines
_generated/
native_rust_library/
src/
69 lines
3 lines
schema/
1 line

Diff 39542

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/native_rust_library/src/backup.rs

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...